From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Ma Ke <make24@iscas.ac.cn>,
nico@fluxnic.net, will@kernel.org, punitagrawal@gmail.com,
akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] arm-cci: Fix refcount leak in cci_probe
Date: Mon, 19 Aug 2024 15:28:56 +0100 [thread overview]
Message-ID: <7e166d5f-a8cf-46ab-a95d-46bacec58f5f@arm.com> (raw)
In-Reply-To: <20240819090405.1014759-1-make24@iscas.ac.cn>
On 19/08/2024 10:04, Ma Ke wrote:
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().
>
> Cc: stable@vger.kernel.org
> Fixes: f6b9e83ce05e ("arm-cci: Rearrange code for splitting PMU vs driver code")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/bus/arm-cci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index b8184a903583..6be7b05b5ff1 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -548,6 +548,7 @@ static int cci_probe(void)
> }
> if (ret || !cci_ctrl_base) {
> WARN(1, "unable to ioremap CCI ctrl\n");
> + of_node_put(np);
> return -ENXIO;
> }
>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
prev parent reply other threads:[~2024-08-19 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 9:04 Ma Ke
2024-08-19 14:28 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e166d5f-a8cf-46ab-a95d-46bacec58f5f@arm.com \
--to=suzuki.poulose@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=nico@fluxnic.net \
--cc=punitagrawal@gmail.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®