From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF49948987E for ; Fri, 14 Aug 2026 16:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786723483; cv=none; b=TBaJEiUAsj4g8bH5OvTvJI877iDa6sU2NQ3YMQmpI1FLPfAsvzoKsl1JTF3+6zsW+vqnF0L9hpp0HSQZTc9ZkRptdlpknQkyZnQVTKBy0IGFz7SbEk1Z8fvTiKP/0r/uTTJgXk1CfW7+nC0YD4+egMulnxAW1HrG/D8gSiO2v3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786723483; c=relaxed/simple; bh=52qCRrZb2SMRCcmFeD6ZAbxvhqKc5jQN4x92ylGefnE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d/B8G+oNtNdk705x+h3vyLkrjVH317bG/Ecpx0ANHeYZ4791Zglf1oJZuofCcSC2adfInksNJbZNSu9CzQ5tJRINa/4JFAlyA6+0wrHL971lu3ZMgmo8RPKngX6qaKhbNZCUBccy+/BEdkhFX2hYOgO7Z+VwyDoinHWnGRhr0jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidwei.uk; spf=none smtp.mailfrom=davidwei.uk; dkim=pass (2048-bit key) header.d=davidwei-uk.20251104.gappssmtp.com header.i=@davidwei-uk.20251104.gappssmtp.com header.b=RNqflWah; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=davidwei.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=davidwei.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=davidwei-uk.20251104.gappssmtp.com header.i=@davidwei-uk.20251104.gappssmtp.com header.b="RNqflWah" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7ec49608332so722365a34.3 for ; Fri, 14 Aug 2026 09:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=davidwei-uk.20251104.gappssmtp.com; s=20251104; t=1786723478; x=1787328278; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eZdEAU+RA4hG/xm/Q4y+B1YPvOJHTrAQedhhdFxab1c=; b=RNqflWahBCsLWj3fGqUb+K1nVtQHHr9HkS9nM46NhzOtrQyR0qyOGvp8zeOtClpOJS e29CEzcZ6WYvAXBfD2Q4qmam0srSrHzIo2pxywSrm5cCPU+8FX+kARdtBdJQ+SCNVh7p uw+bFzySZAd3HWHshPgl+Jf/pyfMvZ/FN32SEWjpxeZCpSE34OyqQtjqVyJAgC4s0Qth qO0K8VqxrIPxz0qCmjatWqLsjfj9MKQ9m3aVVkN7uywSLGvdUmE4ze3/85Bw7Cc5avub C2JrBVEOK29yRU7Gse0dS2ATFVgSda+nTkZ71sgp08JZCiQ8urEZla9J+ZPQgQYILFUT HPEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786723478; x=1787328278; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eZdEAU+RA4hG/xm/Q4y+B1YPvOJHTrAQedhhdFxab1c=; b=AdNGd2uET+Ln3Wz22lepyukADRMLERK2fW2Su9hiux9EC9z7ZKmXygnKeo07+8QJCv 7/jMqIyqTTV8lLVbY/+EAsMXO8ILnTwJxaIFmJaDTiEGpL23FF1jePhcLw4HINL7VFps j+0twf48TTCcYW9Q4ESojvl4g4NOUL1dnKaR8VwWqvkqVH3ot286t/T2NG1Hj5lQ6olf +OE7g4W1LMB5nKPDhVwq1Dpnf15nvRre9ixwvHFnyPqJLSRkVQKV8w2KexWMnm0Jn/vR aCJnb47BeP1UL3bMyh1Cm8o+txqwE3gquvHi+uhLCioSAaLaMTlkcmLn5D5TMMrlfJU+ s/Fw== X-Forwarded-Encrypted: i=1; AHgh+Ro0uJ2GhnkO8eeuV9hQ+fuz9QTIEMqKsYksaKkfczGw+U8G82EghrMFIohQrK9Q1Jbo2aPYkEd8opr1Z4Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxGEG+Kq7l8WR0BIP2gVO5vs2ysR0l7iXMfW0+5CDT6OEkCVb2Y z1w6nowbDhXK17GItWsjbk4uJ7aFmLBODy0HX26moFpMuU+RqZbaf+2DK3AJ4Ev/Jgs= X-Gm-Gg: AR+sD10Qe5E3kptt8HUBygDbgjPTxxWWWD+cllatdARgRV/2Hp5v88CWnJtvd3o0GNB ymAHzUriEGw9LF9qGiZr85pDz3ZwKTbauRbtUorW/mkeuZpPGdIhe4yff3KKjU8mTaBl+WrimTS wKYfTbTlD8ahZTvKxCOVBTYEAxxoZnwx5kJHj1WE8BDlgrGrXH+XrzCJMh6wSxAz4LQMGf55YbF Adob/PxYKNTfc81PyqhVZBn1V5jikDn1JdfkrLV+EHmMERq8S7KoBu3aAiqIWiquuotnAHRYLf1 TrFMdXYZFz+ubsk/IXelAjtu0BdR99FARE5KUVKTOj2i2bgALVoHr3jJqtqtR2DdY7WkQmgI+px J++FVYZMHzVymik+KHcaYBXp9XXrPJrybJggHKvHF2twi5lDMpGQsWKTBPSdYaW1TNeVrjv5CiD zNYrju9sYaR/NskMe20t/j/VqglEsTqVdwWnOX9CpSOntkIp1Xpj1H9i0qzR2+Z0Tu5BsoF+9ER UXntwMbBpvpwChjciiF55GnyWLqOCudHDfm5CoroddzdgTM3Adooh/smXGt3TD9KUCK8xIc X-Received: by 2002:a05:6820:1513:b0:6b0:ac70:f741 with SMTP id 006d021491bc7-6b0d690bfc2mr5364333eaf.28.1786723478104; Fri, 14 Aug 2026 09:04:38 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1156:1:c8f:b917:4342:fa09? ([2620:10d:c090:500::4:a11e]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6b0db240128sm2104198eaf.13.2026.08.14.09.04.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 09:04:37 -0700 (PDT) Message-ID: <7e1a7fab-ea77-4373-ba7d-a3ce5aa73ba1@davidwei.uk> Date: Fri, 14 Aug 2026 09:04:35 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 4/6] selftests: net: add multithread client support to iou-zcrx To: Juanlu Herrero , netdev@vger.kernel.org Cc: io-uring@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, asml.silence@gmail.com, pabeni@redhat.com, shuah@kernel.org References: <20260814012348.46958-1-juanlu@fastmail.com> <20260814012348.46958-5-juanlu@fastmail.com> Content-Language: en-US From: David Wei In-Reply-To: <20260814012348.46958-5-juanlu@fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-08-13 18:23, Juanlu Herrero wrote: > Add pthreads to the iou-zcrx client so that multiple connections can be > established simultaneously. Each client thread connects to the server > and sends its payload independently. > > Introduce the -t option to control the number of threads (default 1), > preserving backwards compatibility with existing tests. > > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Juanlu Herrero > --- > .../testing/selftests/drivers/net/hw/Makefile | 2 +- > .../selftests/drivers/net/hw/iou-zcrx.c | 35 +++++++++++++++++-- > 2 files changed, 33 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile > index 78bb0169350b2..37023ba580de7 100644 > --- a/tools/testing/selftests/drivers/net/hw/Makefile > +++ b/tools/testing/selftests/drivers/net/hw/Makefile > @@ -91,5 +91,5 @@ include ../../../net/ynl.mk > include ../../../net/bpf.mk > > ifeq ($(HAS_IOURING_ZCRX),y) > -$(OUTPUT)/iou-zcrx: LDLIBS += -luring > +$(OUTPUT)/iou-zcrx: LDLIBS += -luring -lpthread > endif > diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > index 9b62fd0703e61..f793a6c04e412 100644 > --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -85,6 +86,7 @@ static int cfg_send_size = SEND_SIZE; > static struct sockaddr_in6 cfg_addr; > static unsigned int cfg_rx_buf_len; > static bool cfg_dry_run; > +static int cfg_num_threads = 1; > > static char *payload; > > @@ -379,7 +381,7 @@ static void run_server(void) > error(1, 0, "test failed\n"); > } > > -static void run_client(void) > +static void *client_worker(void *arg) > { > ssize_t to_send = cfg_send_size; > ssize_t sent = 0; > @@ -405,12 +407,36 @@ static void run_client(void) > } > > close(fd); > + return NULL; > +} > + > +static void run_client(void) > +{ > + int total_conns = cfg_num_threads * cfg_num_threads; > + pthread_t *threads; > + int i, ret; > + > + threads = calloc(total_conns, sizeof(*threads)); > + if (!threads) > + error(1, 0, "calloc()"); > + > + for (i = 0; i < total_conns; i++) { > + ret = pthread_create(&threads[i], NULL, client_worker, NULL); > + if (ret) > + error(1, ret, "pthread_create()"); > + } > + > + for (i = 0; i < total_conns; i++) > + pthread_join(threads[i], NULL); > + > + free(threads); > } > > static void usage(const char *filepath) > { > error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h -p " > - "-l -i -q", filepath); > + "-l -i -q -t", > + filepath); > } > > static void parse_opts(int argc, char **argv) > @@ -428,7 +454,7 @@ static void parse_opts(int argc, char **argv) > usage(argv[0]); > cfg_payload_len = max_payload_len; > > - while ((c = getopt(argc, argv, "sch:p:l:i:q:o:z:x:d")) != -1) { > + while ((c = getopt(argc, argv, "sch:p:l:i:q:o:z:x:dt:")) != -1) { > switch (c) { > case 's': > if (cfg_client) > @@ -469,6 +495,9 @@ static void parse_opts(int argc, char **argv) > case 'd': > cfg_dry_run = true; > break; > + case 't': > + cfg_num_threads = strtoul(optarg, NULL, 0); > + break; > } > } > Reviewed-by: David Wei