From: Andrew Lunn <andrew@lunn.ch>
To: Tommy Shih <tommy.shih92@gmail.com>
Cc: netdev@vger.kernel.org,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Daniel Golle <daniel@makrotopia.org>,
"Lucien . Jheng" <lucienzx159@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: air_an8801: add WAKE_PHY Wake-on-LAN support
Date: Tue, 3 Nov 2026 14:29:14 +0100 [thread overview]
Message-ID: <7e1ac14e-b306-4921-84fa-8266b3263f2d@lunn.ch> (raw)
In-Reply-To: <20261102132903.713908-1-tommy.shih92@gmail.com>
On Mon, Nov 02, 2026 at 09:29:03PM +0800, Tommy Shih wrote:
> The AN8801R can wake up the system on a link change, but the driver
> only supports WAKE_MAGIC and always masks the link change event on
> suspend. Supporting WAKE_PHY allows the system to be woken up when
> the cable is plugged in or unplugged.
>
> Add WAKE_PHY support:
> - Keep the link change interrupt enabled, and only disable it on
> suspend when the PHY is set to wake up by magic packet only.
> - Report a wakeup event when a link change interrupt is seen with
> WAKE_PHY enabled.
> - Enable device wakeup when either WAKE_MAGIC or WAKE_PHY is set.
This is an interesting definition of WAKE_PHY.
Are there any other drivers which use change in link to trigger a
wake?
How are you using it? Is your device plugged into a manages switch and
you are making the managed switch down/up the link?
Is the hardware capable of waking just on link up? Is there any point
waking up if the link goes down?
Andrew
prev parent reply other threads:[~2026-11-03 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 13:29 Tommy Shih
2026-11-03 13:29 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1ac14e-b306-4921-84fa-8266b3263f2d@lunn.ch \
--to=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=louisalexis.eyraud@collabora.com \
--cc=lucienzx159@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tommy.shih92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®