From: Andrew Lunn <andrew@lunn.ch>
To: Breno Leitao <leitao@debian.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Wei <dw@davidwei.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net] netdevsim: set the carrier when the device goes up
Date: Mon, 13 Oct 2025 19:25:27 +0200 [thread overview]
Message-ID: <7e1d28c0-7276-448f-8d01-531b7e8bd195@lunn.ch> (raw)
In-Reply-To: <20251013-netdevsim_fix-v1-1-357b265dd9d0@debian.org>
On Mon, Oct 13, 2025 at 10:09:22AM -0700, Breno Leitao wrote:
> Bringing a linked netdevsim device down and then up causes communication
> failure because both interfaces lack carrier. Basically a ifdown/ifup on
> the interface make the link broken.
>
> When a device is brought up, if it has a peer and this peer device is
> UP, set both carriers to on.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> Fixes: 3762ec05a9fbda ("netdevsim: add NAPI support")
It was not obvious what adding NAPI has to do with carrier status. I
had to go look at 3762ec05a9fbda to see that that was when nsim_stop()
started to change the carrier on stop. This patch makes nsim_open()
somewhat symmetrical. If you need a respin, maybe expand the commit
message to explain this.
Otherwise this looks O.K. to me.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-10-13 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 17:09 Breno Leitao
2025-10-13 17:25 ` Andrew Lunn [this message]
2025-10-14 9:18 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1d28c0-7276-448f-8d01-531b7e8bd195@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®