Re: [PATCH] drm/i915/sdvo: Remove disabled HDMI buffer dump code

[Jani Nikula <jani.nikula@linux.intel.com>]

On Sat, 10 Oct 2026, Ashwin Gundarapu <linuxuser509@zohomail.in> wrote:
> From cbebdc3b5dce2d4c0ce8c9b69c62b539fc77dce5 Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Sat, 10 Oct 2026 15:42:48 +0530
> Subject: [PATCH] drm/i915/sdvo: Remove disabled HDMI buffer dump code
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>

Please read submitting-patches.rst.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/display/intel_sdvo.c | 30 +----------------------
>  1 file changed, 1 insertion(+), 29 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index 3075ef04df56..d9c6a620377e 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -974,35 +974,7 @@ static bool intel_sdvo_get_hbuf_size(struct intel_sdvo *intel_sdvo,
>  	return true;
>  }
>  
> -#if 0
> -static void intel_sdvo_dump_hdmi_buf(struct intel_sdvo *intel_sdvo)
> -{
> -	int i, j;
> -	u8 set_buf_index[2];
> -	u8 av_split;
> -	u8 buf_size;
> -	u8 buf[48];
> -	u8 *pos;
> -
> -	intel_sdvo_get_value(encoder, SDVO_CMD_GET_HBUF_AV_SPLIT, &av_split, 1);
> -
> -	for (i = 0; i <= av_split; i++) {
> -		set_buf_index[0] = i; set_buf_index[1] = 0;
> -		intel_sdvo_write_cmd(encoder, SDVO_CMD_SET_HBUF_INDEX,
> -				     set_buf_index, 2);
> -		intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_INFO, NULL, 0);
> -		intel_sdvo_read_response(encoder, &buf_size, 1);
> -
> -		pos = buf;
> -		for (j = 0; j <= buf_size; j += 8) {
> -			intel_sdvo_write_cmd(encoder, SDVO_CMD_GET_HBUF_DATA,
> -					     NULL, 0);
> -			intel_sdvo_read_response(encoder, pos, 8);
> -			pos += 8;
> -		}
> -	}
> -}
> -#endif
> +
>  
>  static bool intel_sdvo_write_infoframe(struct intel_sdvo *intel_sdvo,
>  				       unsigned int if_index, u8 tx_rate,

-- 
Jani Nikula, Intel