From: Jason Andryuk <jason.andryuk@amd.com>
To: "Chen, Jiqian" <Jiqian.Chen@amd.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: Re: [PATCH] xen/pciback: Make missing GSI non-fatal
Date: Thu, 27 Feb 2025 09:57:45 -0500 [thread overview]
Message-ID: <7e2e48b5-27b6-45a5-975a-7616f2c0f2f5@amd.com> (raw)
In-Reply-To: <BL1PR12MB58498AC8C41605DD4E288F4BE7CD2@BL1PR12MB5849.namprd12.prod.outlook.com>
On 2025-02-26 22:36, Chen, Jiqian wrote:
> On 2025/2/27 04:01, Jason Andryuk wrote:
>> @@ -475,14 +478,14 @@ static int pcistub_init_device(struct pcistub_device *psdev)
>> #ifdef CONFIG_XEN_ACPI
>> if (xen_initial_domain() && xen_pvh_domain()) {
>> err = xen_acpi_get_gsi_info(dev, &gsi, &trigger, &polarity);
>> - if (err) {
>> - dev_err(&dev->dev, "Fail to get gsi info!\n");
>> - goto config_release;
>> + if (err && err != -ENOENT) {
>> + dev_err(&dev->dev, "Failed to get gsi info! %d\n", err);
> I think here needs " goto config_release;" since it is not ENOENT error.
Yes, thank you for catching that.
Regards,
Jason
next prev parent reply other threads:[~2025-02-27 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 20:01 Jason Andryuk
2025-02-27 3:36 ` Chen, Jiqian
2025-02-27 14:57 ` Jason Andryuk [this message]
2025-02-27 8:23 ` Jan Beulich
2025-02-27 15:19 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2e48b5-27b6-45a5-975a-7616f2c0f2f5@amd.com \
--to=jason.andryuk@amd.com \
--cc=Jiqian.Chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®