From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB443DD875 for ; Tue, 7 Jul 2026 10:55:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783421742; cv=none; b=OeN5oRU5IjFfgPPwtsNswA1FmB4V16s+K6JhL5leg3fhJDBWoRCsqq+sXQSQAx2rVQ9dhL3iAajxaBE/IKoXIYvkXI0R0fAQvmSDVYbuCjmQWTTaicPaTrJbHrRIC3ItGBr5UoWdDVY3rNuukcQUvCdpskEqn/dh823obVR/iuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783421742; c=relaxed/simple; bh=/DSzcQElKq0mXa69/IQkZJAYGGmhD2CvPP4Qx3Y+EQA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G1Z4K1GVew6jjqzZTJOpuCRpzQ4Vq1K1XsKleL3vv7bTHuKXwIo7bcctzzBqN/McYhkn+eizNXxcrSPquwfNmvNwYwOsffV6FgbhnK7vnWY1Q8hKi7mTenmP6bmMhPZgA9bLLXujAviPTntqOW2VvnHPRBS0Nb85AkXHDTPmNTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UKdt/hnU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vyi7DSsv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UKdt/hnU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vyi7DSsv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6678Dbv23219300 for ; Tue, 7 Jul 2026 10:55:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PPBAMksDVcTI0m93auLHoJ+VLwr7IoZUpwRRiS+q4QQ=; b=UKdt/hnUw4wLiLyV rpR/b9LZuITz9EXW/XgjtIbztvV5+dx9hqmObpB+DeC8aAEBhnFbEF+Eso77odbS TQf7Hmo8xbqd0xpFLVMsA1KfhOCHWcF8vQjb+S5CSLI1VcS0MQB7yChWQ/3B2cte BmB461TsnbM/bkp28ofoKorctAwAn5/X8AxsegGflq4qzs4uJthSwiveLHm1tXOO h7V2pa3VOh8l3j9IffGr9vOVOcaAJuKK0MhHGZOWaXOpaRVcNBhGTWMeN5FIKjJr pAdGwiQhxPEaJlu23ownx43hoha4M3AaAQAu+LOykUuYydPkQOWPsgg0wd+5xB0e LOUQZA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8wep0r5y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 10:55:39 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5174a23afcbso41046581cf.3 for ; Tue, 07 Jul 2026 03:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783421739; x=1784026539; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PPBAMksDVcTI0m93auLHoJ+VLwr7IoZUpwRRiS+q4QQ=; b=Vyi7DSsvpqo2iqSwq2ENcHBCHVYwoLH+AAITqyegwdR9PmfOC8iwMSyTCFcmt6RZn9 uzBo0aoEGVkCXtiC8ICYiWQDdOhKNmsvASYEnqkBp5+VZDiECSS2LIhyCNvrMAh/jVch qlDmB7VJQm94E7aZg1q8NmJdhS6LjDfW4mtO30n8nxWHcRRk/SLyuvTNot9ZPtN/i181 PK1TsP0tISiB3JQ5ghHvoQF3NWtlMBLAkkQkbUQYhtXNaPvHXCi7XjNqggg5hGR048as yOgIQJIQiK3u8I8rIz/H/FZbvFSqYma2291QGaEqAji/arnR+UTx12d61exowoDjLcSe 7G4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783421739; x=1784026539; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PPBAMksDVcTI0m93auLHoJ+VLwr7IoZUpwRRiS+q4QQ=; b=XEHvBypjt0L6VlUebob6AOxp4EJz2UJ7T/YTkjAuiO/FMPEU6/0wagG/pwzGQ5HVFm WK1vpvYoGKKeWzPiT1Vs8Rf40WEAXMgI9hFWCx9kjm6ODRzeTrLYAlTD4gTWB3Mt4mQz x9ODAi/b4PXxKszfmQgAfAHGjLBgFfi5f575k5Eam5Y4H3egkdlEAVD05VusBeqkesDs 4NXd/HmwQZr+aUlF2gvB0LzOj5P4AnjciRU7FK4NVnq80cjPw1vPA1pn9mJYUaHElyjg wpK5AsCVReSHXFvbVGmjvcAALcteJOObxgpHXAuz3g/hXlBQGcd9pKa20UPW5osHqLiU sAhw== X-Forwarded-Encrypted: i=1; AHgh+RpMaA6vrHb6d9q/HiVegRCGaInL1D8JzqIcxmbIL0Pe3wviDmUp3/gFaAHJOuwqUBdcA7EqGbE+IYWw1GU=@vger.kernel.org X-Gm-Message-State: AOJu0YwU2BtfWpKMQDQSiiUhQISWttf3Zqvfl1Qj8V7g3wwJylcfnG5r aOSsorBETWC9ahphZaAs8XdQi23SohnDO5ohP4CVTTCG1aZBas3aqOgAXUQ4iCXGkSWfQXGU4HV gc1P/mJLeHV7YC78apVayhcU2PEN39TTDoZgoSIkSHEZvwrIyV++wtsoLjKTVsnGIIB0= X-Gm-Gg: AfdE7cn4dzrqQUnOQZx/pS2PWC7qlB5ctL1dj35ToMsY7egxR9fAOC6qiCNBVceTTE5 NGt+bc5onjzs3YMXJro7dS8fjer8YexDDNYCZVCqXeEx0JA1YB4E+Xj00YTJZpPrV/AYXKCmmt9 OQfgB6uL0e7ELjOx6wDsQFw5wMRTioEpbjKUXslxS9m3wSzdpvfG6l+3LGIna2dMLb4XykJ/VHG pxvG/G3uwcNZBpHNTE7a26XLz2xNWzkLhOP1/OhK1fvVj55muuyQo34eUcZ5RnGtApTgRC+YqWi a/V3y5RffGTKDr0Dug8I8DdauDTWVU/ST0MWWaju31LWhLbSR/RPxOBXMskVQxKT2Df3CdXeGHV K0VFkmigllqns3pVjb0HL6bqub7AP19IL0ZtZp6OalQT+tt2PQCF6iMuQlZ+qgbrWZ317uOdkAm t/JYDPbYY= X-Received: by 2002:ac8:5d8e:0:b0:519:8998:661b with SMTP id d75a77b69052e-51c747bb756mr47970251cf.20.1783421738674; Tue, 07 Jul 2026 03:55:38 -0700 (PDT) X-Received: by 2002:ac8:5d8e:0:b0:519:8998:661b with SMTP id d75a77b69052e-51c747bb756mr47969931cf.20.1783421738054; Tue, 07 Jul 2026 03:55:38 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15bc428775sm3346466b.6.2026.07.07.03.55.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 03:55:37 -0700 (PDT) Message-ID: <7e36238b-96ac-4269-a6e5-0a6763e437e7@oss.qualcomm.com> Date: Tue, 7 Jul 2026 13:55:34 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] Add Qualcomm JPEG V4L2 encoder for SM8250 To: Vladimir Zapolskiy , Bryan O'Donoghue , Atanas Filipov , linux-media@vger.kernel.org Cc: loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <68e59764-5a10-4abc-849c-14ea2d9ef76e@linaro.org> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3NJWgDtbbDylyUfPxsI0HQ8iXp1FR_WT X-Proofpoint-ORIG-GUID: 3NJWgDtbbDylyUfPxsI0HQ8iXp1FR_WT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEwNSBTYWx0ZWRfX7K/+87op/4Wz lbqdsHKVB1d5twxAEMihiCyqEB7lb3FrQpj+wgHY3hGJANf6Y7gNccrYbpMVgsTTA32WGp8zGg/ kvNhmuvYCysTxhkoB4fSB7G0W48rqjO9C67lAS9qYDRjCic8ins5l/WFokaXjNnU6IUf95N9BS1 Dp82bOgKD0kp3CR9qjVXNMKEv+oFQPh8eoyDxOYfnrn/jBKjZb6jr+NLZgOy5cpZHEZMI6omAcq 0Qc/kSjwZysOwGptQfPUXwhVjzBneLcx90IMuBS7AB7sr1HDM/7LdKCwbO/HerAAUEdozo4dwvh gz80iCJ/eY4gEQGRgwQrLdYCqLZUXpdNIje64uERc5oBd5nU/ta+t9xUnHyaA54SlKH7muvxqZd 7ZrE5YLSLRbr4PdFy4xK7Wi932AarIH+Vy43uG/gE0mVrr+h40batcIUyl4MDuqJIzNQQUMU/u9 iGUNTQz4RQbPrvGDAeA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEwNSBTYWx0ZWRfXyKq4JtbM2uGG Ailq9vJZnpQLl8piJvOwDzCKDjCpr9XxOgEVg7tPIxzhqQ1YsSMPmJBwNDkXwXDsP6ZDdup83Ny Kz+QnphjIKO6JbxuvEGrbm9CWbW6UWM= X-Authority-Analysis: v=2.4 cv=atSCzyZV c=1 sm=1 tr=0 ts=6a4cdb2b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=g6G2TVJU6GBlO6KxhuQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1011 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070105 Hi Vladimir, Bryan, On 7/6/2026 3:00 PM, Vladimir Zapolskiy wrote: > On 7/6/26 13:12, Bryan O'Donoghue wrote: >> On 06/07/2026 08:11, Atanas Filipov wrote: >>> Note: The handling of shared camera subsystem resources (power domains, >>> interconnects) for child IP blocks is still an open design question. >> >> Why ? >> >> A device needs to vote on its own interconnect and power-domains on any >> bus. A sub-device of another device may wish to ramp a clock for >> whatever reason. > > Certainly a CAMSS device will vote on all needed to it resources, some of > which are shared and got their description under CAMSS device tree node. > >> There is no "master" device in this block of devices - save perhaps for >> the CSID mux / wrappers on some of these parts. >> >> We have shared resources like camera noc, system noc and external >> clocks. >> >> Please include power-domains and interconnects. >> > > Why? The common power domain and interconnects have already been > described as resources of the parent CAMSS device, there is no need > to duplicate descriptions in every child device tree node of CAMSS. > The initial patch and work for JPEG was as independent driver.  I agree from hw perspective it is part of CAMSS subsystem and maybe from design perspective proper way is to be child node not of the CAMSS. However the resources shared by both can be abstracted in other frameworks, example ICC voting allows to have shared clocks which can have policy to keep the higher rate and satisfy both of the HW's. So maybe it need to be decided: Do we want really additional logic for handling CAMSS resource of the CAMMS sub-devices by the CAMSS driver and create separate CAMSS API,s or we can use existing fw's for that. ICC, clock, OPP which all allow sharing of the resources. Also there are cases where CAMSS and is not needed but JPEG encoder is: Example RTSP streaming or UVC streaming which require jpeg encoder. Anyways my opinion: 1. CAMSS is not prepared and not ready to handle child devices, only the populate child nodes is not enough. I think it is little bit mess, some of the HW;s CSID, IFE etc are instantiated directly from CAMSS and jpeg and Ope are described as child nodes. 2. Jpeg on its own currently does not have any dependency with CAMSS driver code. It can use shared resources without issue and leave the ICC, clock and other frameworks to do the job. Also i dont see the reason to mix the both works. Lets have it jpeg as separate independend driver and the create series and rework CAMSS to child nodes and move all existing sub-devices as child nodes, and then move the jpeg and Ope. Regards, ~Gjorgji