From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5CDB3542D2 for ; Tue, 17 Feb 2026 12:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771332136; cv=none; b=bNxZdt25KpVLl5hs36ZVJ519EK2b8t1+sOhs7U9s3kEBCuu66TIp2IF9ikUJiWZGoAIwdtZLvUNymkXAqPJOTzbjsZ5YkhqwqNiWM+Q9NG0vhdHF7/13+5Wj0IV3Ye8FzMI0n/q/MAf6sZBDKN2dtA0Ay72gbjpc5ImtliRTqyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771332136; c=relaxed/simple; bh=Uzt7RvHwwqFSV3phhIIGejkiKsOxEO0Vb+GmvZWLI+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EbRjfFyj3UVIfgHnj9GuRqUo9ogKnoyTTRBTtB/HELRv4d19QwW36C5+z0s+TAWFztvcZuvYN1nDy/NLzgtnOdZWaxNo56mWir5GKfWKaj+5zuqlBQxg6LhT9y6N1nGMMGeRtU0nkSQ8O2F0inQISK5y1PS4P8Jw2ga//0Ej4Cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DoKPKbsG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UUX44s7B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DoKPKbsG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UUX44s7B" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61HAmvAc597734 for ; Tue, 17 Feb 2026 12:42:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o6e4jsLCb9oNoLVirKnKjbtTHj3HOKLPKd3Pmm55v7Q=; b=DoKPKbsGJ4I0F6RT FF+O0s9IFeEQwFJlKdIz+VDLe7bQaUrSiLGCzf5C3MAfpw329GTdc3nRXpglqtj5 Kj2BGFD8HBX3FpJvgWVkZlVwdIGm5O1i6Eda7tdDOiUXmFCFk/NzLm99bJkdor10 hnUh8aujkznWS16KDKLat+rNmmCUVCjpKP+F+G1OQnUpbUHt7czKGYmQ5fNW7Sc1 2SPjTurQQiZGKfyDRmiDlSBmdPKh9WKs5+c90bUDVInYsTV0ZgX4U9OTYdX4O/5G tyvryUJJcmFJkURu3duM1hJ+yIwUds2H1vlODtU5h6v/PJs7Ms0roq0khFFVehTA fY/Ibg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cca361ua1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 12:42:14 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb45a6b860so228390885a.0 for ; Tue, 17 Feb 2026 04:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771332134; x=1771936934; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o6e4jsLCb9oNoLVirKnKjbtTHj3HOKLPKd3Pmm55v7Q=; b=UUX44s7BSLVb91pR/gukmEFCq1aBGk4BsOnZIr2Gpb4elt0ObRI/Zevys31WXVzToO jJe7ZSWp43kbzFtYNDzRlO+0QtIpjomhgkEN9xb0z/VGQOZo6ZOkorgQMNIwc7wHNjjW ll+gxbRiY8mPXNRaGyXFN9WnwLNTKvaY2WQ2JGUg+xzU4gGoQyTrY4RNEDocxp1gh3Xa MfSvVcW+K/21cuj2heIdiHbOQezOeKhwgOIiYLwzuoDR0W5nAUw+RSIujon0lDdIYC25 jNk7IrZSqP1aayKvufwTTs8FAFaN+gr2dlUQalv5ge0xJfaE3iBAbrQJKkAMoyrOV2Cu epKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771332134; x=1771936934; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o6e4jsLCb9oNoLVirKnKjbtTHj3HOKLPKd3Pmm55v7Q=; b=sxFYrJMPtLU26RiK/c8tAVLChDtPdDMVCTfkCJeOFx0HzSX7OvaRAV9PBKY1SVC8D6 YYAPBuZZgYqeZrLsoXgzH2ykovw3thF53oiEBe9YPYraI43o4DS60ElVZYjBhqkX0Q+l j4okksY2gODldAKuRFPENqBQQDHbl4KaVB9WwIpsDMqCFlUeyTZd8HqCpTxRm9Q6G9um vhbMk81IVvBkzL3zxvyywaV9FfUFczLKDWRq3CGdXaFGWdIDQ+/n2Z+gChQS9wMNilQk CscUgGZlhk01NrVPtSQ0kkOtohMtiFjhfzcHK9BIKwOkefZySvz70JDnks84HBBHPuOV NKLw== X-Forwarded-Encrypted: i=1; AJvYcCUzQrUeIZzXpxBQ9S7QL3WltqRbc5qCSZFnMGxaj98VQ+VALGE6Y4v6jbLrGvn9Pa2JvquB6PylsEEmuiU=@vger.kernel.org X-Gm-Message-State: AOJu0YyGp+mRGFopk5eYuizzTunJ7jaGp4SmSdI0ghO1HjpdPimL3D7Z vvFqhhGZhYa4vMUITAaRwKYzm6oYm8HtgPp9RUHWZn8toHqpf31CaKHk7hrcXuzVWlqe+2kOf5e uzzNTKkTq5R/Ss89DZb0dpTmwyEbYo/XK2QammszA5NXUCtFR8RxjgJT9v7DPcd9KtBg= X-Gm-Gg: AZuq6aKGoX4Bs7T+I0wYaP5UoMjN/FqmwJWlJSiU0Ai/vHgjibWHXB6JsIuZIAJIDpd NdNbIzQbbytIVTZKVyl5jMHv9sfqwBFwhdbPDkEzmDYXoM1J6DPKjacXaJ6OYJtKtzeCKf3f4c+ n9bRsv3mYvZ0h/Qsdk2qotH/ijHrwAIIvLLJCBXB+UefJmlqp4p5ZTZpxqDTk8Niq7BCVba1Rf8 bP+vwCDuLd3cSHt5/UKFi3P6CQDTIpreuO/KNJbzIa2PFyMKpQrcEd7CcEmT40oen1USCpRUupp 7GjWEbSIA41kxx4h6YHTycgHlNw0yX7budzLoJ/O9KQhssdOenEihKzNhIPK3tqNmH45BmMFuv3 xqRtgqgeA6k/0Y19jYQeuD1rGcpKi0gdQVHxnQYhM/D3El34jDJmESQDzT9ch1hOnPZpRbp3Wsu HKQYk= X-Received: by 2002:a05:620a:2948:b0:8c7:17af:7ae with SMTP id af79cd13be357-8cb408b846bmr1269567485a.7.1771332133962; Tue, 17 Feb 2026 04:42:13 -0800 (PST) X-Received: by 2002:a05:620a:2948:b0:8c7:17af:7ae with SMTP id af79cd13be357-8cb408b846bmr1269564085a.7.1771332133311; Tue, 17 Feb 2026 04:42:13 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc76278b8sm350008466b.33.2026.02.17.04.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 04:42:12 -0800 (PST) Message-ID: <7e3dfa3a-f526-42c6-94d8-d6390dee0acf@oss.qualcomm.com> Date: Tue, 17 Feb 2026 13:42:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: milos-fairphone-fp6: Add camera EEPROMs on CCI busses To: Luca Weiss , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Robert Foss , Andi Shyti , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260116-milos-cci-v1-0-28e01128da9c@fairphone.com> <20260116-milos-cci-v1-4-28e01128da9c@fairphone.com> <44f65bb6-616c-4dd9-a7a1-ee62d5d217cb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDEwNSBTYWx0ZWRfX9cOscKeHYF1r yfkjHmr6CKEl8/RGRrXSlDwfVVTXdLHGc2Tc1PP/ISduVt5BD5gQBKboNMdoGGXnltt5wFZ3wO9 DcbLnP4UqMyBxSsKIMRjYx1OKAEk8dHKMAsqilFgNwzW8vGiB2g2I29ST+msleJkVijVpGMl9eV AQ51yX9pY/McO8deqhlAexfAbsC1g67EKyK/ZNd/tjE5JdPFdnYnVGDWAHqzppR3NCCT/6slHbm 8vWgEuwxjBg7pM40dRW9CsM14nzkq1JzZTzJDFgM08ycVoqQ84IJSfqcMAxIw1y5kORyknOPyVt +qJw9phBFU8ac7g+tNfsE7Lc49DXaS/dabkyv18lamAFp1CjlB/nlOSa3/c+cQmj4dsEow5N8Hu rWyv136KD66UI88RpmeprrJmwRce7eioPKSvjyBifXkzadArOKH1jX3MSQy/WfGtimkggSMl8yJ y4OeWwhhEML8cprI4Pg== X-Authority-Analysis: v=2.4 cv=b+G/I9Gx c=1 sm=1 tr=0 ts=69946226 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=n6VhdLltzCPXJ-gkZbsA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: yQTgnZ8lpBZCBS_myNumrNkhJXULOE8g X-Proofpoint-ORIG-GUID: yQTgnZ8lpBZCBS_myNumrNkhJXULOE8g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170105 On 2/13/26 2:39 PM, Luca Weiss wrote: > On Mon Jan 19, 2026 at 11:42 AM CET, Konrad Dybcio wrote: >> On 1/16/26 3:54 PM, Luca Weiss wrote: >>> On Fri Jan 16, 2026 at 2:59 PM CET, Konrad Dybcio wrote: >>>> On 1/16/26 2:38 PM, Luca Weiss wrote: >>>>> Enable the CCI I2C busses and add nodes for the EEPROMs found on the >>>>> camera that are connected there. >>>>> >>>>> Signed-off-by: Luca Weiss >>>>> --- >>>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 50 ++++++++++++++++++++++++ >>>>> 1 file changed, 50 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> index 7629ceddde2a..c4a706e945ba 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>> @@ -529,6 +529,56 @@ vreg_l11f: ldo11 { >>>>> }; >>>>> }; >>>>> >>>>> +&cci0 { >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&cci0_i2c0 { >>>>> + /* Main cam: Sony IMX896 @ 0x1a */ >>>>> + >>>>> + eeprom@50 { >>>>> + compatible = "puya,p24c128f", "atmel,24c128"; >>>>> + reg = <0x50>; >>>>> + vcc-supply = <&vreg_l6p>; >>>>> + read-only; >>>>> + }; >>>>> + >>>>> + /* Dongwoon DW9784 VCM/OIS @ 0x72 */ >>>>> +}; >>>>> + >>>>> + >>>>> +&cci0_i2c1 { >>>>> + /* Awinic AW86017 VCM @ 0x0c */ >>>>> + /* UW cam: OmniVision OV13B10 @ 0x36 */ >>>> >>>> There's a driver for this one! >>> >>> Yep! Already got patches to add the required regulators & devicetree >>> support to the driver, but since I've got zero on CAMSS so far, I >>> couldn't test it more than reading chip ID. >> >> That means the digital part works.. I'd say it's a good enough >> indicator >> >>>>> + >>>>> + eeprom@52 { >>>>> + compatible = "puya,p24c128f", "atmel,24c128"; >>>>> + reg = <0x52>; >>>>> + vcc-supply = <&vreg_l6p>; >>>>> + read-only; >>>>> + }; >>>>> +}; >>>>> + >>>>> +&cci1 { >>>>> + /* cci1_i2c0 is not used for CCI */ >>>>> + pinctrl-0 = <&cci1_1_default>; >>>>> + pinctrl-1 = <&cci1_1_sleep>; >>>> >>>> Let's keep them per-bus-subnode so we don't have to override it >>> >>> I don't see any upstream example of that, would the pinctrl work >>> correctly with that? >> >> Hmm.. I assumed it would.. and I assumed we do have examples but >> ma-a-aybe they got stuck somewhere in the review purgatory? >> >> If you'd be inclined to test that, you can add a pr_err() to e.g. >> msm_pinmux_set_mux() and observe whether that changes as you >> interact with the sensor over i2c > > Yeah that doesn't work. With the following diff I just get some CCI > timeouts and at24 driver doesn't probe correctly. I'd prefer not to do > some yak shaving to get this patch upstream. I think the setting happens somewhere near drivers/base/dd.c : really_probe() : pinctrl_bind_pins() which implies there would be a driver in play, which there isn't for the CCI subnodes.. But let's kick that can down the road Reviewed-by: Konrad Dybcio Konrad