From: "David E. Box" <david.e.box@linux.intel.com>
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
irenic.rajneesh@gmail.com
Cc: "David E. Box" <david.e.box@linux.intel.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
srinivas.pandruvada@linux.intel.com, xi.pardee@linux.intel.com
Subject: [PATCH v7 14/15] platform/x86/intel/pmc/ssram: Make PMT registration optional
Date: Wed, 10 Jun 2026 21:34:42 -0700 [thread overview]
Message-ID: <7e3dfe5c626db0bbba2885bbec6f1b223094d0e1.1781146840.git.david.e.box@linux.intel.com> (raw)
In-Reply-To: <cover.1781146840.git.david.e.box@linux.intel.com>
The SSRAM telemetry driver extracts essential PMC device ID and power
management base address information that intel_pmc_core depends on for core
functionality. If PMT registration failure prevents this critical data from
being available, intel_pmc_core operation would break entirely. Therefore,
PMT registration failures must not block access to this data.
Change the behavior to log a warning when PMT registration fails but
continue with successful driver initialization, ensuring the primary
telemetry data remains accessible to dependent drivers.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
V7 - No changes
V6 - No changes
V5 - No changes
V4 - No changes
V3 changes:
- Dropped the standalone cleanup-pattern patch from this refreshed
series retaining the simpler ssram pointer flow requested in review.
- Folded PMT-registration-optional handling onto that simpler flow
with no intended functional change.
V2 changes:
- Update commit message for clarity
- Also apply the PCI telemetry path
drivers/platform/x86/intel/pmc/ssram_telemetry.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
index 35c6f0261567..2095df6a42b2 100644
--- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c
+++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
@@ -194,7 +194,7 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev,
/* Find and register and PMC telemetry entries */
ret = pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
if (ret)
- return ret;
+ dev_warn(&pcidev->dev, "could not register PMT\n");
probe_cache->valid_mask |= BIT(pmc_idx);
@@ -287,7 +287,7 @@ static int pmc_ssram_telemetry_acpi_init(struct pci_dev *pcidev,
ret = intel_vsec_register(&pcidev->dev, &info);
if (ret)
- return ret;
+ dev_warn(&pcidev->dev, "could not register PMT\n");
return pmc_ssram_telemetry_get_pmc_acpi(pcidev, probe_cache, index);
}
--
2.43.0
next prev parent reply other threads:[~2026-06-11 4:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 4:34 [PATCH v7 00/15] Add ACPI-based PMT discovery support for Intel PMC David E. Box
2026-06-11 4:34 ` [PATCH v7 01/15] platform/x86/intel/pmt: Add pre/post decode hooks around header parsing David E. Box
2026-06-11 4:34 ` [PATCH v7 02/15] platform/x86/intel/pmt/crashlog: Split init into pre-decode David E. Box
2026-06-11 4:34 ` [PATCH v7 03/15] platform/x86/intel/pmt/telemetry: Move overlap check to post-decode hook David E. Box
2026-06-11 4:34 ` [PATCH v7 04/15] platform/x86/intel/pmt: Pass discovery index instead of resource David E. Box
2026-06-11 4:34 ` [PATCH v7 05/15] platform/x86/intel/pmt: Cache the telemetry discovery header David E. Box
2026-06-11 4:34 ` [PATCH v7 06/15] platform/x86/intel/pmt: Unify header fetch and add ACPI source David E. Box
2026-06-11 4:34 ` [PATCH v7 07/15] platform/x86/intel/pmc: Add PMC SSRAM Kconfig description David E. Box
2026-06-11 4:34 ` [PATCH v7 08/15] platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S David E. Box
2026-06-11 4:34 ` [PATCH v7 09/15] platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency David E. Box
2026-06-11 4:34 ` [PATCH v7 10/15] platform/x86/intel/pmc/ssram: Add PCI platform data David E. Box
2026-06-11 4:34 ` [PATCH v7 11/15] platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into helper David E. Box
2026-06-11 4:34 ` [PATCH v7 12/15] platform/x86/intel/pmc/ssram: Switch to static array with per-index probe state David E. Box
2026-06-11 17:24 ` Ilpo Järvinen
2026-06-12 21:01 ` David Box
2026-06-11 4:34 ` [PATCH v7 13/15] platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding David E. Box
2026-06-11 4:34 ` David E. Box [this message]
2026-06-11 4:34 ` [PATCH v7 15/15] platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e3dfe5c626db0bbba2885bbec6f1b223094d0e1.1781146840.git.david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xi.pardee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®