mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 16/16] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting
Date: Thu, 19 Nov 2026 08:40:15 -0500	[thread overview]
Message-ID: <7e3f00be-2849-42af-913b-8111be744ec6@efficios.com> (raw)
In-Reply-To: <sashiko-outbox-222083@kernel.org>

> Does calling set_deadline() on rb_waiter_tid while W is already blocked on
> pi_lock give W an absolute deadline of 0 instead of a deadline later than O
> and D?

Yes. I checked it in a guest. On this series, a task made
SCHED_DEADLINE while it waits on a PI mutex keeps a deadline of 0. So W
boosts O at once, and the case passes without the deboost it was
written for. On v7, the case failed without "sched/deadline: Check the
runtime of a task whose parameters change". v7 also had "sched/deadline:
Start a period for a task that enters the class blocked", which gives W
a new period. Both are in the second series. I will move the case
there.

> This isn't a bug, but fair_tid is only written here and never read (which
> triggers -Wunused-but-set-variable under Clang).

Same as v1 [1]: these are left from the split, and the second series
uses them.

> Does pi_chain_donor_leaves() pass on this series without an rt_mutex chain
> walk change to propagate M->dl.pi_se to O when M's sort keys do not move?

Same as v1: it passes in every run, in 25 guests with this series.

> Since death_pi_waiter, death_pi_owner, and death_pi_deadline_owner each run
> in a separate child process forked by run_in(), doesn't the process-private
> static ready variable start at 0 in every child?

Right. My v2 fix does not work. I will keep the flag in the shared
mapping, next to the lock.

> On a CONFIG_RT_GROUP_SCHED=y system where the cpu controller is already
> enabled in root/cgroup.subtree_control, won't server_client(1) fail
> sched_setscheduler(0, SCHED_FIFO, &sp) in cg_p with EPERM and cause
> server_states() to time out and fail instead of skipping?

Right. Our guests with CONFIG_RT_GROUP_SCHED did not have the cpu
controller on. I will make the case skip there.

[1] https://lore.kernel.org/all/eb414b6f-ea8f-4dd5-94ca-0915490ff37b@efficios.com/

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

  reply	other threads:[~2026-11-19 13:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:24 [PATCH v2 00/16] sched/deadline: first bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-18 21:24 ` [PATCH v2 01/16] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-18 21:24 ` [PATCH v2 02/16] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-18 21:24 ` [PATCH v2 03/16] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 04/16] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 05/16] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 06/16] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 07/16] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 08/16] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 09/16] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-18 21:44   ` sashiko-bot
2026-11-19 13:39     ` Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 10/16] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-18 21:51   ` sashiko-bot
2026-11-19 13:39     ` Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 11/16] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 12/16] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 13/16] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 14/16] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 15/16] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-18 21:25 ` [PATCH v2 16/16] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
2026-11-18 22:07   ` sashiko-bot
2026-11-19 13:40     ` Mathieu Desnoyers [this message]
2026-11-19 10:20 ` [PATCH v2 00/16] sched/deadline: first bandwidth accounting fixes and selftests Juri Lelli
2026-11-19 13:41   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e3f00be-2849-42af-913b-8111be744ec6@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®