From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56DE337A825 for ; Tue, 21 Jul 2026 08:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621487; cv=none; b=MyPAr11Bvtl6zXs6szqp9dSdop2eB6OwqnfWJOYdAnhPBZsPfD6IncC3skqnI5PCGxL5pCRhNMwOZYB8RVhy/WSEZrETPIUkwBsFeLH7r5X4iwPMskEY7yIZoESbLDb9pkviuo5voeqs6X832DY0jzDSzU5J7Cxn3olmk+vdnU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621487; c=relaxed/simple; bh=U8xSu3XzAInqAwEQoh3UmlLoBFWJ4VbrK55hMH8bD34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o21u9DWUj/vQ7QWnbelMSVt2EfXNSVZZojU5HPxowFIBOD0BBRCM5/p4NHVgojzx/a2JVFk0z981XAz1gkepOp5mQms1HYpXVbadjDRCBDVAdYeuVk8h5BQF7tM4SUnr9x5axLypjnmq9ATz2H8m7zgGLYlucnhwHt+jNkMyQOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QjqmBuJ/; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QjqmBuJ/" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5aeb36c46bbso1271857e87.3 for ; Tue, 21 Jul 2026 01:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784621483; x=1785226283; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=SHcvhuYIyIQQusxUa8EX0EJ4eua+x7ToG1cGzxehLE8=; b=QjqmBuJ/oApKLYJeeCFAwWATE+Eg9WBI5VIkpQo7aZK94nDkYHCzwX3ZauVZvn2KGL zwiYwYYgcEtmpSwfB3D4JE03s37aB8szbrHUz1Q4F4aS61RKKKBQzMlCbszS9XgHdFPp +SRJ6M99/EZIYikM0HqZ0DyKisnE61P/zYSRcIANhDGodyrWvR4kKXd+/EKxbeyuztgZ Cs0G3J58FgFqCm3OeHTYIoQhn27cWsHDnMlcqTWjcVNTSCsa8NUNzUmStCQia7c10DXN rdq+MVVgU0efRSoD7dMXtIoa+BQJizHqTkTY3bREUChNbPWY52DP7dKueYPww2RwqU49 F27g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784621483; x=1785226283; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SHcvhuYIyIQQusxUa8EX0EJ4eua+x7ToG1cGzxehLE8=; b=bxUcL+zNkU2tt5T2oHSggZYUykNT4sM2bzk/3MjioBWoKrKZyCJqWjxFF7TaM1/Wtv HsBvGZs/BhCMcGT66za/cyw2MCdss72ZKxma2ae5s+u9HvTJVUZi1p0Efel7J9uCztL2 r33+vJiOO+UfoWlx/Tf3xdChpwwrBA5YuV/UxotDhOmNkyqwvvICqXqtYY9dcj8qrJM0 MEHueHm4s6Xg3vvcvX0xc1QADm9gXDslLXje62YMiYcO2CmGWUZ3rwV6th9FlAoqHZmy BG3FX0/ePgg7YcZ+nEVbGq5DPpphY2B2uu+qsNZnELNVpuZY+hgNrIlJ81kMM8c8qHyd l4ww== X-Forwarded-Encrypted: i=1; AHgh+Rp8A4OTjuiOMnC/8iXtFSWp8n+g9HO/I78Ag7vpNEG6f4FGk901gn0LA7Qj3DmTXc126v8o9HHhOMrXk8s=@vger.kernel.org X-Gm-Message-State: AOJu0YwhouC3Hx6azOuEkdg6LSZnjvD3JPhjdoMm96oEYUJ+VwHGJXfr mYVoS1kgwr8yADmzS1ya8PL70rBfeTwP+hYR+oPQ/KTys1yW2GjfKDo5SvbbqhVvmFo= X-Gm-Gg: AR+sD10l/pjEdtAN7FhGfeDOumqRqL4ejyzSFf2kHwE9J02z1APAj6vhX86oPn+V1E9 vFDw/6oyKr92bm7R50Xw6IFqP3HKs0qMEF5SA8KhCHoTBau4LIvHiF0DlvVGrlIL5qE3K0E0axY i2BUDDKEyxEcCaEibKgRphqxWyXoZew8k57bOum/PkQ6BJsB36ZXZaoyGCelToZxS7uX0Enpour b3cHTkfFK2lbh/NBq+JLzkIqbPsTZGRIwtG5HraOxsvhdAfVo4br0izJtPpdzFJObLSjNMeu6Ae 8do9ecTJm2qo0pgceD7WZyfxiiZKhWnsCiWiGBBw/zX9caAK5g9TYb1Kaev/MQJdEJ4dFU1Vd2Q T0jZup+putVlBTZWW754ZnNfuz11lW9ehYlzUbgXJe3qj3EwOvAmwErEKBBJCaJIcoDik2nD/9l C6rkMni+Lrl1G0ncbpbdBonyGJrb+NBndXX51Zi0XuSm/+RmGidtPDhet415B7QHBRI28= X-Received: by 2002:a05:6512:ac4:b0:5b1:5ab9:65d3 with SMTP id 2adb3069b0e04-5b2a4a9a2c9mr406154e87.7.1784621483299; Tue, 21 Jul 2026 01:11:23 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291d9a8easm2769969e87.27.2026.07.21.01.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 01:11:22 -0700 (PDT) Message-ID: <7e443a2e-4425-41f6-bdfb-0a91ef96bc55@linaro.org> Date: Tue, 21 Jul 2026 11:11:22 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260719-x1e-csi2-phy-v12-0-cc7311326d1b@linaro.org> <20260719-x1e-csi2-phy-v12-1-cc7311326d1b@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20260719-x1e-csi2-phy-v12-1-cc7311326d1b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/19/26 16:47, Bryan O'Donoghue wrote: > Add a base schema for the MIPI CSI2 PHYs on Qualcomm SoCs. This PHY > supports both DPHY and CPHY operation. A special mode of DPHY operation - > called variously split-mode or combo-mode also allows for two sensors to be > connected to one PHY. > > The submitted binding here describes the DPHY modes of operation only. CPHY > is left to future work. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Bryan O'Donoghue > --- > .../bindings/phy/qcom,x1e80100-csi2-phy.yaml | 195 +++++++++++++++++++++ > 1 file changed, 195 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > new file mode 100644 > index 0000000000000..880fe602945cb > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml > @@ -0,0 +1,195 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/qcom,x1e80100-csi2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm X1E80100 SoC CSI2 PHY > + > +maintainers: > + - Bryan O'Donoghue > + > +description: > + Qualcomm MIPI CSI2 C-PHY/D-PHY combination PHY. Connects MIPI CSI2 sensors > + to Qualcomm's Camera CSI Decoder. The PHY supports both C-PHY and D-PHY > + modes. > + > +properties: > + compatible: > + const: qcom,x1e80100-csi2-phy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + description: > + The single cell specifies the PHY operating mode. > + This has been reported before, #phy-cells shall be 0, the operation mode is selected by bus-type of endpoints as it is described in video-interfaces.yaml Two competing values are redundant, the technical discussion has not been started yet. > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: core > + - const: timer > + - const: ahb > + > + interrupts: > + maxItems: 1 > + > + operating-points-v2: true > + > + opp-table: > + type: object > + > + power-domains: > + items: > + - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller. > + - description: MMCX voltage rail > + - description: MXC or MXA voltage rail Please double check that there is such voltage rail as MXA. > + > + power-domain-names: > + items: > + - const: top > + - const: mmcx > + - const: mx > + > + vdda-0p9-supply: > + description: Phandle to a 0.9V regulator supply to a PHY. > + > + vdda-1p2-supply: > + description: Phandle to 1.2V regulator supply to a PHY. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + description: > + Sensor input. Always present. A single sensor is described by a > + single endpoint with one to four data lanes. DPHY split mode, > + where two independent sensors share the same PHY, is described > + by two endpoints; endpoint@0 with exactly two data-lanes and > + endpoint@1 with exactly one data-lane. > + unevaluatedProperties: false > + > + patternProperties: > + "^endpoint(@[0-9a-f]+)?$": endpoint regexp is not corrected, this issue has been reported previously. > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - data-lanes > + - remote-endpoint > + > + allOf: > + - if: > + required: > + - endpoint@1 > + then: > + properties: > + endpoint@0: > + properties: > + data-lanes: > + minItems: 2 > + maxItems: 2 > + endpoint@1: > + properties: > + data-lanes: > + maxItems: 1 > + required: > + - endpoint@0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Output to the CAMSS CSID controller. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - clock-names > + - interrupts > + - operating-points-v2 > + - power-domains > + - power-domain-names > + - vdda-0p9-supply > + - vdda-1p2-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + phy@ace4000 { > + compatible = "qcom,x1e80100-csi2-phy"; > + reg = <0x0ace4000 0x2000>; > + #phy-cells = <1>; > + > + clocks = <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>; > + clock-names = "core", > + "timer", > + "ahb"; > + > + interrupts = ; > + > + operating-points-v2 = <&csiphy_opp_table>; > + > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>, > + <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MX>; > + power-domain-names = "top", > + "mmcx", > + "mx"; > + > + vdda-0p9-supply = <&vreg_l2c_0p9>; > + vdda-1p2-supply = <&vreg_l1c_1p2>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + csiphy0_in: endpoint { > + data-lanes = <0 1 2 3>; data-lanes values has not been corrected in accordance to linux-media requirements. > + remote-endpoint = <&sensor_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + csiphy0_out: endpoint { > + remote-endpoint = <&csid_in>; > + }; > + }; > + }; > + > + csiphy_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&rpmhpd_opp_low_svs_d1>, > + <&rpmhpd_opp_low_svs_d1>; > + }; > + }; > + }; > -- Best wishes, Vladimir