From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753606AbdHXQlz (ORCPT ); Thu, 24 Aug 2017 12:41:55 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4569 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbdHXQlx (ORCPT ); Thu, 24 Aug 2017 12:41:53 -0400 Subject: Re: [PATCH net-next] net-next/hinic: Fix MTU limitation To: Andrew Lunn CC: , , , References: <1503580885-35180-1-git-send-email-aviad.krawczyk@huawei.com> <20170824151958.GL8022@lunn.ch> From: Aviad Krawczyk Message-ID: <7e45a728-0f65-a193-5df1-d49da704f40a@huawei.com> Date: Thu, 24 Aug 2017 19:41:21 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170824151958.GL8022@lunn.ch> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.206.50.78] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.599F01BF.002E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 295a1582180e40edffe6eacbeaf526c3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/2017 6:19 PM, Andrew Lunn wrote: > On Thu, Aug 24, 2017 at 09:21:25PM +0800, Aviad Krawczyk wrote: >> Fix the hw MTU limitation by setting min/max_mtu >> >> Signed-off-by: Aviad Krawczyk >> Signed-off-by: Zhao Chen >> --- >> drivers/net/ethernet/huawei/hinic/hinic_main.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c >> index ae7ad48..7a14963 100644 >> --- a/drivers/net/ethernet/huawei/hinic/hinic_main.c >> +++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c >> @@ -980,6 +980,9 @@ static int nic_dev_init(struct pci_dev *pdev) >> hinic_hwdev_cb_register(nic_dev->hwdev, HINIC_MGMT_MSG_CMD_LINK_STATUS, >> nic_dev, link_status_event_handler); >> >> + netdev->min_mtu = ETH_MIN_MTU; > > You don't need to set the min_mtu. See: > > http://elixir.free-electrons.com/linux/latest/source/net/ethernet/eth.c#L354 > > Andrew > > . > Thanks for paying attention to this unuseful line, I don't need to set min mtu. I added it by mistake, the target was to change the MTU limitation. I will send the patch soon without this line(in few days, after we will test it)