From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08E4420B7ED for ; Tue, 8 Jul 2025 02:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751940414; cv=none; b=edwNr8F3p62d9FaURwh2fp563Gk4GoKrrx7tnE66HhesQ46tz12+MZame8B53MIc6bkYMVjX1EMqRco15qDeyjzE69/HNRNL0AEL9lC8B5CnxODD0I8miiHFWVgZCfirt7wXcaA3DvrTOp49t1LmTfu8K9frSVo5RDY3Uy1Jgas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751940414; c=relaxed/simple; bh=nghdqr1TNgA7GTnWXSxnqQpSMH1Jj0RJB/prk1nIUIw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=VdmRiuhGclSsapnwxixtCDtRvNWc9aal0P6oij5wC1XjsfxusikseZw+BlkKrhr1gs3FGVkXYlaRJ1Brj601GQvPA4b38qYhDMPP/qTLZVYUzE6yS72rqRdnUvwYqUoSa1yJDd5yV0vMt3iObjx0iV2AAH9VU+ZoHuuw1ouD/Jk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=efnZSxRj; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="efnZSxRj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1751940409; bh=nghdqr1TNgA7GTnWXSxnqQpSMH1Jj0RJB/prk1nIUIw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=efnZSxRjJWL650CnneLc0hEdvRZaLwoT/UZWjOeiMpODmJ9Qh7k66Ejf1RFGcD+Si RNbW+BHbe8Wbnxg9j5DjAZiT7uANwG9Kl+ZiHYTslCR8NaxSaCDFvl/BPD6lx70ygU gc6kXs/SoeLzq23e6EOWOCW+SEZlnFRaPsCHJsFy9X65evzc+eKBNfCeXPueyyNrWB g678EnZT064/eewjQKeW6naXKWK1grI0oNvOM+1stcQoXJDMJaevtV/6nzBkPw9bBP ZstormeTgESK2Wz847+nLuUXSEAsBD+pYRWcEcJtLBAIpwPLIkb2a8vuNX3xaa3u23 7C+Vhb6Sb3ppA== Received: from [192.168.68.112] (unknown [180.150.112.153]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 26C476AE34; Tue, 8 Jul 2025 10:06:49 +0800 (AWST) Message-ID: <7e4738d944c611cfb0e4eba4ce2926ed55a0096a.camel@codeconstruct.com.au> Subject: Re: [PATCH v2 06/10] soc: aspeed: lpc-snoop: Rearrange channel paths From: Andrew Jeffery To: Jean Delvare Cc: linux-aspeed@lists.ozlabs.org, Joel Stanley , Henry Martin , Patrick Rudolph , Andrew Geissler , Ninad Palsule , Patrick Venture , Robert Lippert , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 08 Jul 2025 11:36:48 +0930 In-Reply-To: <20250704173443.3436f535@endymion> References: <20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au> <20250616-aspeed-lpc-snoop-fixes-v2-6-3cdd59c934d3@codeconstruct.com.au> <20250704173443.3436f535@endymion> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Jean, On Fri, 2025-07-04 at 17:34 +0200, Jean Delvare wrote: > On Mon, 16 Jun 2025 22:43:43 +0930, Andrew Jeffery wrote: > > Order assignments such that tests for conditions not involving resource > > acquisition are ordered before those testing acquired resources, and > > order managed resource acquisition before unmanaged where possible. Thi= s > > way we minimise the amount of manual cleanup required. > >=20 > > In the process, improve readability of the code by introducing a channe= l > > pointer that takes the place of the repeated object lookups. > >=20 > > Acked-by: Jean Delvare > > Signed-off-by: Andrew Jeffery > > --- > > =C2=A0drivers/soc/aspeed/aspeed-lpc-snoop.c | 51 ++++++++++++++++++++--= ------------- > > =C2=A01 file changed, 29 insertions(+), 22 deletions(-) > > (...) > > @@ -238,6 +240,7 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lp= c_snoop *lpc_snoop, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0goto err_misc_deregister; > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > =C2=A0 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* Enable LPC snoop channel = at requested port */ > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0regmap_update_bits(lpc_= snoop->regmap, HICR5, hicr5_en, hicr5_en); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0regmap_update_bits(lpc_= snoop->regmap, SNPWADR, snpwadr_mask, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 lpc_port << snpwadr_shift); >=20 > This duplicates a comment which is already present in the driver a few > lines before. >=20 > This duplicated comment gets cleaned up later in patch 10/10 (soc: > aspeed: lpc-snoop: Lift channel config to const structs). >=20 Thanks, I've dropped the duplicate in the process of applying the patches. Andrew