From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753014AbdJFXKh (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Oct 2017 19:10:37 -0400
Received: from mga14.intel.com ([192.55.52.115]:63213 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752758AbdJFXKg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Oct 2017 19:10:36 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,486,1500966000"; 
   d="scan'208";a="1022587280"
Subject: Re: [PATCHv2 1/2] mm: Introduce wrappers to access mm->nr_ptes
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20171005101442.49555-1-kirill.shutemov@linux.intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, Michal Hocko <mhocko@kernel.org>
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <7e476fd2-5818-c395-cdf2-00b5229c1a73@intel.com>
Date: Fri, 6 Oct 2017 16:10:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171005101442.49555-1-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/2017 03:14 AM, Kirill A. Shutemov wrote:
> +++ b/arch/sparc/mm/hugetlbpage.c
> @@ -396,7 +396,7 @@ static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd,
>  
>  	pmd_clear(pmd);
>  	pte_free_tlb(tlb, token, addr);
> -	atomic_long_dec(&tlb->mm->nr_ptes);
> +	mm_dec_nr_ptes(tlb->mm);
>  }

If we're going to go replace all of these, I wonder if we should start
doing it more generically.

	mm_dec_nr_pgtable(PGTABLE_PTE, tlb->mm)

or even:

	mm_dec_nr_pgtable(PGTABLE_LEVEL1, tlb->mm)

Instead of having a separate batch of functions for each level.