mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "jiale yao" <19888972804@163.com>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH 1/2] regulator: core: freeze deferred disable work during suspend
Date: Tue, 27 Oct 2026 14:27:28 +0800 (CST)	[thread overview]
Message-ID: <7e49a67a.4fae.1a17c0ad99b.Coremail.19888972804@163.com> (raw)
In-Reply-To: <atubBdUBEejAyR9n@sirena.org.uk>

At 2026-10-24 01:36:05, "Mark Brown" <broonie@kernel.org> wrote:
>On Fri, Oct 16, 2026 at 06:05:21PM +0800, Jiale Yao wrote:
>
>> regulator_disable_deferred() schedules hardware access after a
>> caller-provided delay. The power-efficient system workqueue remains
>> active during system suspend, so deferred regulator operations can reach
>> a bus after its controller has been suspended.
>
>> Use the freezable power-efficient workqueue to preserve the existing
>> power policy while deferring regulator access until devices have resumed.
>
>This is going to have a fun interaction with the only current user of
>deferred disables, DAPM.  If a DAPM supply that uses deferred disables
>is active at system suspend then it will disable it using a deferred
>disable but since the workqueue is frozen quite early on in suspend this
>will simply result in the disable not happening until after the suspend
>has completed which isn't the desired outcome.
>
>Since if we're suspending it's reasonable to assume that the supply
>won't be bounced on again quickly, or that if it is we can reasonably
>pay the cost of full ramp up, we should probably arrange for the disable
>to be processed immeditely if we're in suspend.  In addition if there
>are already pending disables it'd make sense to flush them rather than
>letting the workqueue freeze, for similar reasons.

Thanks for your review, this is updated version,
https://lore.kernel.org/all/20261027062007.2226548-1-yaojiale02@163.com/

  reply	other threads:[~2026-10-27  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 10:05 [PATCH 0/2] regulator: freeze delayed hardware access " Jiale Yao
2026-10-16 10:05 ` [PATCH 1/2] regulator: core: freeze deferred disable work " Jiale Yao
2026-10-17  7:21   ` jiale yao
2026-10-23 17:36   ` [PATCH " Mark Brown
2026-10-27  6:27     ` jiale yao [this message]
2026-10-16 10:05 ` [PATCH 2/2] regulator: irq: freeze deferred hardware access " Jiale Yao
2026-10-17  7:23   ` jiale yao
2026-10-19  8:00   ` [PATCH " Matti Vaittinen
2026-10-23 17:40 ` (subset) [PATCH 0/2] regulator: freeze delayed " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e49a67a.4fae.1a17c0ad99b.Coremail.19888972804@163.com \
    --to=19888972804@163.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®