From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC06734753A for ; Tue, 2 Jun 2026 09:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780392360; cv=none; b=D8r2xemjZ+mlzVk5QF5XNuQxyN50kfuDs9QaqOjDI8LuOyqTOpRDG4LdgFi7uKR7Dp3cHxZWoiThxoodhL38D8wK4Fp8moJWmrWHIbvrb/HWGTjP/sxahA9pUw+Gi4oYodzsxO5oImnpvVIx30XXjV5mB/yHaOB46sjajx/NuvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780392360; c=relaxed/simple; bh=qDW99IRpbYsSvH/nyeCYi9fxRt4ee++rjqOaFEH7YnM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K9Zt8uli1OoYUl/0lX6n8n6/zegMFWzY21w661asRY9gn/Z+DS7/p3REmS0nFFv7UCp8m4rtPaugCGu2rQGIY2ON69eLc/oJyf1FT4XNCpAdbBvEdkIJOrcYePVOnvj9YszDBmlCC0yu467yG7JJr5cXT+CDtgzCokeOQZY0Srk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Tg7X755a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QJIJlAbD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Tg7X755a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QJIJlAbD" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6526L9Vc2884844 for ; Tue, 2 Jun 2026 09:25:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a8oJhdM++qj84ExHpZEpnmVT1OSBcuhJ/dmbIOPi8AQ=; b=Tg7X755a+MFhnxIj ycrbD1uopXjdg1XWGUp0ARgDcMf3AGQ3DlgNZTI5jqISdvvfzHrYjiZNz3rRYavz E+MisLZkI4tzsG7Cey74sI+cPRs04maFEPx+90S6qvLKm5XWXtx7mDvDc09NPKQR eSQOsmD+GbPvWk9pzuB1uSXNRTao4u69wJ4Tquo+1zChc3dWCn4gU5OyiA7jqwSS z+1PEBPoTl0ZuQZ7EvXJwxdFPGjOsHscTSzAkfY3zJknDG7EBKNCs9RHT4CLWtFf bWSIW7LaiJWcr5IfX+ZKjC/K1nxQVET/kGMQajHsCiMr2Is+EjE/LXaVug/+PuNk mhAd9g== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehsu10rdf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 09:25:58 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36d6389bbf4so2591309a91.3 for ; Tue, 02 Jun 2026 02:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780392358; x=1780997158; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a8oJhdM++qj84ExHpZEpnmVT1OSBcuhJ/dmbIOPi8AQ=; b=QJIJlAbDEyDrtQJrWHe3TFLTRpgqHxVPYa5gcTAvmwQ7rmpARaWFSHdcP2qSuaYB3z U/lQVTt8m0dJPTW9qsHObekcRQF9dScJsg1+Loh02gP9zefTZIcu6Z9RwxQa6oA0nMVY 5jc2ZTVdAI3+xuNN+EvbhyV6kOkVW0aAJehkcldTTk8xJEZKnOXkZ8sxrONAPm65yt+D q17zPbaA9827u8qBuSDFH0blFSZetXyHcuqzXrBNETwWLDuSOU8iePTn8dXXt9drce/j EiW7xjHSWI7bdpXPW/Z2SlLdJKdzlcB5bwkEDiKq1pa+q6UfZjncl6/5LiMLnA8hJNqO pOlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780392358; x=1780997158; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a8oJhdM++qj84ExHpZEpnmVT1OSBcuhJ/dmbIOPi8AQ=; b=jGfHkNNNyxeuoidBqr7UcvpPZvETSU5bwaSZi8Nk1RcghDwBDqd8MpSmTNtS1W1oow 5POM9fpStFCY/da8qz6qoAl0PomNlVXlBsPxpYoPD2FRMHXjVZjH0bSArhBIDQMfTWwf O87tIchGx4OOWlgFstcBogFiZxc+wII7wnOR06CaY9OSP1zKxqjNAtFVzJQdR1SZyQAp Ku8HLNTdhB8XsC2WnwzAAM19JFD82tnNPtNdDAnfB0aBIf2Xn0bjp2Z7it3Lt2LAZAmV GdosFuQw/rq7Iz4kA5tgQzvR24i2zIO7sN+0mFjrmcXj5KAkfMK3bJuFF0hEkvgl37/O 4+sA== X-Forwarded-Encrypted: i=1; AFNElJ87KAYlHPvvKXwtOzVRdhYfof+sy+ZOqecW1eZNMUdlMmdYXvi1OaBKVdO45pdQg9WO1qgBhfv/MrM0SYY=@vger.kernel.org X-Gm-Message-State: AOJu0YxBYS+YhIWs7XVZmxt4lY0o57Aqe/HZyCoUVpLKgcwK6lc35A3H QCCd2SgvFxGxXtF9TNM0j74IhbWuONVSLKfi5cEJZi3litE3omUIXukfqCLNIzlg3u4gXabKLKM CbtrvlDQPBApU8qr+4TvwNIXeFuGosySseOakCHZHK8vmXgwhg1ssEc720NsKci/xQzQ= X-Gm-Gg: Acq92OHwK4//G4cxCW1bWm7i+H+TFTDQG+0ePqBXFR46Fs5trN7X7lpUioVUbXuGwNt 15UeM9nsvQ2zysTMiytNWtPI7hAeHIYxQbtmyM6ULYPSxNbNlGD1iPTdQ/A4S/BhsXGKQyfzoLQ pF3T83ufQQbpvbvOtWsP+0SB+wbtR26Jjj9GqvTEkXin0rBU9Y0/te16Hc4cmf7gkKgIhmER5wu y5jvRgI5i42cRWofnyjLVOLknv4J+bCPedO+v8fGjN+DGTAQORurPtXwPrgoCYHtVmxOphnXPlE SGok5Bj2h6oktyZL+JA0tN0UeUC5OuW2OHTjeGGd5tLmohUZ0PlfuOaRQ/UZreHCfLTEU8FxGzn u0prvWtenXu26nd0MvFIK09zne4bGOGckrFpkpANfdj//VwLB9PJD X-Received: by 2002:a17:90b:2889:b0:36d:bbe0:de7c with SMTP id 98e67ed59e1d1-36dbbe0e324mr6879180a91.12.1780392357847; Tue, 02 Jun 2026 02:25:57 -0700 (PDT) X-Received: by 2002:a17:90b:2889:b0:36d:bbe0:de7c with SMTP id 98e67ed59e1d1-36dbbe0e324mr6879145a91.12.1780392357348; Tue, 02 Jun 2026 02:25:57 -0700 (PDT) Received: from [10.64.68.243] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd91f1affsm2165015a91.11.2026.06.02.02.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 02:25:56 -0700 (PDT) Message-ID: <7e5299fd-85f9-4f74-9e69-5192aca81f05@oss.qualcomm.com> Date: Tue, 2 Jun 2026 17:25:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Jianping Li , srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org, abelvesa@kernel.org, jorge.ramirez@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ekansh.gupta@oss.qualcomm.com, quic_chennak@quicinc.com, stable@kernel.org References: <20260602071750.526-1-jianping.li@oss.qualcomm.com> <20260602071750.526-4-jianping.li@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260602071750.526-4-jianping.li@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: vPP2ADHyr15VLsVWpP11EaGdh9G7jEXq X-Proofpoint-GUID: vPP2ADHyr15VLsVWpP11EaGdh9G7jEXq X-Authority-Analysis: v=2.4 cv=MKFQXsZl c=1 sm=1 tr=0 ts=6a1ea1a6 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NWGsHJKA5YHOe65YnXUA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA4NyBTYWx0ZWRfX1cnJQOYNXrm+ faiuIU9RTE+ntk0C8KxWZfkhkmagzz+P6NMgzJZ/6Rz0h8Tdm1rWtlEfR8DwEz56r8KDL8XTXdz mZZXKzTe/3nJogWJ8d+sFKJaC5HlTi7aJLFPwEcd+QV2hRDULp8+d7pgQZhXPgznzhgx0RvX6b+ 1jCRATBzlG54gtANFaueck2UomGeWN+RJO0Dj0o1PXyrFVsi+nCKT4cDC+cVx51GC0l+hm6Sjbg FbFfc1G0j3EYeu9y7GlGxDSOPXMU900DDOo4KyxVGBdhHVW4j6o0NSKEn4pEAlzOzDvX4fzGuTQ ZL1lYwCH1GfJCjBx6erHkBiIs4ezXGqb+zGoUdST3mfPsHKp5Gcj5l/Dvu6RgGoxoX3QaruieS1 bLVMB9uTDE3H1yR3e+jS783Oq09r0fEtvVr9ub0Jrk3eoXdewrK5eL2slT46nH3LgzVn6bifxBE 2orfe/b7J555KmrDeIA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020087 On 6/2/2026 3:17 PM, Jianping Li wrote: > Audio PD static process creation assumes that a reserved-memory > region is defined in DT and exposed via cctx->remote_heap. > > If reserved-memory is missing or incomplete, the driver may pass > invalid address/size information to the DSP, leading to undefined > behavior or crashes. > > Add explicit validation for remote_heap presence and size before > sending the memory to DSP, and fail early if the configuration is > invalid. > > Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") > Cc: stable@kernel.org > Signed-off-by: Jianping Li > --- > drivers/misc/fastrpc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index a8a58f889d07..f46a8f53970d 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1354,6 +1354,13 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, > } inbuf; > u32 sc; > > + if (!fl->cctx->remote_heap || > + !fl->cctx->remote_heap->dma_addr || > + !fl->cctx->remote_heap->size) { > + err = -ENOMEM; > + dev_dbg(fl->sctx->dev, "remote heap memory region is not added\n"); should be an error instead of dbg info. Thanks, Jie > + return err; > + } > args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); > if (!args) > return -ENOMEM;