mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Sriman Achanta <srimanachanta@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	 Benjamin Tissoires	 <bentiss@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] HID: hid-ids: Add SteelSeries Arctis headset device IDs
Date: Mon, 12 Jan 2026 14:08:01 +0100	[thread overview]
Message-ID: <7e5573c900fdf4057bf8a599d85413ed94ea0e9f.camel@hadess.net> (raw)
In-Reply-To: <20260112041941.40531-2-srimanachanta@gmail.com>

On Sun, 2026-01-11 at 23:19 -0500, Sriman Achanta wrote:
> Add USB device IDs for the complete SteelSeries Arctis headset
> lineup,
> including:
> - Arctis 1, 1 Wireless, 7, 7P, 7X variants
> - Arctis 7+ series (PS5, Xbox, Destiny editions)
> - Arctis 9 Wireless
> - Arctis Pro Wireless
> - Arctis Nova 3, 3P, 3X
> - Arctis Nova 5, 5X
> - Arctis Nova 7 series (multiple variants and special editions)
> - Arctis Nova Pro Wireless and Pro X
> 
> This also fixes the existing ARCTIS_1 ID to use the correct product
> ID
> (0x12b3 instead of 0x12b6, which is actually the Arctis 1 Xbox
> variant).

"This also fixes" usually is a good way to tell you that this should
have been a separate patch.

It would be useful if you could change the indentation in a first
patch, "fix" the USB ID in a second patch, and add new IDs in a third
patch. Note that in your second patch, you'll need to change the source
code to use that new identifier otherwise you'll be breaking my headset
:)

Please make sure to CC: me on future patchsets you send.

> 
> These IDs will be used by the updated hid-steelseries driver to
> provide
> battery monitoring, sidetone control, and other device-specific
> features
> for these wireless gaming headsets.
> 
> Signed-off-by: Sriman Achanta <srimanachanta@gmail.com>
> ---
>  drivers/hid/hid-ids.h | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index d31711f1aaec..f4f91fb4c2b9 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -1303,10 +1303,35 @@
>  #define USB_DEVICE_ID_STEAM_CONTROLLER_WIRELESS	0x1142
>  #define USB_DEVICE_ID_STEAM_DECK	0x1205
>  
> -#define USB_VENDOR_ID_STEELSERIES	0x1038
> -#define USB_DEVICE_ID_STEELSERIES_SRWS1	0x1410
> -#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1  0x12b6
> -#define USB_DEVICE_ID_STEELSERIES_ARCTIS_9  0x12c2
> +#define USB_VENDOR_ID_STEELSERIES			0x1038
> +#define
> USB_DEVICE_ID_STEELSERIES_SRWS1			0x1410
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1		0x12b3
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_1_X		0x12b6
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7		0x1260
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_P		0x12d5
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_X		0x12d7
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_GEN2		0x12ad
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS		0x220e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_P	0x2212
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_X	0x2216
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_7_PLUS_DESTINY	0x2236
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_9		0x12c2
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_PRO		0x1290
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3		0x12ec
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3_P	0x2269
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_3_X	0x226d
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_5		0x2232
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_5_X	0x2253
> +#define
> USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7		0x2202
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X	0x2206
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_P	0x220a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X_REV2	0x2258
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_DIABLO	0x223a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_WOW	0x227a
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_GEN2	0x227e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_7_X_GEN2	0x229e
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_PRO	0x12e0
> +#define USB_DEVICE_ID_STEELSERIES_ARCTIS_NOVA_PRO_X	0x12e5
>  
>  #define USB_VENDOR_ID_SUN		0x0430
>  #define USB_DEVICE_ID_RARITAN_KVM_DONGLE	0xcdab

  reply	other threads:[~2026-01-12 13:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  4:19 [PATCH v2 0/4] HID: steelseries: Add support for Arctis headset lineup Sriman Achanta
2026-01-12  4:19 ` [PATCH v2 1/4] HID: hid-ids: Add SteelSeries Arctis headset device IDs Sriman Achanta
2026-01-12 13:08   ` Bastien Nocera [this message]
2026-01-12  4:19 ` [PATCH v2 2/4] HID: quirks: Add INPUT_CONFIGURED quirk for SteelSeries Arctis headsets Sriman Achanta
2026-01-12 13:08   ` Bastien Nocera
2026-01-12  4:19 ` [PATCH v2 3/4] Documentation: ABI: Document SteelSeries headset sysfs attributes Sriman Achanta
2026-01-12 13:08   ` Bastien Nocera
2026-01-12  4:19 ` [PATCH v2 4/4] HID: steelseries: Add support for Arctis headset lineup Sriman Achanta
2026-01-12 13:09   ` Bastien Nocera
     [not found]     ` <CABMjph80yxmXnZjLgUrhFN7cKf2P=VjWF0rfWxG0rYOa42f5eQ@mail.gmail.com>
     [not found]       ` <e5b256fa8da7fe079f3e3b10a1b0b6a0faf8e913.camel@hadess.net>
     [not found]         ` <CABMjph9TzmCfks0OEtCx4gFFe0pKOccBwVutq6dVH2DhzSC5vA@mail.gmail.com>
2026-02-26 10:01           ` Bastien Nocera
2026-01-20 19:01 ` [PATCH v2 0/4] " Benjamin Wheeler
2026-01-20 20:01 ` [PATCH 0/3] HID: steelseries: clean up functions, move battery request data to structs Benjamin Wheeler
2026-01-20 20:02   ` [PATCH 1/3] HID: steelseries: Clean up hid send_report functions Benjamin Wheeler
2026-01-20 20:02   ` [PATCH 2/3] HID: steelseries: Add battery request info (byte flags) to device info Benjamin Wheeler
2026-01-20 20:02   ` [PATCH 3/3] HID: steelseries: Use device data for battery requests Benjamin Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e5573c900fdf4057bf8a599d85413ed94ea0e9f.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srimanachanta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®