From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751112AbdHZQyZ (ORCPT ); Sat, 26 Aug 2017 12:54:25 -0400 Received: from mout.web.de ([212.227.17.11]:52618 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbdHZQyX (ORCPT ); Sat, 26 Aug 2017 12:54:23 -0400 To: devel@driverdev.osuosl.org, Bhumika Goyal , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Julia Lawall , Mihaela Muraru , Mike Kofron , Philippe Reynes , Stephen Hemminger , Tobias Klauser , Yuval Shaia From: SF Markus Elfring Subject: [PATCH] staging: netlogic: Delete an error message for a failed memory allocation in xlr_config_spill() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <7e6515bc-09ba-6b2a-ea64-433cc3befe6c@users.sourceforge.net> Date: Sat, 26 Aug 2017 18:54:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tQU5XvgP5o2IBr5uTwNkwe7FWEY/qhNQ/SyCxMuvUh4IEeUrQX/ LSjFRwl7OMuQXCkRBYrQlEoMvaRsAHictbd2Yqm/WRUUCxtwVunldO3sdjdHTLD1obz3BXE LhMiDNc7Z8JHZzmt5/6LUOMgfYVuPTxLn41mR/Gp1OoL7Ge9MOOj5aAdO2IErIO6k8dG89r N165KWE03h3XruovXHwuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:iZRt812gVqI=:MYd6nHFNLB8dP4GxLdJMhT lOJPMNEsy7IDIw8j5p4lEbL6e6lgY7g64z9virCtbQgChYbb++vwTDyC5ek2tQxukHAgkWevV /Hnvg+AQLz3OJC/0+vAyOgunN9tSoND7nEUklFPgjXOmTD8uWn+m0diJ6bHhdfEiCJZPQGRvO AHJRAuR6qUHDnxuM3AExrhCzDSmHErqUBc7gRs79WxBCZHQD5BidFEUN5BuVebWrCQoClkYTE UMJA0TCFt/GruUlHtVUmGZQOVVil0MVBI0YrxoXLl1bsZII1DCMKuIK4fUSytlvIGKaFQO51c PP0FEDMN43lxIGprLLtg8tr34u8mqbftt3AOC8/DlffEEPv1QJzYrpXfEbDfhQ9ch4Q2tzaIO JTbtAZV3FDgyn+UZ8OoX4DmIBTeeM4pjPECTeU2YWfrX6Tzb/S9sY+Ofs08jwzqRdVnJe353f P1jLbbtCxTxI4pTVUgIp08DiBMnB7kU8egMsr1t2NaiTbb8/daSJ1D9HACmrMVKMCG5MFjyYV kjbvuCq8YShnEI3CDo6r6NNgTTO4Le/FrC/q6VkD7ioo1GcoozY008mTYSdAs/lkuS0F47ssT /G5rX7HA8KS0KgOe9W6UICtuaC9Cq6VI2xUvvWk9EQ8F/NbgRcsoGY0E0Ovyf7WFO71UT0ROD jpwF7THjbHlKOAEjGtolE6263sGOzvcoiwyu1LUhEgVni/Q9Odb0+dZ5NUNepUaV2z0x/S6tl fgA7OR1QG41w6rXGZJTC/wSpfObtoGcREPMJf7acH3M3GdmebPh/HGBmRWAMbZSvp9J5h3aUN jRPFbQrwxFMidSy1q/FvABTxksLcd4hRJWxoHz2xpFIT/EME0A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 26 Aug 2017 18:44:12 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/netlogic/xlr_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index e05ae4645d91..04cdcf3f329f 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -423,10 +423,8 @@ static void *xlr_config_spill(struct xlr_net_priv *priv, int reg_start_0, base = priv->base_addr; spill_size = size; spill = kmalloc(spill_size + SMP_CACHE_BYTES, GFP_ATOMIC); - if (!spill) { - pr_err("Unable to allocate memory for spill area!\n"); + if (!spill) return ZERO_SIZE_PTR; - } spill = PTR_ALIGN(spill, SMP_CACHE_BYTES); phys_addr = virt_to_phys(spill); -- 2.14.0