From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755067AbcK1SeA (ORCPT ); Mon, 28 Nov 2016 13:34:00 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:23735 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754403AbcK1Sdv (ORCPT ); Mon, 28 Nov 2016 13:33:51 -0500 Subject: Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu To: David Miller References: <1478887919-10361-1-git-send-email-vijay.ac.kumar@oracle.com> <1478887919-10361-3-git-send-email-vijay.ac.kumar@oracle.com> <20161119.104812.1434195314137737490.davem@davemloft.net> Cc: sparclinux@vger.kernel.org, karl.volz@oracle.com, rob.gardner@oracle.com, linux-kernel@vger.kernel.org From: Vijay Kumar Organization: Oracle Corporation Message-ID: <7e6a2af2-87b7-f042-cd8a-aabac3b3a80b@oracle.com> Date: Mon, 28 Nov 2016 12:33:57 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161119.104812.1434195314137737490.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2016 9:48 AM, David Miller wrote: > From: Vijay Kumar > Date: Fri, 11 Nov 2016 10:11:57 -0800 > >> @@ -1444,8 +1444,12 @@ void smp_send_stop(void) >> int cpu; >> >> if (tlb_type == hypervisor) { >> + int this_cpu = smp_processor_id(); >> + >> + sunhv_migrate_hvcons_irq(this_cpu); >> + > You can't unconditionally call into code that might be configured > out by a Kconfig option, as you are doing here. > > If SERIAL_SUNHV=n this change will thus result in a build error. Thanks for your comment. I will fix this and send revised version of patch. Thanks, Vijay