From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85D8C3E9C37 for ; Wed, 13 May 2026 11:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673563; cv=none; b=t/L1hnAH2SvsiDDQ+UV6dr6AV0Cu6JgkIFiTg10Kxr/fLeEaiG7iLXJXCwA6X3RFGFbspFYG/7t+mWq4rzQrSOFm/2tn+qHsmNANaWpNcjonPSb3chBbUU3roq3w4/+51VR7SEKMs1m4NKDPfJIDLaNgM7TkmXyH1POlA4EpQ1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778673563; c=relaxed/simple; bh=HsY5MIeA4hOcwSXUwi/tyCOWbILSHzAPQAce3C7wNKc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=CQdIQA1jVFJ0gcDe8PlQLPIbafxezIyb+VHQRv3yR5+h5+dCLZ1inV9aCCYcI+hu+I1i7f0ydEVRw0EEWkc7o/cKh+MsnOcNnxhHkCiA41AUXI+AkutRwkXhZEa8sNH2wt0kH63QMNwmoDycZ4mRG6DI9tMEt7c7zU1FMJasUxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aLCjoli8; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aLCjoli8" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so71342905e9.0 for ; Wed, 13 May 2026 04:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778673561; x=1779278361; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Ru5o97ykp5715LdAIbuApmVualUVsm7HDP8jRRU8bOk=; b=aLCjoli8HJr0h4+2yTM+do2Ec4GTf4yNDfrJY7F80rR1V8zFsoyzN6dBwrZ1TOE+dg KQr/0Zo95sWxj2GdWPD++PCQNtkZIbEwP804/mXsVAmqYODhuqFu8xP+7yHgka/jbcTk /WifHGxUoMftBddMfTGiVb0eAJQ1NeOoBYo0ppRwa1PZbmS8hGIElgG1v1K95XFb8OHg CGzqlu4vJQ51v3EQ/ghRSOJmkSuRURBvb5goJhRnB/7itxqQPPVkfaPPURoELXhbYFcY tpeuyowxLasND3cuulJmc6XToTQ/E6No2Ymm+qjQBEDsmqmLV5Dl3PDwbDH4+Fv9okim 6GZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778673561; x=1779278361; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ru5o97ykp5715LdAIbuApmVualUVsm7HDP8jRRU8bOk=; b=Sg/FHJgF4ls0XfpNx8ZsjwEBFbgFVg0M8on+J14Bi67hh2t+FklqJpbAMY78uCk4DK t1Vm65CLIiB2qSVr/O2ZsKmuTcdWE13QX99d8Pw1fXc81ZzJtzov+3RVWXoBFSWcMRsN F9r7BH/ZmzQW4PNu7+xwkBSLFO7kwRtH00vOX6rXcM8Hg/EUorWWEdqWGNup7XZyuCwo HFWf96iH4Be4RDJMcqIg/JUCDMP3D/kFgQ+3IKOxgElfy233Q5+v/TFS7R035ugK4bwL 1qMXd9CgTtQ6CdfRwM0vaPAbXsY6r/JS3ey5mAS+wLy7zG8O4VdIdCwXVP96M6lW6mG+ lX8g== X-Forwarded-Encrypted: i=1; AFNElJ+SpILTRMGJCj1ofHARcQhlfr4js/Rbm4M6mJyzC78qzGDYQw/5SzdwBnZgI2lWDEBADtUt0o6ZeV6GUK4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9UMIz03RYv8HCNzIOoLoknLmvhVE8nccKbmCXa3Zbmsibagsc S8t4a3XbHBvsiAESVbG1AN+W8c8ujo4IaIL8G2x1wNtCQWpW5y784LEPiBL+Z/fwgIA= X-Gm-Gg: Acq92OHSFajuy+aU9oKEIxUQSQz55j7ySHkrv3LHm6Hr8jAQWVFrO1sAQVs6mJ6WmFG PW3r0+RrT1WiOZM03vJ2lQ3eTw33znXlcs4sgY/GUWpZXY/LpDodk5CFLS5HsM0pliT9AB+c3mn H0IqMB2uBfabvCYcG7pNcG4e4eRxioh0+FkVmaLo8n2TJRiPT6uaJvAMJqfjoG+kk5tElis9kIL 0v36Escc5uzNxLzLEo5cfVYa8ET2VLKYjWlnzz0kl97mp2jyCcjAiuxAsvh18SyG/SOtbUS/BGQ 6v3r5wT26Vqda5TuEotnoIjhpBCi6lDCewIExhWVwH6l2E4WuRpPbB/EfQctThAUKzFZ3F1eAM2 tnvMvbywD8Ri1KQw57Wp+WZOtsrr3KIdbU2dArWIFcNZc1L3GFreSD7sVLV5nNzFbC5BwQzmMCu qHSMO9U/0U2M+RhA3eC58RgmOegXcHUVYB4dtsGQlMSrVxyLgCDMOPxxpH5ATl6elMFa5w3awjF +y2 X-Received: by 2002:a05:600c:1910:b0:488:9ed3:1492 with SMTP id 5b1f17b1804b1-48fc9a09cb7mr45810035e9.10.1778673560723; Wed, 13 May 2026 04:59:20 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6ee4:8e37:145:d60b? ([2a01:e0a:106d:1080:6ee4:8e37:145:d60b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fce38328esm38190415e9.13.2026.05.13.04.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 04:59:20 -0700 (PDT) Message-ID: <7e6f629f-209a-481c-aa1e-9a5e8415e0a1@linaro.org> Date: Wed, 13 May 2026 13:59:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 6/6] media: qcom: iris: vdec: allow GEN2 decoding into 10bit format To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <20260511-topic-sm8x50-iris-10bit-decoding-v3-6-7fc049b93042@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/13/26 12:45, Dmitry Baryshkov wrote: > On Mon, May 11, 2026 at 11:20:31AM +0200, Neil Armstrong wrote: >> Add the necessary bits into the gen2 platforms tables and handlers >> to allow decoding streams into 10bit pixel formats. >> >> Signed-off-by: Neil Armstrong >> --- >> .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 16 +++++++++++++++- >> drivers/media/platform/qcom/iris/iris_instance.h | 2 ++ >> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 8 +++++--- >> drivers/media/platform/qcom/iris/iris_vdec.c | 8 ++++++++ >> 4 files changed, 30 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> index 0541e02d7507..b6d815c01f1d 100644 >> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >> @@ -542,6 +542,15 @@ static void iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) >> pixmp_ip->width = width; >> pixmp_ip->height = height; >> >> + if (subsc_params.bit_depth == BIT_DEPTH_8 && >> + pixmp_op->pixelformat != V4L2_PIX_FMT_NV12 && >> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC08C) >> + pixmp_op->pixelformat = V4L2_PIX_FMT_NV12; >> + else if (subsc_params.bit_depth == BIT_DEPTH_10 && >> + pixmp_op->pixelformat != V4L2_PIX_FMT_P010 && >> + pixmp_op->pixelformat != V4L2_PIX_FMT_QC10C) >> + pixmp_op->pixelformat = V4L2_PIX_FMT_P010; > > Do we support decoding of 10-bit videos to NV12 buffers? AFAIK no, I found no sign of that in the downstream driver but I may be wrong. Neil > >> + >> switch (pixmp_op->pixelformat) { >> case V4L2_PIX_FMT_P010: >> pixmp_op->width = ALIGN(width, 128); >