From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CE0222839A; Fri, 23 May 2025 10:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747996842; cv=none; b=NfTEblRRr2tE1qzSTUwuQxSJsEcSsIhwt+m0Ty/DfXloF003XYnOy4CIE6pjBbPgoJLaEHDa8BWwS3LYG6kPpIRl5DQAFwZAS6E4kGTVc+yagIhjNUynE1GqfS34fWUxoSYjutOH51GRokWtSpH97zknOREen5mU/T7JVwiHsbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747996842; c=relaxed/simple; bh=K2JQO+uYU43rONsrKzctsDigqQZ79oxfKv9WnQ4M8rs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TVVI1DJnG68vVC+KaM4Ko28QwIV5lcs++PvcvWA/rwYSbV2yjO0oupYm6XSG/IvKYy0m/+6Qg3fDEH9a4KLt5pCzFu2cLLN4k8FzTZbkrrvVs1oK2XmiUPP6TzR8mkmFlhKDsjhdANk61QHwMidmM5qoq502wyF0AChKaHNWVDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=qdU3KuMZ; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="qdU3KuMZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=K2JQO+uYU43rONsrKzctsDigqQZ79oxfKv9WnQ4M8rs=; t=1747996840; x=1749206440; b=qdU3KuMZ9sweprsLMMsnuRdUYa5laczAF/iWMqExK+PNlyJ c677zeHd97X1PK7EZWtGUh7fRRZneSmsFVYOWNmxtRoZWeUW+bE6YNr0tKr339HoSGALk73HQssEe Me6S6+FPchv46CvtJE6UzDM9LLykPrQIKwbbhxzOAEpnbrnXcYDgaYvogcdzMdIlWEOnbg5n34Dn6 ywZuDVQsx7W0+b0Rw6imHHRZCKR0ug2sTo9qQKkWDxnUZSulv8t2p0BJRYlibX94khJQFs4bU+EqY Osju0I3cb8GSyrBz5uaxzJ9VCbfBYiayFKUNaUPQ51IaYr+mp+fmUxaSoTmIxxIA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1uIPp5-00000001O1N-1Ky4; Fri, 23 May 2025 12:40:19 +0200 Message-ID: <7e708dcc98c6f0f615b1b87d190464cfe78be668.camel@sipsolutions.net> Subject: Re: [PATCH v2 2/6] ASoC: aoa: Use helper function for_each_child_of_node_scoped() From: Johannes Berg To: =?UTF-8?Q?=E8=89=BE=E8=B6=85?= , perex , tiwai , "kuninori.morimoto.gx" , lgirdwood , broonie , jbrunet , "neil.armstrong" , khilman , "martin.blumenstingl" , "shengjiu.wang" , "Xiubo.Lee" , festevam , nicoleotsuka , shawnguo , "s.hauer" , "srinivas.kandagatla" Cc: linux-sound , linux-kernel , linuxppc-dev , linux-renesas-soc , linux-arm-kernel , linux-amlogic , imx , kernel , linux-arm-msm Date: Fri, 23 May 2025 12:40:18 +0200 In-Reply-To: <2aq0nyvyf7t-2aq4hsc7kp6@nsmail7.0.0--kylin--1> References: <2aq0nyvyf7t-2aq4hsc7kp6@nsmail7.0.0--kylin--1> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned Hi, [you should avoid HTML] > "simplifies the code" is no need to callof_node_put() . Fair. Except that's not what you _actually_ changed here. Like I said, either it's buggy before or after. johannes