From: Li Kun <hw.likun@huawei.com>
To: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jann Horn <jannh@google.com>, Eric Biggers <ebiggers3@gmail.com>,
Elena Reshetova <elena.reshetova@intel.com>,
"Hans Liljestrand" <ishkamiel@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>, <arozansk@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Manfred Spraul <manfred@colorfullife.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"James Bottomley" <James.Bottomley@hansenpartnership.com>,
"x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Rik van Riel <riel@redhat.com>, <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [kernel-hardening] [PATCH v8 3/3] x86/refcount: Implement fast refcount overflow protection
Date: Tue, 25 Jul 2017 20:03:08 +0800 [thread overview]
Message-ID: <7e7918c6-7186-47f4-4b37-2fc55db1e678@huawei.com> (raw)
In-Reply-To: <1500921349-10803-4-git-send-email-keescook@chromium.org>
Hi Kees,
on 2017/7/25 2:35, Kees Cook wrote:
> +static __always_inline __must_check
> +int __refcount_add_unless(refcount_t *r, int a, int u)
> +{
> + int c, new;
> +
> + c = atomic_read(&(r->refs));
> + do {
> + if (unlikely(c == u))
> + break;
> +
> + asm volatile("addl %2,%0\n\t"
> + REFCOUNT_CHECK_LT_ZERO
> + : "=r" (new)
> + : "0" (c), "ir" (a),
> + [counter] "m" (r->refs.counter)
> + : "cc", "cx");
here when the result LT_ZERO, you will saturate the r->refs.counter and
make the
atomic_try_cmpxchg(&(r->refs), &c, new) bound to fail first time.
maybe we can just saturate the value of variable "new" ?
> +
> + } while (!atomic_try_cmpxchg(&(r->refs), &c, new));
> +
> + return c;
> +}
> +
--
Best Regards
Li Kun
next prev parent reply other threads:[~2017-07-25 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 18:35 [PATCH v8 0/3] x86: " Kees Cook
2017-07-24 18:35 ` [PATCH v8 1/3] x86/asm: Add suffix macro for GEN_*_RMWcc() Kees Cook
2017-07-25 13:48 ` [tip:x86/asm] " tip-bot for Kees Cook
2017-07-24 18:35 ` [PATCH v8 2/3] x86/asm: add ASM_UNREACHABLE Kees Cook
2017-07-25 13:49 ` [tip:x86/asm] x86/asm: Add ASM_UNREACHABLE tip-bot for Kees Cook
2017-07-24 18:35 ` [PATCH v8 3/3] x86/refcount: Implement fast refcount overflow protection Kees Cook
2017-07-25 12:03 ` Li Kun [this message]
2017-07-25 19:11 ` [kernel-hardening] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e7918c6-7186-47f4-4b37-2fc55db1e678@huawei.com \
--to=hw.likun@huawei.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arozansk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=ebiggers3@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=ishkamiel@gmail.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=serge@hallyn.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®