From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
kishon@ti.com, robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling
Date: Wed, 13 Dec 2017 12:09:40 +0300 [thread overview]
Message-ID: <7e7953b2-e94d-ded8-2278-6259a1457881@cogentembedded.com> (raw)
In-Reply-To: <1513146460-20326-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hello!
On 12/13/2017 9:27 AM, Yoshihiro Shimoda wrote:
> This patch unifies the OBINTEN handling to clean-up the code.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> index c22d65a..beeaa30 100644
> --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> @@ -147,6 +147,18 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
> writel(val, usb2_base + USB2_ADPCTRL);
> }
>
> +static void rcar_gen3_enable_otg_irq(struct rcar_gen3_chan *ch, int enable)
If it both enables and disables, rcar_gen3_control_otg_irq() would seem a
better name...
> +{
> + void __iomem *usb2_base = ch->base;
> + u32 val = readl(usb2_base + USB2_OBINTEN);
> +
> + if (enable)
> + val |= USB2_OBINT_BITS;
> + else
> + val &= ~USB2_OBINT_BITS;
> + writel(val, usb2_base + USB2_OBINTEN);
> +}
> +
> static void rcar_gen3_init_for_host(struct rcar_gen3_chan *ch)
> {
> rcar_gen3_set_linectrl(ch, 1, 1);
[...]
MBR, Sergei
next prev parent reply other threads:[~2017-12-13 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 6:27 [PATCH 0/5] phy: renesas: rcar-gen3-usb2: add gpio handling for R-Car D3 Yoshihiro Shimoda
2017-12-13 6:27 ` [PATCH 1/5] phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway Yoshihiro Shimoda
2017-12-13 6:27 ` [PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling Yoshihiro Shimoda
2017-12-13 9:09 ` Sergei Shtylyov [this message]
2017-12-14 9:48 ` Yoshihiro Shimoda
2017-12-13 6:27 ` [PATCH 3/5] phy: renesas: rcar-gen3-usb2: use prefix "has_otg_pins_" for dedicated pins handling Yoshihiro Shimoda
2017-12-13 6:27 ` [PATCH 4/5] phy: renesas: rcar-gen3-usb2: add rcar_gen3_role_swap_ops Yoshihiro Shimoda
2017-12-13 6:27 ` [PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling Yoshihiro Shimoda
2017-12-13 8:55 ` Geert Uytterhoeven
2017-12-14 9:44 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e7953b2-e94d-ded8-2278-6259a1457881@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®