From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDC1523394B for ; Wed, 20 May 2026 13:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779283989; cv=none; b=DbyzDmShh2nI7Alo9UC4cF04vX0+LgIDeYyDar9nfJ5x9yFwSppaYyPi994/UoAaDpz3KH+rSCzuD1APg44wocWb5ky2BnC+XDmnbxmGfEtxtZVY85+R08Ic6i5fY3eqrI57uv8DO5DTePB9Iw2usUSr93oq+jqioa5r0OI3+3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779283989; c=relaxed/simple; bh=mI/dLE2gvCkwzHpuiXiHG4DnYZB4NfXY0VRBtLbXmM8=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=jcrYMuM/i9RfpUkswW7rMs6ETp9yTi7slOuqfxbl2iR39PSdIPo37poZeMroWXFioqBMScnRhjeSttuOSYp9Qa3rCfAN9cvRRH7k94tAoM8yowdnMG/zH3izndQbJUTHn6jopVfJaBmh5hoixL2yytjWPmBB9AVPX7N0Ic41NgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DAjS7oQL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAjS7oQL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48a7fe4f40bso58709525e9.0 for ; Wed, 20 May 2026 06:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779283986; x=1779888786; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=+BbUsY922weMR93UyHTzY/cK/43gwBu0eJe2gDDiTIU=; b=DAjS7oQLe97N8SR7sxAfkmutV8KiJKJKxxeQMe9oUFU/PQcFDuCxG0D4GNZDWeoIpt op0ldpv/p1kT16T9jR3d3/xFDun0qZg3VPOfaeTIO4nIK5r03/nWy2G9gK2HOgaRQsny blmFquzPDFK85Axzzp5mXJl0opf34YmLNF2cjhbcOneVVDJhvRXfDfVjUqYaYleGGBAn anQ4aylcinyrvCeWHXA025cx+FUxnw69gNKiCaCDMmOioudcUGDOsoMCW35nRHE+foz5 b/5Jsa+TRSJw9dnnUyO976uourMRqZJp8RHkVbBE+apGB3RQsrreNLSrdX1iTw7Ek65W 7sAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779283986; x=1779888786; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BbUsY922weMR93UyHTzY/cK/43gwBu0eJe2gDDiTIU=; b=WQYUo9OzwyO8qyR9Nl50cVvBPtAF/Ce9zbZe9HAzbKF4u+qtphUJ+FeqigR7crVFKc 38yO2+HHqCMR33kMWsPbo4iCzrTDZTEyfqLrpOnQodjvoRjMb4XJ97h6KKw3vz3ZLS3N Zp1ZkJPF36l3HPfuvaGjaupztwC5rqP6WzBtTpKJjVuiEhaJL5DyY6rhTk3njB77iJpe v4sOnMJBVg6v36F16KaQB2M96C33LNTh7Fsdw4kUxQcO0YWwynaoZgHl6qcow7UItJmg Eln2srH30H12u4mHlPz/DfwihxA1kjfR/FVaIdr33X4RANFWaON3vIHni7zJ1nPGND6O rs3w== X-Forwarded-Encrypted: i=1; AFNElJ81PtKwrH72FSgkz9zgHKqiOjX9+R+d9ogsecD8hdkQNurqBl+oE2REl+qRfKiuuUiDQWKRWC8yhMnu6yA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2dGjQAM1+8dUiReb3XkTmyeizPa6aE6ZFHO62Dcvp68nj+pzC 7+aio0OT6P3v7+EqFGxn8yBxCUkJrQIMCwa6TOCN1+EeR7mn59gPT8LA5FnYzeZ+1uo= X-Gm-Gg: Acq92OFKdkGCwbXJxzT7hvvXiwURuuEs1i5DwEcI1XIR9tFCppOgHGtXlcXggMdKOya nupep3smT43HjlNK6X40IgaK/UukqQ93ZBRNpz2pA+AXBhFTof8AVYj9yBH/vqmgGXfdt6qCyvN zaCmNjiDQ/J4hhd3qQ3D4XzsN1zZGvWKLY7no778LiidQcEIeIdfCTiiBELeHZAGWEhRDgNXgu7 Fmd2lXctdGOCXQSRp/YUbJ6VntGTAX+k0Mxy+kOkMR+0d4M1p4puYQ36GiBvYhV6m8WWX/3Ryed zyw/0FV/TinNQcNdukE5kE9BQs+R2qv6MM9TAFtsNMjJfn9w+28vl0RPH7O1YlURRke/68SCCMt GTCDtG5VU+JE+fyDMBHA5fn0empmQ17UUNS2u0SVmyCDirfJknplemRfD3MU5I+yArIVQQQUyBG 3Afz0MQ2tTkyJdRX9al1xroukrNKAq+2ZHjHjggrHPW4eReMIzgekSslbNSfEsHdh5VH4r/6L6i 7NES+JwRpBN X-Received: by 2002:a05:600c:34c3:b0:48f:d0f7:78f1 with SMTP id 5b1f17b1804b1-48fe60e4e27mr391117575e9.4.1779283986137; Wed, 20 May 2026 06:33:06 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:dec9:6d:b572:fe67? ([2a01:e0a:106d:1080:dec9:6d:b572:fe67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490225bf8d6sm91045615e9.13.2026.05.20.06.33.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 06:33:05 -0700 (PDT) Message-ID: <7e80eeb5-68d4-435b-ac65-c9f4e00ad6dc@linaro.org> Date: Wed, 20 May 2026 15:33:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Maxime Ripard , Andrzej Hajda , Andy Yan , Chris Morgan , Cristian Ciocaltea , Daniel Stone , David Airlie , Dmitry Baryshkov , Heiko Stuebner , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Sebastian Reichel , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-4-javierm@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260519144712.1418302-4-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/19/26 16:46, Javier Martinez Canillas wrote: > Replace the driver local HDMI14_MAX_TMDSCLK define with the shared > constant defined in the header. > > The local define incorrectly referenced HDMI 1.4, but the 340 MHz > maximum TMDS character rate was actually introduced in HDMI 1.3. > > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas > --- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > index 0dbb12743609..37d8292b6f7f 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > @@ -38,8 +38,6 @@ > #define DDC_CI_ADDR 0x37 > #define DDC_SEGMENT_ADDR 0x30 > > -#define HDMI14_MAX_TMDSCLK 340000000 > - > #define SCRAMB_POLL_DELAY_MS 3000 > > /* > @@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge, > /* > * TODO: when hdmi->no_hpd is 1 we must not support modes that > * require scrambling, including every mode with a clock above > - * HDMI14_MAX_TMDSCLK. > + * DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3. > */ > - if (rate > HDMI14_MAX_TMDSCLK) { > + if (rate > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) { > dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); > return MODE_CLOCK_HIGH; > } Reviewed-by: Neil Armstrong Thanks, Neil