From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BBCA13A865 for ; Mon, 16 Sep 2024 07:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726472136; cv=none; b=qlARDvKxxaLvowFx8sYsbhsbkU8VH0VLZ55AIRJFL9mhOY2A/XnfyfvwpCXK1xDKR/AugF34if6wB+P7W7NY8nrDMbErb2BCLPGQss0eUGNobAIoZ5PuS9v0d+A1aHu6guvofYOWs6d/XW0SFcbZMDdqIDPqJkiDmnT7SwFS9Do= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726472136; c=relaxed/simple; bh=ELDAGEWFbIuabo50LtqwuRApSXREsRqoJ7re32LR5Pg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=fciQ+6UwczPgxcn54Pi8ui5h5MeUFhQPlm1T9SeKQw3rXUfzRmucoU7UjsIzqUgbIPICKKfFopQ15yCgot/JcmkmgGv84qZeJNzW4IYrqQlDLgrQ+5Q2wtgThI/UR2b500b+91pXdzeWhgYsW2M6XTOO1Z1UFC5G2sVAlqz+zT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jpawi1X9; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jpawi1X9" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-374c6187b6eso3120867f8f.0 for ; Mon, 16 Sep 2024 00:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726472133; x=1727076933; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=YOdceN0DS/wzREp2UcEaAzSKm4y+YZSwxFm6SuUMfwU=; b=jpawi1X9teLeOxOG9Jl+T5pWJgWj1jbBqZHCflHelbGbCGhpumFXisMPAp6c3ml3NE J+bRhRBMdDeO0nE5p1QraluzzQyOD4PmvdH9gN5VeDnDwRCuAd4RCAlCmp1+2gdg0GRN A0fnrV/TNV19to4g5MnV8EXyQQFktETsG2iY+YlhRnV46XEZl/vrN57r+wkFTFJkqETO qvJJqBE2AluvPwLN/qYxx2qRugK2aj45jdanBCwNoQQ2q0mVMJk/+VFMbT6VW+6TeRRE 39MXKux2OeTpukl2M2qt4gmlSYyf0HY88jYWxPr6SLX0Te4yG29gwc5o7NNFfvoAiQUE t/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726472133; x=1727076933; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YOdceN0DS/wzREp2UcEaAzSKm4y+YZSwxFm6SuUMfwU=; b=GG36vrQ+rR57UKeYXcBsJEM7DYGOpRCJVtKeD878KPyLI2yU4ridtZvk9ms8YQpu5L CLp6d/95Uner85Ju8C4NZvAEdQ/aXZed212zrCsA/VEVuf/bn9RrABV/OqGA4p5nPDJO r3ak0YmyZQbTDCOlDog16fBrxmXBs/1x/Lel3J9uOJnWiL+EKaAqadAqPkPYL1gnujeB t0HITPH8egjT57Yw1fwAROv9G4RizsF+/fr13tYklYRSPXZgpEx2PVeTEs7Kg1rgEKkJ iBufM2eNUrd/Fu+Wz/cn44MSWMkjlZjeh4eMbNSpSmytlNlXnsQtmCMJsqpZpQtTlnlZ MzcA== X-Forwarded-Encrypted: i=1; AJvYcCV3AQ869e8oa1QS+Gna3WABkTY2k1jawpo6PbqkIMo+1NG3UsAIYNcWCRsZgvnuvIthSZaBDQBe+D8Edms=@vger.kernel.org X-Gm-Message-State: AOJu0YxTpMx7crLR3SPd3DF6NbYu3g3/wm5j0msmFxWsYVI2DEtFwlsa Jd9TmKi7CFmUS9LiJ7UshJ/I8Zyu1/maD8dViIljzE834UVFIWkj9byIhKw92eA= X-Google-Smtp-Source: AGHT+IFtTDEFWVBXJac4ig3M604bac0B8FGKuMCE7pMZuhx+QezYxRXyYU8IXTUzNVsZ6dNXUoz7Xw== X-Received: by 2002:a05:6000:542:b0:374:c0a3:fbb1 with SMTP id ffacd0b85a97d-378c2d12e01mr7587179f8f.35.1726472132662; Mon, 16 Sep 2024 00:35:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb89e1fsm2378444a12.72.2024.09.16.00.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 00:35:32 -0700 (PDT) Date: Mon, 16 Sep 2024 10:35:28 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Srujana Challa Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , Vamsi Attunuru , Shijith Thotton , Nithin Dabilpuram Subject: drivers/vdpa/octeon_ep/octep_vdpa_hw.c:143 octep_process_mbox() warn: missing error code? 'ret' Message-ID: <7e8141cb-44e6-477c-b77e-aa9b4bc5af3a@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 98f7e32f20d28ec452afb208f9cffc08448a2652 commit: 8b6c724cdab85d8923dd8c474a5a9464228379c5 virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices date: 10 weeks ago config: i386-randconfig-141-20240912 (https://download.01.org/0day-ci/archive/20240916/202409160431.bRhZWhiU-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202409160431.bRhZWhiU-lkp@intel.com/ New smatch warnings: drivers/vdpa/octeon_ep/octep_vdpa_hw.c:143 octep_process_mbox() warn: missing error code? 'ret' drivers/vdpa/octeon_ep/octep_vdpa_hw.c:478 octep_hw_caps_read() warn: argument 3 to %016llx specifier is cast from pointer Old smatch warnings: drivers/vdpa/octeon_ep/octep_vdpa_hw.c:479 octep_hw_caps_read() warn: argument 3 to %016llx specifier is cast from pointer drivers/vdpa/octeon_ep/octep_vdpa_hw.c:480 octep_hw_caps_read() warn: argument 3 to %016llx specifier is cast from pointer drivers/vdpa/octeon_ep/octep_vdpa_hw.c:481 octep_hw_caps_read() warn: argument 3 to %016llx specifier is cast from pointer drivers/vdpa/octeon_ep/octep_vdpa_hw.c:514 octep_hw_caps_read() warn: argument 3 to %016llx specifier is cast from pointer vim +/ret +143 drivers/vdpa/octeon_ep/octep_vdpa_hw.c 8b6c724cdab85d Srujana Challa 2024-06-14 102 static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *buffer, 8b6c724cdab85d Srujana Challa 2024-06-14 103 u32 buf_size, bool write) 8b6c724cdab85d Srujana Challa 2024-06-14 104 { 8b6c724cdab85d Srujana Challa 2024-06-14 105 struct octep_mbox __iomem *mbox = octep_get_mbox(oct_hw); 8b6c724cdab85d Srujana Challa 2024-06-14 106 struct pci_dev *pdev = oct_hw->pdev; 8b6c724cdab85d Srujana Challa 2024-06-14 107 u32 *p = (u32 *)buffer; 8b6c724cdab85d Srujana Challa 2024-06-14 108 u16 data_wds; 8b6c724cdab85d Srujana Challa 2024-06-14 109 int ret, i; 8b6c724cdab85d Srujana Challa 2024-06-14 110 u32 val; 8b6c724cdab85d Srujana Challa 2024-06-14 111 8b6c724cdab85d Srujana Challa 2024-06-14 112 if (!IS_ALIGNED(buf_size, 4)) 8b6c724cdab85d Srujana Challa 2024-06-14 113 return -EINVAL; 8b6c724cdab85d Srujana Challa 2024-06-14 114 8b6c724cdab85d Srujana Challa 2024-06-14 115 /* Make sure mbox space is available */ 8b6c724cdab85d Srujana Challa 2024-06-14 116 ret = octep_wait_for_mbox_avail(mbox); 8b6c724cdab85d Srujana Challa 2024-06-14 117 if (ret) { 8b6c724cdab85d Srujana Challa 2024-06-14 118 dev_warn(&pdev->dev, "Timeout waiting for previous mbox data to be consumed\n"); 8b6c724cdab85d Srujana Challa 2024-06-14 119 return ret; 8b6c724cdab85d Srujana Challa 2024-06-14 120 } 8b6c724cdab85d Srujana Challa 2024-06-14 121 data_wds = buf_size / 4; 8b6c724cdab85d Srujana Challa 2024-06-14 122 8b6c724cdab85d Srujana Challa 2024-06-14 123 if (write) { 8b6c724cdab85d Srujana Challa 2024-06-14 124 for (i = 1; i <= data_wds; i++) { 8b6c724cdab85d Srujana Challa 2024-06-14 125 octep_write32_word(mbox, i, *p); 8b6c724cdab85d Srujana Challa 2024-06-14 126 p++; 8b6c724cdab85d Srujana Challa 2024-06-14 127 } 8b6c724cdab85d Srujana Challa 2024-06-14 128 } 8b6c724cdab85d Srujana Challa 2024-06-14 129 octep_write32_word(mbox, 0, (u32)qid); 8b6c724cdab85d Srujana Challa 2024-06-14 130 octep_write_sts(mbox, 0); 8b6c724cdab85d Srujana Challa 2024-06-14 131 8b6c724cdab85d Srujana Challa 2024-06-14 132 octep_write_hdr(mbox, id, MBOX_REQ_SIG); 8b6c724cdab85d Srujana Challa 2024-06-14 133 8b6c724cdab85d Srujana Challa 2024-06-14 134 ret = octep_wait_for_mbox_rsp(mbox); 8b6c724cdab85d Srujana Challa 2024-06-14 135 if (ret) { 8b6c724cdab85d Srujana Challa 2024-06-14 136 dev_warn(&pdev->dev, "Timeout waiting for mbox : %d response\n", id); 8b6c724cdab85d Srujana Challa 2024-06-14 137 return ret; 8b6c724cdab85d Srujana Challa 2024-06-14 138 } 8b6c724cdab85d Srujana Challa 2024-06-14 139 8b6c724cdab85d Srujana Challa 2024-06-14 140 val = octep_read_sig(mbox); 8b6c724cdab85d Srujana Challa 2024-06-14 141 if ((val & 0xFFFF) != MBOX_RSP_SIG) { 8b6c724cdab85d Srujana Challa 2024-06-14 142 dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id); 8b6c724cdab85d Srujana Challa 2024-06-14 @143 return ret; return -EINVAL; The other warnings are because we should use %p to print pointers. Depening on the .config the kernel will mask out pointers so that they aren't disclosed to the users. Otherwise it risks being an information leak to defeat KSALR. 8b6c724cdab85d Srujana Challa 2024-06-14 144 } 8b6c724cdab85d Srujana Challa 2024-06-14 145 8b6c724cdab85d Srujana Challa 2024-06-14 146 val = octep_read_sts(mbox); 8b6c724cdab85d Srujana Challa 2024-06-14 147 if (val & MBOX_RC_MASK) { 8b6c724cdab85d Srujana Challa 2024-06-14 148 ret = MBOX_RSP_TO_ERR(val); 8b6c724cdab85d Srujana Challa 2024-06-14 149 dev_warn(&pdev->dev, "Error while processing mbox : %d, err %d\n", id, ret); 8b6c724cdab85d Srujana Challa 2024-06-14 150 return ret; 8b6c724cdab85d Srujana Challa 2024-06-14 151 } 8b6c724cdab85d Srujana Challa 2024-06-14 152 8b6c724cdab85d Srujana Challa 2024-06-14 153 if (!write) 8b6c724cdab85d Srujana Challa 2024-06-14 154 for (i = 1; i <= data_wds; i++) 8b6c724cdab85d Srujana Challa 2024-06-14 155 *p++ = octep_read32_word(mbox, i); 8b6c724cdab85d Srujana Challa 2024-06-14 156 8b6c724cdab85d Srujana Challa 2024-06-14 157 return 0; 8b6c724cdab85d Srujana Challa 2024-06-14 158 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki