From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD31535C6BA for ; Thu, 20 Aug 2026 14:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236470; cv=none; b=cOwjj3SRyDb+yZG1Svabf2bzB8/Ssaq2Hu0L0CKFmh9ckqZFyaETwRDfhGQ+GrNnYELnXCeXsO1f42/XjuMyIkL3zajp9XfQD8anm+uLRVokcs7jU3aliK/ZJihs8aQ8JMdYjd/Aaiz5ElYov2IpTpSVVNEKkgnSzCGSmM32iT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787236470; c=relaxed/simple; bh=3k1krIsMjL8C9GSdXhNuqALrM8YcwXNu8Ii/KMmkoXQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Eymiejm6FtRD8AyOXSdfgH1PTedYlxADF4egZLBgbW9D5ae3jX+JXjPxg45PpWTYSjZOJ06p7MfJQNAfpnHT/PpPAdyibKi8zDlGa3AuknkCNSu15UjFEFd8hUncUsP8AR7UVl1CmYKhtlVHRayk4czFukuUsFTRn2JS/YlO38Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O1LAclDG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q/ZQzwkW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O1LAclDG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q/ZQzwkW" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67KE7mhE3220229 for ; Thu, 20 Aug 2026 14:34:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VH7OWd4qs6XPQgmtcdGTxRGr3GR0uOZKsVeHDZny3jQ=; b=O1LAclDG/UtSGOER 3KHnOA56eh7kqRlwRREKVigXp7MWDNYjGDvIK2qeuMlxluVaukaukBfC/ANO0t4y kSl4nl+1rjKv9TkAOlCZ418PRrU5YmG4qbHRH8CifkHbzOTu0PKTI06hRX5UiaRG 0XRy6R/eHN3id/ujY03SvlNJd6/vvoZ6fQRY4uRj6z/MJ+r4FmklQ1w9HpC4DvGX +piO1lfrUyt6Fvsy7CdyUYyiIleZdu2I+aKL1jXesfnIRoQhy8XWAvB9mBrO9LS+ 6KFBT9pPQN61u2zJ7+pZC3TVKsckHfIrdM0D4NDX/U211GmX2ScyzNXhEz6aS8xA 7D2YEg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5x29hg2w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 14:34:27 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936cadb0e8bso198561185a.0 for ; Thu, 20 Aug 2026 07:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787236467; x=1787841267; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VH7OWd4qs6XPQgmtcdGTxRGr3GR0uOZKsVeHDZny3jQ=; b=Q/ZQzwkWTaC/34LJZzzl/QVKq3DjRYtVkD9kGQTZuTgDc4YlAK0WYg00Pxh6CTtjaN jVuFrc0gHUU8GLC/WzAg5GxxPGUixL4wpwtXrKYptfJljLJo/VixQ/gEuydmt5yTCn+H sr7iEeRcvENvvoHKhvnYkxRFFPTtaUWad6OXHlE4xXhQ4Pqsgyig9pWZdvX0ma2gucLV HwR/4u2jlstDfJ/Umh79ldyohYKV2xs62DOB/I6hGii1ClWcqyeJGBW0jWP81PApnUPJ tIvzdzfJehQX2Fkx9QpMyZBE6FjUTu3v5wQrufgBw3Ndv7c/zBUlMm+gWB3fRJyt60CE TZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787236467; x=1787841267; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VH7OWd4qs6XPQgmtcdGTxRGr3GR0uOZKsVeHDZny3jQ=; b=K9eb15DnRFTtrQZpq74bX+z9SJpbGFE6HSbHSPBpyjqbOOJGJNtF49R9J9IkWcwbUp pARC3QJ19t6PqHrwv4jCO8YW0E0sMtoOisbuiccJfEz9t7vNb/P+wHsqSSHNQr/9CQ9R Rcns1NkOFvTK8U+f6Fjq+GjGkKQhwUC58Xvdq81HbYbuPpnxKxxK6chmO+rhHhP/dkWg j5YSi3bhUIveJd+F4lgI7cLuduK5F3WfwLzUV6UxHzo9fwDnrk1dz5qDPaS+urEqTTGo CLhkKxtQQP08Bsliw09No7CCcLp1WbrgXvT//HWqppBfu/dGd3xXbX07REwKV5cwUwZr 25eA== X-Forwarded-Encrypted: i=1; AHgh+RpbGDr8zZqoNU+Q6tgRyLYb9tMrMNY2NzkqErBKaI02nUde8pXC0KbhR3HPKRg5raC6L1NAtku2DxsCYk0=@vger.kernel.org X-Gm-Message-State: AOJu0YypGa+Peq0qsEchiMeMB+okd66azSXPdzcUPCV1sJ35vwrFMEE9 oB0lpe5xVC5BOfDjEMiVxbsoMinzfUnLjhXcls2490AXl5OgYYuOvUbTXaZ8GZ6HRb58W391GBb P2ohKrKDB8xEIlxCXNxsYqFYnzv8gYuj9G7Lthrz9h4cLny+CAetQeXbEXrp6sM9Tpig= X-Gm-Gg: AR+sD11S9ygP6nmkx3h1KtwBvu0oFkGKcj8kgnQ5S0Sz93QzKZDpQx2RnFUEBfwUNFB jEApeKj3AzFZZ9RIKzjlhP61owzoomXtLasQVdxvjcowKcW8NBos+SMOIE+sd8pAOCTDkiMQ3Zo qS4ca+JooBQtv4XDgl72jzg7AtEk7Jgd39Y0pB2daY6FPI7JPkFw+ivFmj0FlUhQr0jUsDqVdQl KCylkaY7iDBnK2CoWCbiN3mrqo6QJ0ccnUrUBiXdaEMGBKcoqzpBbo9vNxpfxHXbAwue9N2jYHJ MfYYcMCoaWbDsCHZ3XRUH9cr3hrD+yQrkOtN1zTDEqqsO4NwIbv7tSrTmLQesK3ty3LldXfCI1q /d6r9CM8x1lDOpFBcrud8M1qqFg3NXylC X-Received: by 2002:a05:620a:7084:b0:936:695a:185a with SMTP id af79cd13be357-9371e744119mr1175190385a.44.1787236466626; Thu, 20 Aug 2026 07:34:26 -0700 (PDT) X-Received: by 2002:a05:620a:7084:b0:936:695a:185a with SMTP id af79cd13be357-9371e744119mr1175180085a.44.1787236466068; Thu, 20 Aug 2026 07:34:26 -0700 (PDT) Received: from [10.218.4.101] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14b802dsm11919279f8f.17.2026.08.20.07.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 07:34:24 -0700 (PDT) Message-ID: <7e863f09-473a-48bf-bc2d-c7a8122b27bc@oss.qualcomm.com> Date: Thu, 20 Aug 2026 20:04:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: geni-se: Fix write to read-only firmware buffer To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Mukesh Kumar Savaliya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260819-fix-write-to-read-only-firmware-buffer-v1-1-be86532fe122@oss.qualcomm.com> <3b924a67-a229-4836-abc9-0985e3e10d4d@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <3b924a67-a229-4836-abc9-0985e3e10d4d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PsFtCfwOP1rLULwysLGpSFR43GLCczRk X-Authority-Analysis: v=2.4 cv=V8BNF+ni c=1 sm=1 tr=0 ts=6a871073 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=-BkaF7zFfwnn-ZNdrDEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDEwOSBTYWx0ZWRfX0Q7T/NrqJTIO 9B78A3c1gcyu9waBJ4Tf3KwVn+7qQG5cBBB9qitVYtznYy4MydTQYhpGxOXcj1SkeRU/67JaAPv 6ZwsHoersnD+b81nmcidYvyCqT/jZg0YgDZLl9zT2KwGOxBj3EwWO42XzsKvUBs21b+9D3CXNzk bMiwqilZUQiczwcaZq6t49SxG2Gy8uGgMMtiHC5wCsJbQGX/mrZseLSVmCUhINsIJX+g0rGYBbR JMcotHGTHTSPz0dE27s1PLkY/Y9Y1piYkuoYinuoCy6zTTW6BtUTLcPhNRLfhdSBDnhwSNZrXcj 3dDV04NvFFa+UMVW0Vc3HZ8mSg51nOfSGmFpmIiNmFYUK8ObHfD1IVKh4jcc18zqa5eJ6N3BLvz J5XWEZjKkTfgnEPRU7HVStrs+xaj+2MtmlUivZSZVwiQn8PSjCsB0b6X8R/ErJhEHQuiSyD+ZN9 LFrOs+HSC4KpxVO40ow== X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDEwOSBTYWx0ZWRfX3RqucLV+mgKp jayfrbkPQAzx8mEjX4QhRt2UKcdEZ9NBHHRsNOJ+bCrkFGAD1cKVmGBUIWNMTczs23UNbmhFZoe YWi+X4uqRlfaz6hNa5ZJ9A+/O3ouit8= X-Proofpoint-GUID: PsFtCfwOP1rLULwysLGpSFR43GLCczRk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200109 On 8/19/2026 6:44 PM, Konrad Dybcio wrote: > On 8/19/26 12:14 PM, Viken Dadhaniya wrote: >> geni_find_protocol_fw() casts fw->data to a non-const struct se_fw_hdr >> pointer and writes back a rounded-up fw_size value: >> >> sefw->fw_size_in_items = cpu_to_le16(fw_size); >> >> The firmware subsystem maps the firmware blob read-only. Writing through >> the cast pointer causes a level-3 permission fault on AArch64 and >> crashes the kernel during driver probe. > > Bug 1 > >> Remove the write-back. fw_size is u16, so incrementing 0xffff wraps >> to 0, letting the bounds check pass for an unchecked size; widen it to >> u32. The bounds check used the unrounded fw_size, so a segment with an >> odd word count can pass validation but trigger an out-of-bounds read >> during the copy; > > Bug 2 > >> round up before computing fw_end. The caller re-reads >> fw_size_in_items directly, bypassing the validated value; propagate it >> via a new fw_size_out parameter. > > Bug 3 > >> While at it, fix serial_protocol being compared with le32_to_cpu(); >> the field is __le16, which would cause the protocol match to always >> fail on big-endian. > > Bug 4 > > Please split this up Split into four patches in v2. > > Konrad