From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EC2A34D4D6 for ; Thu, 23 Jul 2026 21:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784842966; cv=none; b=fQ/VgwaCQygjNFke3gxMGjsCMK60n0rBR9yv8n7d3B5DyJD3O5g9HvRiUqXw+vmUDNvS7ttmTLa6ttA+rbpWiAt0hgTnxspePi/bzNWvdpQEmHBtFY/JzKHH/31I2uSbpwjSiqeyQWh3Nbj+9u9IrQ0Igm7obid7FjiTsAyZB6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784842966; c=relaxed/simple; bh=cMVH30seVxDqGNU+JXO7CI9A1iWOcqfw3kUyY5cSpXw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G59E+1RZwUEOuQVyrEEaHcPbkBi4Os8cGZ7B5ZsHVufGPZVkhytypnfNb8CavyKrpUFV7rcuMKAZYt/CkVZ9BcY8rVUBRMTCScdQC4BF71Q/c8RRDCBSxIXA65jzK9BH9pmgCiD95xWR6cGXG81koPKTZOhLRIahzTIk8xbPpTo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GX/8PCT4; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GX/8PCT4" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8486672f03cso1188943b3a.0 for ; Thu, 23 Jul 2026 14:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784842964; x=1785447764; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=IPzjE3FNOTGqvDB3QZeC9AMUwCIrsHLR+NHAqkuuNKg=; b=GX/8PCT4gj44Hoz7vIJxUbVp28tJd0yDDNPY4GD83psjqXwEta24C5bviRZYCwFaei E91nBXJWb7sv3khiPzJ1cmjZeBcHDPbGc1nhFbw3m/sKbhITGco+dSEJAsE8uQ+JGo1R b1ZS9n6o0ANZA8HGrIRK8e57evntrGmHWRiINx1kNlPVGIKte8jzJZQW1RWi3hBaK6Zb 0XqW8xqEF88ikau0EV3oyl7FvLgGgio2s4/aEzzvga/TDoOFQ+/9WU6JZgWv7bEc1Und 8t/hBcl7zH2UdzG2MC1axazphFnVQK8yxWhIpmwGf2Rsq9q8RhObZFsuHcyXX1lBtq+H MBHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784842964; x=1785447764; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IPzjE3FNOTGqvDB3QZeC9AMUwCIrsHLR+NHAqkuuNKg=; b=dGe32hhrvKunjrbpN6YdDwXUrj1AInXjbqwhTf4VGxg44LECIcrH6lCqjQAeRnosIN ovoF80TMyeN6VQP4zwPHpf6AjekpwTlNmpkPMRqhTuh+2DVAj+0DK48FX3Khfk4kqSe0 OIpqDxhoguoMIZLvC6sol/Yaq15JaHi3WUPtWwSYiHb62yPv0WqtHYisn9DPKrXI0TCf tlo+xq6lF8z0VNyKCK8kCH+3xL1d4tXPFcNLyWkWp+QXMCwbuTpc0rqQlo0Hkcsa06HY aBFPmRkC1/p4zhytLe1zAt26IJGcVI92TYjmfm9lsGQyMaL5osSVvi8SoEn9llzZS+LH DAyQ== X-Forwarded-Encrypted: i=1; AHgh+RqwyfldfwM7+iOh5J3KSpga57V4ZQ/O3OtVokMiLVSq9L0HBUAQngMeYIsIjfVLkCVTGutlo80eKUFIEPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3zuo+Ue1nx6v/ewQ7fXGNSj6iaNDG9TMokIIam9MFD/h5NuUZ 1AtIL8I3RT8iGUT85Tkf3XHcCc1Z0YXbYjJ1drz8HOcdExIHij2jRamu X-Gm-Gg: AR+sD11q8SFIu0FE5GyOiRaHo+JQxW0E9d7zyniAO1j5uEiMdt52tpq3oTjEDrw8Q3a KWJdJ5WPSa/6D8UbUxBPxfl2Cu7M8kaWBuTZzEFIbWmoBMCyoY+XHxR4bAO9onHvujX2ik6BFcn 7YxIsJmz90XcWHOPL5t5q3FpyB/peYDlhh2ypBoLpxGxsz9O2cuOufJ/UubcSxgcCaS63j/luzq Y52V/iaFInTQl/hIda9nSH/JDEF2NZ6TJ+0ZC/cYH8QXjbTmxdiZefISgz1TAq/24342gEGdY6h RTS/yvVmGwEwK0Lgk0AXh40JGHHiKUyM7sL/znnuJNUgcfP20m9E9JcRjs/Au1qsKPinOCeMMnQ oxOyv+KbkIHIL0A6ewRq1D5FzNdoyB048G88uVQaQZNxNknHoVibJpg9KV+JnqamLvwzgDhnEu3 fkbcr1rPqwfNMYTAo= X-Received: by 2002:a05:6a00:3c94:b0:848:4859:a45 with SMTP id d2e1a72fcca58-84e2b7ca651mr5747181b3a.2.1784842963810; Thu, 23 Jul 2026 14:42:43 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17237c32sm3663216b3a.6.2026.07.23.14.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 14:42:42 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 23 Jul 2026 14:42:42 -0700 From: Guenter Roeck To: kr494167@gmail.com Cc: nuno.sa@analog.com, linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: ltc4283: add missing MODULE_DEVICE_TABLE for OF match table Message-ID: <7e86e321-aab2-460c-a864-e6aa7c108bab@roeck-us.net> References: <20260721055022.34629-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721055022.34629-1-kr494167@gmail.com> On Tue, Jul 21, 2026 at 11:20:22AM +0530, kr494167@gmail.com wrote: > From: surendra > > The driver registers ltc4283_of_match as the platform driver's > .of_match_table so the kernel probes the device when a DT node with > compatible "adi,ltc4283" is present, but the corresponding > MODULE_DEVICE_TABLE(of, ...) call is absent. > > Without it the module alias table (modules.alias) does not contain an > "of:N*T*Cadi,ltc4283" entry, so udev / kmod cannot auto-load the > module when the DT node appears, breaking modules-based deployments > while built-in configurations happen to work by accident. > > Add the missing MODULE_DEVICE_TABLE() to fix module auto-loading. > > Fixes: dd63353a0b5e ("hwmon: ltc4283: Add support for the LTC4283 Swap Controller") > Signed-off-by: surendra Applied. Thanks, Guenter > --- > drivers/hwmon/ltc4283.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/ltc4283.c b/drivers/hwmon/ltc4283.c > index 9b85293ea664..9ec409bc2648 100644 > --- a/drivers/hwmon/ltc4283.c > +++ b/drivers/hwmon/ltc4283.c > @@ -1772,6 +1772,7 @@ static const struct of_device_id ltc4283_of_match[] = { > { .compatible = "adi,ltc4283" }, > { } > }; > +MODULE_DEVICE_TABLE(of, ltc4283_of_match); > > static const struct i2c_device_id ltc4283_i2c_id[] = { > { "ltc4283" },