From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH] lib/crc: arm64: Drop check for CONFIG_KERNEL_MODE_NEON
Date: Tue, 17 Mar 2026 12:09:42 +0100 [thread overview]
Message-ID: <7e88b710-2302-4b7b-8f11-4e25088bb3c7@app.fastmail.com> (raw)
In-Reply-To: <20260314175744.30620-1-ebiggers@kernel.org>
On Sat, 14 Mar 2026, at 18:57, Eric Biggers wrote:
> CONFIG_KERNEL_MODE_NEON is always enabled on arm64, and it always has
> been since its introduction in 2013. Given that and the fact that the
> usefulness of kernel-mode NEON has only been increasing over time,
> checking for this option in arm64-specific code is unnecessary. Remove
> this check from lib/crc/ to simplify the code and prevent any future
> bugs where e.g. code gets disabled due to a typo in this logic.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next
> (https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next)
>
> lib/crc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/lib/crc/Kconfig b/lib/crc/Kconfig
> index cca228879bb5a..52e216f397468 100644
> --- a/lib/crc/Kconfig
> +++ b/lib/crc/Kconfig
> @@ -46,11 +46,11 @@ config CRC_T10DIF
>
> config CRC_T10DIF_ARCH
> bool
> depends on CRC_T10DIF && CRC_OPTIMIZATIONS
> default y if ARM && KERNEL_MODE_NEON
> - default y if ARM64 && KERNEL_MODE_NEON
> + default y if ARM64
> default y if PPC64 && ALTIVEC
> default y if RISCV && RISCV_ISA_ZBC
> default y if X86
>
> config CRC32
>
> base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
> --
> 2.53.0
next prev parent reply other threads:[~2026-03-17 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 17:57 Eric Biggers
2026-03-17 11:09 ` Ard Biesheuvel [this message]
2026-03-17 16:31 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e88b710-2302-4b7b-8f11-4e25088bb3c7@app.fastmail.com \
--to=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=ebiggers@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®