From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753890AbdDNJVM (ORCPT ); Fri, 14 Apr 2017 05:21:12 -0400 Received: from mout.web.de ([212.227.15.4]:59114 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbdDNJVK (ORCPT ); Fri, 14 Apr 2017 05:21:10 -0400 Subject: [PATCH 08/10] pinctrl: imx1-core: Use kmalloc_array() in imx_dt_node_to_map() From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Arnd Bergmann , Gary Bisson , Laxman Dewangan , Linus Walleij , Paul Gortmaker , Peng Fan , Shawn Guo , Vladimir Zapolskiy References: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <7e8a5c9c-aa4c-0675-3690-dfe1fed56915@users.sourceforge.net> Date: Fri, 14 Apr 2017 11:20:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QlxrN9fvZjREXGGwrN9u0WDAx6oQPBFLaO5emvMA88G/FB78Frg uWTGSuFGa1ni2ETlwnab36he7WNH7z8+0WL3ShK0TRvODiX+oqaQzpMaizR9h1ACYpOc7TV Nrh+Mg8b9mutL5jMrhFtQe1OAF+uFJg4sQFhIygy395lk6nrjhiZv+//qjkEXoIiE9n1BbC pn2r+BYi+NQ8vuvFjuo5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:T/k3ouKkc3M=:ZH6Eg5tX3001+xJmtl/7vq 66CWF7L+g/t6x3/cW030YnnuWYnV9xBpYh0FbGxFCoIRu8Ht77hEDwDhLEf0PhpYgah2tKB2z rKOr+6hLq0xAooEJYowxgb5x7DLxByKrELTLX0fKeY8tiwY7XX4UxrkXIwsNXnrM+4eBpv31S xGX9r17b0hGbU95V9QDRCQnPV8znLgVeqU2YKs7Wrm0d3UmD4D4/Qymieoo1kBszGmy1/tKUK atHT/JyfRkvp2Jk9zgG6AwlTe4s4gOFNpXShUt2/e/G3UOEh6ERpzG7TnSuOSKnZjbdNBOqTj dCwRQF0JIptDyU4A3+J/bQn/hUWsEXjkC5scBJOTjoWt2RZDaC+I2KO+++E/SyhYRT1sF52/I wdUrkoy6Dkmc7U48nySuqbxiywdYlklJKR2AvfGhgmLwj51fHLIJ04Aw27Za7W1WiBBrXke26 e56Gjtu9CIEte3cKfFE3GA5fRcu0K29v4jjWF0Y17YAwkeOuU3R4AHFot0OhD1lnC4KNoV/4x 7tzTGSOpnF85d0uPwTzCC0+i5we1i1dZcDwnaUHrR7YQem325/nvwRUvNlu1E0WyLXy8fdLCE +Sji1r5Kpgt1ZSCW7VGv9dd92kJz/wB3XDDC2h1JB5B987NBf2SW47DnNFV4WQ52Lz6K1ihnV 3W/Vxa3dKNQXe1g3j5ZC5MaAVO9ZWf+sbQafxKQJCWu5cd+6mlVtnM/Fk8YJzcWxZkLUutfqY 665cFK7DqVVKfzRfboasGQHqHc0y8uQFdr0cj9W6BdkplitQUIQ0/3qX4GqGrKefgZiXh/JfN +XAOdmb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 13 Apr 2017 16:10:33 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c index a4e9f430d452..5a0d221ed09d 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c @@ -246,7 +246,7 @@ static int imx1_dt_node_to_map(struct pinctrl_dev *pctldev, for (i = 0; i < grp->npins; i++) map_num++; - new_map = kmalloc(sizeof(struct pinctrl_map) * map_num, GFP_KERNEL); + new_map = kmalloc_array(map_num, sizeof(*new_map), GFP_KERNEL); if (!new_map) return -ENOMEM; -- 2.12.2