From: Jiri Slaby <jslaby@suse.cz>
To: Nikolay Borisov <n.borisov.lkml@gmail.com>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Adam Borowski <kilobyte@angband.pl>,
Nicholas Piggin <npiggin@gmail.com>,
Omar Sandoval <osandov@osandov.com>,
Michal Marek <mmarek@suse.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [GIT PULL] kbuild changes for v4.9-rc1
Date: Sun, 18 Dec 2016 16:08:10 +0100 [thread overview]
Message-ID: <7e93909c-d2ab-a07a-c2ed-cdb1c44937d0@suse.cz> (raw)
In-Reply-To: <eff67256-ea61-ef88-251b-b67fcf6a9538@gmail.com>
On 12/18/2016, 03:54 PM, Nikolay Borisov wrote:
>
>
> On 18.12.2016 16:45, Jiri Slaby wrote:
>> Moreover, with some modules, __put_user_1 and others are reported
>> instead of mcount.
>
>
> nm vmlinux | grep __fentry__
> nm vmlinux | grep mcount
>
> What do these report ? I bet you that in your vmlinux the first one
> would return something like :
>
> ffffffff822f1810 T __fentry__
> ffffffff827fdc20 r __kcrctab___fentry__
> ffffffff82809461 r __kstrtab___fentry__
> ffffffff827e6c20 R __ksymtab___fentry__
> and nothing for the second. Whereas doing nm on the module in question
> would give nothing for __fentry__ and something like: U mcount
Well, I have just won a beer:
$ nm vmlinux | grep mcount
w __crc_mcount
c0b3bd34 r __kcrctab_mcount
c0b41692 r __kstrtab_mcount
c0b2dd04 R __ksymtab_mcount
c0896130 T mcount
c0c9ee20 T __start_mcount_loc
c0cba89c T __stop_mcount_loc
$ nm vmlinux | grep __fentry__
$ nm sound/soundcore.ko | grep mcount
U mcount
No, I am really not stupid. We compile the kernels like this for over a
decade and it really broke with 4.9. Applying the patch fixes the
problem. Reverting it, makes it recur.
regards,
--
js
suse labs
next prev parent reply other threads:[~2016-12-18 15:08 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 6:51 Adam Borowski
2016-10-17 6:59 ` Nicholas Piggin
2016-10-17 10:01 ` Adam Borowski
2016-10-17 11:12 ` Alexey Dobriyan
2016-10-17 11:17 ` Geert Uytterhoeven
2016-10-17 11:32 ` Alexey Dobriyan
2016-10-17 12:22 ` Mathieu OTHACEHE
2016-10-18 0:16 ` Adam Borowski
2016-10-18 1:34 ` Nicholas Piggin
2016-10-19 14:38 ` Michal Marek
2016-10-20 3:52 ` Nicholas Piggin
2016-10-27 8:10 ` Kalle Valo
2016-10-27 11:15 ` Nicholas Piggin
2016-10-27 13:14 ` Kalle Valo
2016-10-27 13:25 ` Nicholas Piggin
2016-10-30 10:51 ` Thorsten Leemhuis
2016-11-01 15:48 ` Michal Marek
2016-11-02 12:11 ` Adam Borowski
2016-11-02 12:14 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for x86 Adam Borowski
2016-12-16 19:55 ` [GIT PULL] kbuild changes for v4.9-rc1 Jiri Slaby
2016-12-16 19:57 ` Linus Torvalds
2016-12-17 8:57 ` Jiri Slaby
2016-12-17 9:33 ` Adam Borowski
2016-12-17 23:59 ` Linus Torvalds
2016-12-18 10:49 ` Jiri Slaby
2016-12-18 11:03 ` Arend Van Spriel
2016-12-18 13:27 ` Nikolay Borisov
2016-12-18 14:45 ` Jiri Slaby
2016-12-18 14:54 ` Nikolay Borisov
2016-12-18 15:08 ` Jiri Slaby [this message]
2016-10-17 12:26 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM Arnd Bergmann
2016-10-19 14:52 ` Michal Marek
2016-10-19 15:02 ` Arnd Bergmann
2016-10-19 15:32 ` Russell King - ARM Linux
2016-10-20 4:08 ` Nicholas Piggin
2016-10-20 13:17 ` Russell King - ARM Linux
2016-10-20 14:20 ` Nicholas Piggin
2016-10-20 14:33 ` Russell King - ARM Linux
2016-10-20 14:51 ` Nicholas Piggin
2016-10-22 19:51 ` Michal Marek
2016-10-24 15:04 ` Arnd Bergmann
2016-10-24 15:05 ` [PATCH 1/2] " Arnd Bergmann
2016-10-25 8:32 ` Nicholas Piggin
2016-11-20 13:21 ` Russell King - ARM Linux
2016-11-20 18:32 ` Linus Torvalds
2016-11-20 19:12 ` Russell King - ARM Linux
2016-11-21 6:10 ` Nicholas Piggin
2016-11-21 18:46 ` [1/2] " Uwe Kleine-König
2016-11-21 19:13 ` Russell King - ARM Linux
2016-11-22 1:01 ` Nicholas Piggin
2016-10-24 15:06 ` [PATCH 2/2, variant A] ARM: add hidden mmioset/mmiocpy prototypes Arnd Bergmann
2016-10-24 15:06 ` [PATCH 2/2, variant B] ARM: move mmiocpy/mmioset exports to io.c Arnd Bergmann
2016-10-20 7:37 ` [PATCH] kbuild: provide include/asm/asm-prototypes.h for ARM Geert Uytterhoeven
2016-10-20 8:20 ` Russell King - ARM Linux
2016-10-20 8:23 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2016-10-14 20:12 [GIT PULL] kbuild changes for v4.9-rc1 Michal Marek
2016-10-16 0:22 ` Omar Sandoval
2016-10-17 3:57 ` Nicholas Piggin
2016-10-17 6:57 ` Mathieu OTHACEHE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e93909c-d2ab-a07a-c2ed-cdb1c44937d0@suse.cz \
--to=jslaby@suse.cz \
--cc=adobriyan@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=kilobyte@angband.pl \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=n.borisov.lkml@gmail.com \
--cc=npiggin@gmail.com \
--cc=osandov@osandov.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®