From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A687C77B61 for ; Thu, 30 Mar 2023 07:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbjC3HgV (ORCPT ); Thu, 30 Mar 2023 03:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbjC3HgN (ORCPT ); Thu, 30 Mar 2023 03:36:13 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B02755A6 for ; Thu, 30 Mar 2023 00:36:09 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id g19so10241302lfr.9 for ; Thu, 30 Mar 2023 00:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680161767; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=76aJWbUWsdK9RGoxvHvablA/jheCBXLESrz/qwRI/4M=; b=xNA+hiC1s8qd6uyQFCaLtk65m2NO3EmHH/YxypEzDyl3LtCIU+3wrZD1iK0aFIdkwA mIAHFZAkJwfCPi9dGS6L5U0ZqH94ElOiJ9cj+90WPBalORBXyCnKKrJBX/j7qahJCzRZ PxE8ZLWGEdrWTS9Fm5yz0CKndLiEjtL2LdWahblUL+kW1CkOvxrXkuMBUfzRmwFdml7G y5SFxV1NAaaKglxLMbcrWuX9nicH7w+TCHeWjNUe36T6arnGp4AClzqrxy01iR0cvz/m qmESakOVTb6yrTKCcQLBzIsJegnV5JESMug3NG60/CweJPP0oh3V76A5Z0ABick8eVQe mW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680161767; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=76aJWbUWsdK9RGoxvHvablA/jheCBXLESrz/qwRI/4M=; b=dsoqQ3/OJEiTtvt+ofA+BiO2th89wCRL1e44OLVL6xspXILUozwTClRgDjP7/xBwjO XuMWVE4JULG/ku9gJWX2e2GUU4dhW+Phqp8CgNbhhAaojYtF7s0W+nuGjeBq/vvm4WUC c8WjuIti4mTCnWsuqpcJrW4TlYaQWiWHqOYxnUUmqp2qdwm+w9JugsUINIwx8QZxz634 0sFZgCOu3oNLX3ZvQN7XCSd5SSHWUiHzKNh+ClMf26yRq9ykt4GX2P+t9ZavW5kHVTEx QDiXJuZIo1c7w0iwa8oQwkeUtrfn8HAVt6EfGiWg2zZt8KtzhQI4j5Sjp5Xcawvrkq5K pcSQ== X-Gm-Message-State: AAQBX9e4lxSdoTbYgHF5X7pNj179IER0LOoER/ed+JvPjfLo3l5b2o5I PpoKMp56L9bLb0egnoYMLXCWYQ== X-Google-Smtp-Source: AKy350azUAlNkIGGkonG3ti8573pFtntXxPHUEJSCWt7ET2qDNeE1BbTm2NDbr8OkWmpoUkzfHomBQ== X-Received: by 2002:ac2:48b4:0:b0:4de:7dec:ca34 with SMTP id u20-20020ac248b4000000b004de7decca34mr7049792lfg.48.1680161767681; Thu, 30 Mar 2023 00:36:07 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id x3-20020ac259c3000000b004db2c5c895bsm5722965lfn.234.2023.03.30.00.36.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 00:36:07 -0700 (PDT) Message-ID: <7e93c0c9-0a84-c1ce-a978-c4743963012b@linaro.org> Date: Thu, 30 Mar 2023 09:36:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] dt-bindings: mailbox : arm,mhuv2: Allow for more RX interrupts Content-Language: en-US To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, nicola.mazzucato@arm.com, Tushar.Khandelwal@arm.com, viresh.kumar@linaro.org, jassisinghbrar@gmail.com, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org References: <20230329153936.394911-1-cristian.marussi@arm.com> <20230329153936.394911-2-cristian.marussi@arm.com> From: Krzysztof Kozlowski In-Reply-To: <20230329153936.394911-2-cristian.marussi@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/03/2023 17:39, Cristian Marussi wrote: > The ARM MHUv2 Receiver block can indeed support more interrupts, up to the > maximum number of available channels, but anyway no more than the maximum > number of supported interrupt for an AMBA device. > > Signed-off-by: Cristian Marussi > --- > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: devicetree@vger.kernel.org > > .../devicetree/bindings/mailbox/arm,mhuv2.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > index a4f1fe63659a..5a57f4e2a623 100644 > --- a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.yaml > @@ -69,10 +69,15 @@ properties: > > interrupts: > description: | > - The MHUv2 controller always implements an interrupt in the "receiver" > - mode, while the interrupt in the "sender" mode was not available in the > - version MHUv2.0, but the later versions do have it. > - maxItems: 1 > + The MHUv2 controller always implements at least an interrupt in the > + "receiver" mode, while the interrupt in the "sender" mode was not > + available in the version MHUv2.0, but the later versions do have it. > + In "receiver" mode, beside a single combined interrupt, there could be > + multiple interrupts, up to the number of implemented channels but anyway > + no more than the maximum number of interrupts potentially supported by > + AMBA. Last sentence indicates that TX mode has something else, e.g. max 1 interrupt. Either correct the sentence or add if:then: narrowing it for TX. Best regards, Krzysztof