From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C7B32AAC2 for ; Wed, 24 Dec 2025 08:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766564657; cv=none; b=nYdZ21T/ij348CsEpD0XGQ5OePMqdF+q3NfGqzQR6f0MaYqflTUKUqNIPb9SOt4PnDWRV4bXvH8NReQaZrB9L5FGiAeuB6z7shmwhjXut7K6/Qg6mggS/b9I0w2swH+XHz+9w4Ob8v8IftS6tKKGvs+h2NiGycW2Hj5znoOaBNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766564657; c=relaxed/simple; bh=2afYR+QPHTFaaxhOoQKgqdK4lXJQ8ziaCl7IQD08vVU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bPysJe1r13pnT4Qw6ksBGLnFVbL/d2FG/r9CBYdoStZrefYkyEcni2PVhzLdnvboFZIFzBXWAbhl9ID8OjjvwoKbjdSrhCvT3GHcLs6BiD1uxnIKToCflzj3iEUkPTICe7iWfUJvVxCIq3cxaPNQF6pp+QVLj7+GLMKdGxSTw4E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FIP3jSsC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jSXUp63L; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FIP3jSsC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jSXUp63L" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BO7IlsQ678224 for ; Wed, 24 Dec 2025 08:24:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= amWwOEekimBMh3/UGtUq5nDhhjd4Nl657eBMQHZc8lA=; b=FIP3jSsCC5K2aUcz qQq9mYn0YnSpRFIufdSUDbG0vrRz2/QbpLYNzMSJSEG1JvQwke5qJ9gnYwGeoF6p zl60iIeXpvTVkwmG2MW9sQB5XjJ7auPyUwG/PUoIIzoWtjruYKtmOxPWx64k6ahf hdD4ZZ3YcyVtXf/0kU4hXD/0P6pmCbHDfFNZiScbb1GGeYfSv1D4V6YIV5BKwbza VBwbw58aPsx+M5qsyrbRcJP3SQoxTRcqaGY56LSXOeLZBjJPXOO7mO78rnmvNrTg D0yG5eZU/TcuQ2qinYDeBPV8Xh6G9L+DhP2l5ExIAJAVo3EdZ8AKY9weLlYAMD7z h4t8bQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7yvq2177-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 08:24:14 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7b9c91b814cso11367426b3a.2 for ; Wed, 24 Dec 2025 00:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766564654; x=1767169454; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=amWwOEekimBMh3/UGtUq5nDhhjd4Nl657eBMQHZc8lA=; b=jSXUp63LUFEUOZF07nggeW72hTIslRFaNRcSUVebqqozXRpkGzrkPFNhKFre6t5u6b g2tCsEW9gG8kSihiplR+Ueux+neSxffz7e5UUJxm1L8czCpxYFvIYnNQANlv+dhk4yXy u1M2Z9ly7Wo/56UXxNEp+yNds0aZcl317fYUPZmyKtwf1SHMoBkS70ySvh8zoeMzCXyk 2Uc1gKeUNmsLGSPLxpap92Euihno9DPnBllohhuL6WQuv0mWjIcgUC+ziO5Vl+/sPLXI CYEcVX8baR7bptyHBa/c2aysODZFcsV5vIwoMZ6dMtSjCOovocNUSz7VIVmIKBPXCyr8 uQdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766564654; x=1767169454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=amWwOEekimBMh3/UGtUq5nDhhjd4Nl657eBMQHZc8lA=; b=L5+jo0sQS9YMVgyLsjaEZO5RLpNDG1Zd9yfxo08oo3cSKoBWGpJViY392ZT5NyCnFa yCgb8Aos4/lgjap7k7i97scORDKoyRIbrC1nLumUb2+WwKGt2FiJN0QjSwXJz6LHVjaq MRCsls7vXZhQR/DLfxQYfo2eD3Pi6UiMSwKwzvAObyU9ec5yX2u2EOTy1hXdsq4IXOBy 8U8+D6718SJHhVGl3+WwpRVIc+RB0GxcSkTW4FcBNtsUCICOB13hcPWZxmuu2u4GWN+W Ons13J02p3uW1eZX0JihQsiS47pD7+C1cXDt3xZ5djdgjKcEmuvZkWQlJkvdS6KHzG5O hPWQ== X-Forwarded-Encrypted: i=1; AJvYcCV4qPv7LpllZJMgGJOp3ZRR/fHKu2YLroE0B6v/lZoH4l9hdTfab6ZZxksTTvL+c/cDA9sXnAtG8s5Vz/s=@vger.kernel.org X-Gm-Message-State: AOJu0YxEv/Xd5xU+Z7BLccIbXUUkJiHHAemdi2GplwvJxe9DQN5UjDKw n7XjLyy8qBVVozv44isSWtVioHNbWlpb1/KmJ363SsswMfOXnw11ovxC+Qp+Ozi8711YswWm7Nf pCSLPmXHwhlhfHBp1j8su9iND8vpiUN5jXyw9ppFQWYz+/spkcupMSkOGCCnGulm2spA= X-Gm-Gg: AY/fxX5aKldzqdG4p+wIMXy/qaHBEjcW0I9le7k/We6tyZ4X4vHVPkl0qOPqUUfmXld 140ck5TTxRYxcNIpdkMNMiGrwivZZKkGWJhEy5eknf/dXgFmPjzu8kJe+KdNWWkW1V4zRkp86o9 LT4YgeKjNINakvq5lST4qIbG2B3KwLYg7Vb+mdrz+FQ0dBqlWMcCxgyOxqs+ByxK420ILTwZgAi j43JzrxWvcvUN1lrEpKXs0pe1Pc+JDXytCfPD9sZbFF3TIZLHhX4XzCkumsF684kk3M3n942BVh 6QA5/vMEmR+kuQKzzGk3bcvZx5+3EJ8sF6j8s8p/qiMnwXCw9er1Rjqb+GzfW90iB/g+5YzAKnr GM1xRsO1cARvak0ZLaidrhKjqlsURB6ZxfS5/y5vriw== X-Received: by 2002:a05:6a20:1611:b0:35b:f559:171b with SMTP id adf61e73a8af0-376a81e2ec3mr15421682637.2.1766564654048; Wed, 24 Dec 2025 00:24:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqVbw4RVYEzoJEqtKIanM6SZbyN6obz97DqOEhmYo+cCNx2r94xkB9hkwvHBS64bB4jJT09g== X-Received: by 2002:a05:6a20:1611:b0:35b:f559:171b with SMTP id adf61e73a8af0-376a81e2ec3mr15421657637.2.1766564653525; Wed, 24 Dec 2025 00:24:13 -0800 (PST) Received: from [192.168.1.11] ([106.222.232.236]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70d65653sm17921554a91.5.2025.12.24.00.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 00:24:12 -0800 (PST) Message-ID: <7e946103-06cc-4e44-be00-fd0ab9a8f55c@oss.qualcomm.com> Date: Wed, 24 Dec 2025 13:54:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings To: Dmitry Baryshkov Cc: andersson@kernel.org, mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, amitk@kernel.org, mani@kernel.org, casey.connolly@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20251223123227.1317244-1-gaurav.kohli@oss.qualcomm.com> <20251223123227.1317244-4-gaurav.kohli@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: POvyghRPeO07Fusyme5FD855rwGmAZbM X-Authority-Analysis: v=2.4 cv=abZsXBot c=1 sm=1 tr=0 ts=694ba32e cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=pk+8NuH2X28N4C0eta/h1Q==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=oWjmmMRXmHzkLbypZ2IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=sptkURWiP4Gy88Gu7hUp:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: POvyghRPeO07Fusyme5FD855rwGmAZbM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA3MSBTYWx0ZWRfXwW5c0POfrjFV 7CtEgFL7/0G+4Y73x7nAe6etDmLaeQLSC7h2GSDHUIGeaB5paoe1RSKnbXx7RuXus2KIQyj3Wc0 UI0wtd+KWNE6sHk1MKCD8JE2YLVWO8PBbVVjZkuzgLxRQ8YqeXpKheNiPUWcdX2zYh+JoUX6Vmh jEa3KdSQMy7tkRVaCVToNPpOnQWbZFmec4rzBZW14jyEFZq/crrDBf42TKJ9y0JqBlk8mX2LCpr +uYgw2YYVG27BPA3SmbmTPkZqKb8/wXMLT3klr+pAjs2yYw9KzD7RJguXL5eKf2OjuCFm0ZqKYW ZRR8IVWAsTXfjwKkjbO+xvyxb/6tIS4A553vnMcJ4TODHQV4/UDW8WBgteXz86qVcOJtI9k6Tqc aoVfwESdQIasiYJ2yAp+RaLIXeDx8dSxMWPQAfkxQFbWJjhU0DNAI5UnRMyODZCnV9vTXANbSsB pZ8FOhU5uW/5B+XXMjQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240071 On 12/24/2025 1:00 AM, Dmitry Baryshkov wrote: > On Tue, Dec 23, 2025 at 06:02:22PM +0530, Gaurav Kohli wrote: >> The cooling subnode of a remoteproc represents a client of the Thermal >> Mitigation Device QMI service running on it. Each subnode of the cooling >> node represents a single control exposed by the service. >> >> Add maintainer name also and update this binding for cdsp substem. >> >> Co-developed-by: Casey Connolly >> Signed-off-by: Gaurav Kohli >> Signed-off-by: Casey Connolly >> --- >> .../bindings/remoteproc/qcom,pas-common.yaml | 6 ++ >> .../bindings/thermal/qcom,qmi-cooling.yaml | 99 +++++++++++++++++++ >> 2 files changed, 105 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> index 63a82e7a8bf8..bbc82253f76b 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> @@ -77,6 +77,12 @@ properties: >> and devices related to the ADSP. >> unevaluatedProperties: false >> >> + cooling: >> + $ref: /schemas/thermal/qcom,qmi-cooling.yaml# >> + description: >> + Cooling subnode which represents the cooling devices exposed by the Modem. >> + unevaluatedProperties: false >> + >> required: >> - clocks >> - clock-names >> diff --git a/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml b/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >> new file mode 100644 >> index 000000000000..90b46712d241 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >> @@ -0,0 +1,99 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2023 (c), Linaro Limited >> + >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/thermal/qcom,qmi-cooling.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm QMI based thermal mitigation (TMD) cooling devices. >> + >> +maintainers: >> + - Caleb Connolly > This wasn't updated. will fix this. >> + - Gaurav Kohli >> + >> +description: >> + Qualcomm QMI-based TMD cooling devices are used to mitigate thermal conditions >> + across multiple remote subsystems. These devices operate based on junction temperature >> + sensors (TSENS) associated with thermal zones for each subsystem. >> + >> + Each subnode corresponds to a control interface for a single instance of the TMD >> + service running on a remote subsystem. >> + >> +definitions: >> + tmd: >> + type: object >> + description: | >> + A single Thermal Mitigation Device exposed by a remote subsystem. >> + properties: >> + label: >> + maxItems: 1 >> + "#cooling-cells": >> + $ref: /schemas/thermal/thermal-cooling-devices.yaml#/properties/#cooling-cells >> + phandle: true >> + >> + required: >> + - label >> + - "#cooling-cells" >> + >> + additionalProperties: false >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,qmi-cooling-modem >> + - qcom,qmi-cooling-cdsp >> + >> + vdd: >> + $ref: "#/definitions/tmd" >> + description: >> + Modem processor temperature TMD >> + properties: >> + label: >> + const: modem > Why it being called vdd? > > Why do you define modem-specific node here, while the CDSP-specific is > defined under the if block? will remove modem in next post,  earlier we were developing for all subsystem. right now wanted to post for cdsp subsystem first, will fix in next post. >> + >> +required: >> + - compatible >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,qmi-cooling-cdsp >> + then: >> + properties: >> + cdsp_sw: >> + $ref: "#/definitions/tmd" >> + description: >> + CDSP software TMD >> + properties: >> + label: >> + const: cdsp_sw > Why do we need a label in addition to the node name? was seeing label error for cdsp_sw without this, let me recheck and update. >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + remoteproc-cdsp { >> + cooling { >> + compatible = "qcom,qmi-cooling-cdsp"; >> + >> + cdsp_sw0: cdsp_sw { > Is it allowed for device node names to have underscores? will fix this, but not seeing any binding error with underscores. > >> + label = "cdsp_sw"; >> + #cooling-cells = <2>; >> + }; >> + }; >> + }; >> + >> + remoteproc-cdsp1 { >> + cooling { >> + compatible = "qcom,qmi-cooling-cdsp1"; >> + >> + cdsp_sw1: cdsp_sw { >> + label = "cdsp_sw"; >> + #cooling-cells = <2>; >> + }; >> + }; >> + }; > What's the point of having the second CDSP block? Could you demonstrate > modem instead? Missed one cdsp1 block in this series, will add in next post. Leman's is using two cdsp subsystem for that we need cdsp1. >> +... >> -- >> 2.34.1 >>