From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D011C0015E for ; Thu, 20 Jul 2023 11:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbjGTLHi (ORCPT ); Thu, 20 Jul 2023 07:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjGTLHf (ORCPT ); Thu, 20 Jul 2023 07:07:35 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32EAB268F; Thu, 20 Jul 2023 04:07:34 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R68vq66JMztRZQ; Thu, 20 Jul 2023 19:04:23 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 19:07:31 +0800 Subject: Re: [PATCH net-next] page_pool: split types and declarations from page_pool.h To: Alexander Lobakin CC: , , , , , Eric Dumazet , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Saeed Mahameed , Leon Romanovsky , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno , Ilias Apalodimas , , , , , References: <20230719121339.63331-1-linyunsheng@huawei.com> <0838ed9e-8b5c-cc93-0175-9d6cbf695dda@intel.com> From: Yunsheng Lin Message-ID: <7e9c1276-9996-d9dd-c061-b1e66361c48b@huawei.com> Date: Thu, 20 Jul 2023 19:07:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <0838ed9e-8b5c-cc93-0175-9d6cbf695dda@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/20 0:42, Alexander Lobakin wrote: > > BTW, what do you think: is it better to have those two includes in the > root include/net/ folder or do something like > > include/net/page_pool/ > * types.h > * .h (let's say driver.h) > > like it's done e.g. for GPIO (see include/linux/gpio/)? It make more sense to add a new dir for page pool if there are more new headers added. As we are still keeping the page_pool.h mirroring include/linux/gpio.h, adding a new dir for only one header file only add another level of dir without abvious benefit. We can add a new dir for it if we turn out to be needing more header file for page pool in the future, does it make sense? > > Thanks, > Olek > > . >