From: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
To: Sneh Mankad <sneh.mankad@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maulik Shah <quic_mkshah@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific
Date: Tue, 28 Jul 2026 11:48:08 +0530 [thread overview]
Message-ID: <7e9f457f-3ac1-404d-8cf8-ca06842b9c1d@oss.qualcomm.com> (raw)
In-Reply-To: <20260713-shikra_stats-v3-3-4be17121729d@oss.qualcomm.com>
On 7/13/2026 1:46 PM, Sneh Mankad wrote:
> A generic "qcom,rpm-stats" compatible only reads stats for SoC level LPM
> stats like vmin and vlow.
>
> Shikra SoC specific compatible allows reading individual subsystem level
> LPM stats along with SoC level LPM stats. Change it.
>
> Keep "qcom,rpm-stats" as fallback compatible.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 4e5bc9e17c8ed8914733ac9fdc9b69128b40216e..b299f316e3c61858c4b380f6211d0f36ef9fecf9 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -535,7 +535,7 @@ apss_mpm: sram@1b8 {
> };
>
> sram@4690000 {
> - compatible = "qcom,rpm-stats";
> + compatible = "qcom,shikra-rpm-stats", "qcom,rpm-stats";
Upon running dtschema, I see the following validation error:
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb: sram@4690000
(qcom,shikra-rpm-stats): compatible: ['qcom,shikra-rpm-stats',
'qcom,rpm-stats'] is too long
from schema $id:
http://devicetree.org/schemas/soc/qcom/qcom-stats.yaml
Thanks
Komal
next prev parent reply other threads:[~2026-07-28 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:16 [PATCH v3 0/3] Add subsystem LPM stats support for Shikra Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 1/3] dt-bindings: soc: qcom: stats: Add compatible " Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 2/3] soc: qcom: stats: Add stats compatible and config " Sneh Mankad
2026-07-13 8:16 ` [PATCH v3 3/3] arm64: dts: qcom: shikra: Update rpm-stats compatible to SoC specific Sneh Mankad
2026-07-28 6:18 ` Komal Bajaj [this message]
2026-09-03 14:06 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9f457f-3ac1-404d-8cf8-ca06842b9c1d@oss.qualcomm.com \
--to=komal.bajaj@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mkshah@quicinc.com \
--cc=robh@kernel.org \
--cc=sneh.mankad@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®