From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4812BC10F1B for ; Tue, 13 Dec 2022 19:40:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236206AbiLMTkN (ORCPT ); Tue, 13 Dec 2022 14:40:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234940AbiLMTkK (ORCPT ); Tue, 13 Dec 2022 14:40:10 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5F092098D for ; Tue, 13 Dec 2022 11:40:09 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id cf42so6713663lfb.1 for ; Tue, 13 Dec 2022 11:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=stMgisODdzyH4aN9LIZZcNZJPHp6Z9airQGZMCS/JmI=; b=lnuWbyxHtMgkf+s8hZe/8hCnZCC7+HHjgxiVIZWGD3xYLqrwLQNZ6cLRNuoVQeTCy1 FhkAGxyZ8OLHM44vGTbCm5NTIhfVtZfe8PE8hFfKjhOzuzmGiXNxFsBjUqElZs5uLJVm 80ciQiGXMH8vO3WP0xeS4/o4222BnwweyItIGsmH128KwZhNrmj5bHcjQAiOXWlZfA36 CdV4A+Tuq4dwkucxsADtZum6EIn+vu9X83sk6OQauwLdjMgnLDda3BNXoVlhBEOr6BaU tk/39pFIA6xmz6E86JiGhTHtvpC59oAj3v6JOg50LFTHJKlr0jl9aP4UQJYHWDmT6c7O FBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=stMgisODdzyH4aN9LIZZcNZJPHp6Z9airQGZMCS/JmI=; b=runrM/xVgI4AO5+X1uvBLNZJ/jU7zQ6MrkIDstE/WJjmuKZZmdfMpMQKNJdwAdt5ji 4bUz8aiUnxLsgUETtHndoPi2pjmn3LJFmp3jPnrt2FwY7893lNxBKba2p4lkv2Q9qeu0 ffxYDVAW2AnuwfFYswo0gOEiK/FbcNtLufu/XhT234tRlJrc7l14NuBNqRd7g0uo/Raj qDBhT6exDvh0ms2BorwWc+K/MRycEDggwtFJO8G/FC4j5qgOaeyTznZ2074YHXRb2K8K iqNsEzuQvu2agaUfoblDOY+WHxJYVM+eoVo2dxVHKjvsZVn/xw124Q7Z5aUk+tx8l5v0 EKiw== X-Gm-Message-State: ANoB5pl79DSup3VQCzHZ/vouyFQbTAgqCOlKSmrz8NA7UVT02DaxTLKF nLH5i64QUJJFFCMqA86QF0cKPA== X-Google-Smtp-Source: AA0mqf4xduEXYMBNDtHzHJzMXgofyK1mhvwF6l+vax3uSnOA9pG3heegKXIuaG/Sd0203pCUeoGUVg== X-Received: by 2002:a05:6512:c3:b0:4b5:7054:3b55 with SMTP id c3-20020a05651200c300b004b570543b55mr4959790lfp.68.1670960408270; Tue, 13 Dec 2022 11:40:08 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id q6-20020a056512210600b004b15bc0ff63sm477326lfr.277.2022.12.13.11.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 11:40:07 -0800 (PST) Message-ID: <7ea03855-4806-f4ca-e0c3-4044e1095d6b@linaro.org> Date: Tue, 13 Dec 2022 20:40:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: Introduce a carveout for modem metadata Content-Language: en-US To: Sibi Sankar , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, manivannan.sadhasivam@linaro.org Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, amit.pundir@linaro.org, regressions@leemhuis.info, sumit.semwal@linaro.org, will@kernel.org, catalin.marinas@arm.com, robin.murphy@arm.com References: <20221213140724.8612-1-quic_sibis@quicinc.com> <20221213140724.8612-2-quic_sibis@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221213140724.8612-2-quic_sibis@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/12/2022 15:07, Sibi Sankar wrote: > Introduce a new carveout for modem metadata. This will serve as a > replacement for the memory region used by MSA to authenticate modem > ELF headers. > > Signed-off-by: Sibi Sankar Thank you for your patch. There is something to discuss/improve. > > aliases { > @@ -865,7 +870,7 @@ hp_i2c: &i2c9 { > clock-names = "iface", "bus", "nav", "snoc_axi", "mnoc_axi", "xo"; > > iommus = <&apps_smmu 0x461 0x0>, <&apps_smmu 0x444 0x3>; > - memory-region = <&mba_mem &mpss_mem>; > + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; > > /* This gets overridden for SKUs with LTE support. */ > firmware-name = "qcom/sc7180-trogdor/modem-nolte/mba.mbn", > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi > index bf522a64b172..bda0495aa0b5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi > @@ -17,6 +17,11 @@ > reg = <0x0 0x9c700000 0x0 0x200000>; > no-map; > }; > + > + mdata_mem: memory@9d100000 { > + reg = <0x0 0x9d100000 0x0 0x4000>; > + no-map; > + }; > }; > }; > > @@ -32,7 +37,7 @@ > > iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; > interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; > - memory-region = <&mba_mem>, <&mpss_mem>; > + memory-region = <&mba_mem>, <&mpss_mem>, <&mdata_mem>; Only two memory regions are allowed by bindings... unless you fix it in further patchset. If so, please re-order to have the bindings first. It helps reviewers not to have such questions. :) Best regards, Krzysztof