From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.mindbit.ro (xs1.mindbit.ro [80.86.107.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC90342BC2D for ; Wed, 15 Jul 2026 01:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.86.107.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784079673; cv=none; b=Ha8XMV9ocegUIBK2TZpEOIrGZG+AdXqtXQIIRPh98mt5H2AoGNftvN8UeXc6+ho1Gcp3/+sZgkf6kiopZVsF2z8ztob8N/t/p+mdp04i/lTEcBgw+Pug3YovXOfiZ95IV/fsJ4ZDX6Q+W8NmHZD6hs2d7RfxFfpoUG9S7NNUc5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784079673; c=relaxed/simple; bh=EbyzqU0Rmmb5GoTrx+9u3rDAFNA/EiAAl2DxY2ZSo7E=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aPAR3ykkZQXK50NtBBik23teHaIoyahXUj3xMAdQFL9kk8aqXbb/JvOtF2fJKAW8MJSlJrg6/i6BWmIl29i3T8P5qQDPp4TzzqbcDh7bl6ia5OLSmzw5zDAGXSCOiCZKLZm3nX/ZUXzsKs6WtW2Pe+toLDtG+QKKAkb/Hf2iM68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=rendec.net; spf=pass smtp.mailfrom=rendec.net; dkim=pass (2048-bit key) header.d=rendec.net header.i=@rendec.net header.b=cLxf4Der; arc=none smtp.client-ip=80.86.107.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=rendec.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rendec.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rendec.net header.i=@rendec.net header.b="cLxf4Der" Received: from dog.kanata.rendec.net (pool-174-112-193-187.cpe.net.cable.rogers.com [174.112.193.187]) by mail.mindbit.ro (Postfix) with ESMTPSA id 88D86C2A88; Wed, 15 Jul 2026 04:41:07 +0300 (EEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.mindbit.ro 88D86C2A88 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rendec.net; s=default; t=1784079668; bh=1XuInI9oVY/WDYE6ZHmJ8t8iZMh3CaBBKAbh0uQ8huc=; h=Subject:From:To:Date:In-Reply-To:References:From; b=cLxf4DerQgFeV1P/8X3t+h3QNbPSws27Mf/tHGlHUy9Txdsh8JUJmEfqMNkgwEnDB 9Z4Ly3iEd19oZry30WUN0Lrn8BDuqHb17g9tJL/j5SSWY08lDpsiflpfYPNpy4CVin BhjJLPiExAXxbvzXze+wO0rPA5S6vJVj1dQEqbc6r0nDQ04swb/2qQcnu4MzxllVzc pIz028uuEOtpu/ypLZHteopHkhNwIpHfsjNXCcYuSawpJysZfiayO+buch0KLnMji2 bQjK/ZrivF19sS1TvjZ/ILIPx1H/w21d/yhHdtsQHY3ceKqSYh/p/PC/1Wt0/YfGI6 jnfMt8t8GbbFQ== Message-ID: <7ea1d95d7c4287ca002bf1d1d422d61b5df9d82a.camel@rendec.net> Subject: Re: [PATCH] irqchip: Remove redundant dev_err()/dev_err_probe() From: Radu Rendec To: Pan Chuang , Thomas Gleixner , linux-kernel@vger.kernel.org Date: Tue, 14 Jul 2026 21:41:05 -0400 In-Reply-To: <20260714131331.494902-1-panchuang@vivo.com> References: <20260714131331.494902-1-panchuang@vivo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-07-14 at 21:13 +0800, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() and dev_err_probe() calls. >=20 > Signed-off-by: Pan Chuang > --- > =C2=A0drivers/irqchip/irq-qcom-mpm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 4 +-= -- > =C2=A0drivers/irqchip/irq-renesas-rzt2h.c | 2 +- > =C2=A0drivers/irqchip/irq-renesas-rzv2h.c | 4 ++-- > =C2=A03 files changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-qcom-mpm.c b/drivers/irqchip/irq-qcom-mp= m.c > index 181320528a47..8c575d7ce8a1 100644 > --- a/drivers/irqchip/irq-qcom-mpm.c > +++ b/drivers/irqchip/irq-qcom-mpm.c > @@ -464,10 +464,8 @@ static int qcom_mpm_probe(struct platform_device *pd= ev, struct device_node *pare > =C2=A0 > =C2=A0 ret =3D devm_request_irq(dev, irq, qcom_mpm_handler, IRQF_NO_SUSPE= ND, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "qcom_mpm", priv); > - if (ret) { > - dev_err(dev, "failed to request irq: %d\n", ret); > + if (ret) > =C2=A0 goto remove_domain; > - } > =C2=A0 > =C2=A0 return 0; > =C2=A0 > diff --git a/drivers/irqchip/irq-renesas-rzt2h.c b/drivers/irqchip/irq-re= nesas-rzt2h.c > index e06264add3cc..9086fc3a2043 100644 > --- a/drivers/irqchip/irq-renesas-rzt2h.c > +++ b/drivers/irqchip/irq-renesas-rzt2h.c > @@ -398,7 +398,7 @@ static int rzt2h_icu_request_irqs(struct platform_dev= ice *pdev, struct irq_domai > =C2=A0 ret =3D devm_request_irq(dev, virq, handler, 0, dev_name(dev), > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 data ?: (void *)(uintptr_t= )offset); > =C2=A0 if (ret) > - return dev_err_probe(dev, ret, "Failed to request IRQ %u\n", offset); > + return ret; > =C2=A0 } > =C2=A0 > =C2=A0 return 0; > diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-re= nesas-rzv2h.c > index 971ac83eee90..1a4703a353e9 100644 > --- a/drivers/irqchip/irq-renesas-rzv2h.c > +++ b/drivers/irqchip/irq-renesas-rzv2h.c > @@ -816,7 +816,7 @@ static int rzv2h_icu_setup_irqs(struct platform_devic= e *pdev, struct irq_domain > =C2=A0 ret =3D devm_request_irq(dev, virq, rzv2h_icu_swint_irq, 0, dev_n= ame(dev), > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (void *)(uintptr_t)i); > =C2=A0 if (ret) > - return dev_err_probe(dev, ret, "Failed to request int-ca55-%u IRQ\n",= i); > + return ret; > =C2=A0 } > =C2=A0 > =C2=A0 /* Unmask and clear all IP/CA55 error interrupts */ > @@ -844,7 +844,7 @@ static int rzv2h_icu_setup_irqs(struct platform_devic= e *pdev, struct irq_domain > =C2=A0 > =C2=A0 ret =3D devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_na= me(dev), rzv2h_icu_data); > =C2=A0 if (ret) > - return dev_err_probe(dev, ret, "Failed to request icu-error-ca55 IRQ\n= "); > + return ret; > =C2=A0 > =C2=A0 return 0; > =C2=A0} Reviewed-by: Radu Rendec