From: Dan Carpenter <dan.carpenter@linaro.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Adrien Thierry <athierry@redhat.com>,
Dan Carpenter <error27@gmail.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() to use dynamic debug
Date: Thu, 14 Sep 2023 09:38:01 +0300 [thread overview]
Message-ID: <7ea529c2-3da6-47df-9b09-28d4ab36c4ef@kadam.mountain> (raw)
In-Reply-To: <20230913185528.770634-4-umang.jain@ideasonboard.com>
Please rename vchiq_log_info() to vchiq_log_dbg() or something. When I
see "info", I think it's a KERN_INFO level. This is all debug stuff and
it's done correctly but the name is misleading so it looks wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2023-09-14 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 18:55 [RFC PATCH v2 0/4] staging: vc04: Drop custom logging Umang Jain
2023-09-13 18:55 ` [RFC PATCH v2 1/4] staging: vc04: Convert vchiq_log_error() to use dynamic debug Umang Jain
2023-09-13 18:55 ` [RFC PATCH v2 2/4] staging: vc04: Convert vchiq_log_warning() " Umang Jain
2023-09-13 18:55 ` [RFC PATCH v2 3/4] staging: vc04: Convert vchiq_log_info() " Umang Jain
2023-09-14 6:38 ` Dan Carpenter [this message]
2023-09-13 18:55 ` [RFC PATCH v2 4/4] staging: vc04: Convert vchiq_log_trace() " Umang Jain
2023-09-14 6:35 ` [RFC PATCH v2 0/4] staging: vc04: Drop custom logging Dan Carpenter
2023-09-17 15:36 ` Stefan Wahren
2023-09-23 9:39 ` Umang Jain
2023-09-23 10:19 ` Stefan Wahren
2023-09-25 12:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea529c2-3da6-47df-9b09-28d4ab36c4ef@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=athierry@redhat.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®