From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Paul Chaignon <paul.chaignon@gmail.com>
Cc: Emil Tsalapatis <emil@etsalapatis.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Hengqi Chen <hengqi.chen@gmail.com>,
loongarch@lists.linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v1 1/2] selftests/bpf: Check alignment flag if expected result is REJECT
Date: Thu, 12 Mar 2026 19:06:38 +0800 [thread overview]
Message-ID: <7ea56716-fd5f-1740-e634-1dec4196dd2c@loongson.cn> (raw)
In-Reply-To: <abKHi9Pr5iUbIQZI@mail.gmail.com>
On 03/12/2026 05:29 PM, Paul Chaignon wrote:
> On Thu, Mar 12, 2026 at 02:59:57PM +0800, Tiezhu Yang wrote:
...
>> For example, for the test_verifier 14,
>> verifier/atomic_cmpxchg.c:215
>> "Dest pointer in r0 - succeed, check 5",
>> if remove ".flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,",
>
> I think I'm missing something. Why would you remove this flag?
>
> Are you trying to illustrate that this is a program that could be
> rejected because of misaligned accesses?
Yes.
> I agree, but here the flag is
> set and this program is therefore rejected because of an invalid memory
> access; the misalgined access check is skipped in the verifier.
...
>> -#14/p Dest pointer in r0 - succeed, check 5 OK
>> +#14/p Dest pointer in r0 - succeed, check 5 OK (NOTE: not executed due to
>> unknown alignment)
>
> As stated in my previous answer, this note would be incorrect: the
> program was executed in test case #14 because it was rejected, not
> because of unknown alignment.
OK, please ignore this patch.
Thanks,
Tiezhu
next prev parent reply other threads:[~2026-03-12 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 6:45 [PATCH bpf-next v1 0/2] Modify some code about test_verifier Tiezhu Yang
2026-03-10 6:45 ` [PATCH bpf-next v1 1/2] selftests/bpf: Check alignment flag if expected result is REJECT Tiezhu Yang
2026-03-11 15:56 ` Emil Tsalapatis
2026-03-12 6:59 ` Tiezhu Yang
2026-03-12 9:29 ` Paul Chaignon
2026-03-12 11:06 ` Tiezhu Yang [this message]
2026-03-16 13:04 ` Paul Chaignon
2026-03-17 1:56 ` Tiezhu Yang
2026-03-11 16:11 ` Paul Chaignon
2026-03-10 6:45 ` [PATCH bpf-next v1 2/2] selftests/bpf: Add alignment flag for test_verifier 190 testcase Tiezhu Yang
2026-03-11 15:57 ` Emil Tsalapatis
2026-03-11 16:13 ` Paul Chaignon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea56716-fd5f-1740-e634-1dec4196dd2c@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=hengqi.chen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=paul.chaignon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®