From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7421C433FE for ; Wed, 16 Nov 2022 14:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233212AbiKPOhj (ORCPT ); Wed, 16 Nov 2022 09:37:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233064AbiKPOhX (ORCPT ); Wed, 16 Nov 2022 09:37:23 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 563CB2D1F2 for ; Wed, 16 Nov 2022 06:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668609388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+b7jSGWrVvTvS0TaC89xQ5xPfKD0DhOu05RjLAhcHw=; b=URvikb3J+6/h3rbAaKaHikyH8803hpop1j0UpOi09Rt3OP4e5nYORviP3e1sggK3i/oVWv PSFTcCXl0lIAhzqtQegWnuvoXe3hUayvWZCc62xwuYRWlZHOxcYMvbIfu+1swgR9FPycGk iY7BvLw3ILxR0ZL8B+zwZbESoHQLxoM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-154-2SV1KXDzOeyx8FzG4eKnUg-1; Wed, 16 Nov 2022 09:36:23 -0500 X-MC-Unique: 2SV1KXDzOeyx8FzG4eKnUg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B860A185A792; Wed, 16 Nov 2022 14:36:22 +0000 (UTC) Received: from [10.22.10.207] (unknown [10.22.10.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 157441121325; Wed, 16 Nov 2022 14:36:22 +0000 (UTC) Message-ID: <7eb8d6f9-b54c-aedc-982b-8ed2bddb948b@redhat.com> Date: Wed, 16 Nov 2022 09:36:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] cgroup/cpuset: Improve cpuset_css_alloc() description Content-Language: en-US To: Kamalesh Babulal , Tejun Heo , Zefan Li , Johannes Weiner Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Hromatka References: <20221116054415.79157-1-kamalesh.babulal@oracle.com> From: Waiman Long In-Reply-To: <20221116054415.79157-1-kamalesh.babulal@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/22 00:44, Kamalesh Babulal wrote: > Change the function argument in the description of cpuset_css_alloc() > from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the > argument type was introduced by commit eb95419b023a ("cgroup: pass > around cgroup_subsys_state instead of cgroup in subsystem methods"). > Also, add more information to its description. > > Signed-off-by: Kamalesh Babulal > --- > kernel/cgroup/cpuset.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index b474289c15b8..aac790462e74 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3046,9 +3046,14 @@ static struct cftype dfl_files[] = { > }; > > > -/* > - * cpuset_css_alloc - allocate a cpuset css > - * cgrp: control group that the new cpuset will be part of > +/** > + * cpuset_css_alloc - Allocate a cpuset css > + * @parent_css: Parent css of the control group that the new cpuset will be > + * part of > + * Return: cpuset css on success, -ENOMEM on failure. > + * > + * Allocate and initialize a new cpuset css, for non-root cpuset or return the > + * top cpuset css for root cpuset. Strictly speaking, it returns the css of top cpuset set for NULL input parameter. > */ > > static struct cgroup_subsys_state * While at it, could you also remove the blank line between the comment and the function body. Thanks, Longman