mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH] clk: scpi: error when clock fails to register
Date: Thu, 29 Jun 2017 10:03:07 +0100	[thread overview]
Message-ID: <7eb946bf-6958-daf9-fd75-f1e23c1f2154@arm.com> (raw)
In-Reply-To: <20170628135345.9337-1-jbrunet@baylibre.com>

Hi Jerome,

Thanks for the fix.

On 28/06/17 14:53, Jerome Brunet wrote:
> Current implementation of scpi_clk_add just print a warning when clock
> fails to register but then keep going as if nothing happened. The
> provider is then registered with bogus data.
> 
> This may latter lead to an Oops in __clk_create_clk when
> hlist_add_head(&clk->clks_node, &hw->core->clks) is called.
> 
> This patch fixes the issue and errors if a clock fails to register.
> 
> Fixes: cd52c2a4b5c4 ("clk: add support for clocks provided by SCP(System Control Processor)")

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

  parent reply	other threads:[~2017-06-29  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 13:53 Jerome Brunet
2017-06-28 15:04 ` Sudeep Holla
2017-06-28 15:38   ` Jerome Brunet
2017-06-28 15:52     ` Sudeep Holla
2017-06-28 16:46       ` Jerome Brunet
2017-06-28 17:07         ` Sudeep Holla
2017-06-28 22:33           ` Stephen Boyd
2017-06-29  8:50           ` Jerome Brunet
2017-06-29  9:12             ` Sudeep Holla
2017-06-29  9:03 ` Sudeep Holla [this message]
2017-06-30  0:25 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eb946bf-6958-daf9-fd75-f1e23c1f2154@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®