From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbdILWMX (ORCPT ); Tue, 12 Sep 2017 18:12:23 -0400 Received: from mout.gmx.net ([212.227.15.19]:51687 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdILWMT (ORCPT ); Tue, 12 Sep 2017 18:12:19 -0400 Subject: Re: fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes To: Meelis Roos Cc: linux-parisc@vger.kernel.org, Linux Kernel list References: <20170911194143.GA17131@ls3530.fritz.box> From: Helge Deller Message-ID: <7eba246c-c2bd-4d47-41a8-93e43239bb02@gmx.de> Date: Wed, 13 Sep 2017 00:12:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Zn8Efc54D8XSlQBzggfRpFjRkUpiDrrJCohlasiQWoSMn/BpJ8y 8hjbepJSu0ccN1p4AZ05JxYQkJ2lOFd3MqgFYEkg4EpdLnGNUSztu6iNFYWlyodzZXvLyRI Vq0pbZ2wykUxeTU+IX9MjbL4B5dRz8OvWZ48r8Ie5mdParlmCzrec2QhggCIEIkm97daYyS Nr9iNCN6C5suOv1cSf8/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:dhdllYnIXzI=:ZSkuQnbowO3GV8qm/fwXUI RBQjlIg1LfAJu4KxFyIXZlWeaY3cxoDVyZuHBL5CAUw6pSzu+lk/sl34C1ND43Eo9Sg/ALYV/ HNw+p//MzxZYCUfiu9wJpzOooPR+bbqbSxLlMDYjpWgOhmLxtwHx+zpB1owiwhnav9gp0i6o+ uQzxjZ0kSfghw3WvPe1gMtwSvfA3yTydyYUVWQP2eWJHkm4KKHQf86onD9+h2W26x3y1cocMa KkMrTwFaiyVF9lpl5sg7Vgg+pNLhtrgtWgI+tHniV1QWCjUQGPUjDJpSPbffJ+/g5U264AWDw Fu4/LOy7itwDKb+oDnggfCyXXLxjAkp2RRTzR0YoLYgXDiX1/kP61BHCc+3DV/wOkL1/vzkfw 5aHjfiLdBRUbiI2Zi/SmPpnBIDV0ftlS8qKUEz8zo7vpjjy7vQzqwwyxdoQGdJbA3nTke0Jch 90buU+h89BZ0mrK0Bs1+dZsf5Y0GI8ZmG5ibrCUrQS/EjSRHvEnqy4IWxYA6ZSRy05HQhuHAV PTSHcNLSmc7oPzL4GQ6kODsWwCHMIG0CsUsTR96h2bkiE/famxvdV/yMuCyfaqHHvMBu4Fzzy BmOHciZNCWxyGjyIgyqN2wyXTpdTS6eeltt7KWt24bEHueD+2BYJ+PWXBvu5d9DdAr7zjFUVk Jvmg2q8jWHknfjuQeq9kJBSArTz2zCxUQmbyU+Py/OOB3p8yo5gNtvb9ykLvpg16iaNLSJHXS PgAkx+izU9Qm6S1Cq1OHRTqzw6bV7wcTTvHumSwyylwKNujxwVe4lPb7nw/AarT6oV2mFr3fg GWGSFXK1G3zWAWevaPKDCS0hbV6HE8tsyAEVa6SLnpzfAPrHt4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.09.2017 22:16, Meelis Roos wrote: >> Meelis, this patch should fix both issues. >> Can you test? > > At least one of the warnings is still there - but I am on a 64-bit > kernel on RP3440, RP3410 and A500 where I saw this. Details? The ones you sent were 32bit issues (with 1024 bytes frame-size-warning): fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] arch/parisc/kernel/inventory.c:359:1: warning: the frame size of 1120 bytes is larger than 1024 bytes [-Wframe-larger-than=] Helge >> >> Helge >> >> [PATCH] parisc: Fix too large frame size warnings >> >> The parisc architecture requires larger stack frames than most other >> architectures on 32-bit kernels. >> Increase the default to 1280 bytes for parisc to avoid warnings in >> do_sys_poll() and pat_memconfig() functions. >> >> Signed-off-by: Helge Deller >> >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index b19c491cbc4e..2689b7c50c52 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -219,7 +219,8 @@ config FRAME_WARN >> range 0 8192 >> default 0 if KASAN >> default 2048 if GCC_PLUGIN_LATENT_ENTROPY >> - default 1024 if !64BIT >> + default 1280 if (!64BIT && PARISC) >> + default 1024 if (!64BIT && !PARISC) >> default 2048 if 64BIT >> help >> Tell gcc to warn at build time for stack frames larger than this. >> >