From: Hans de Goede <hdegoede@redhat.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: button: Add a DMI quirk for Razer Blade Stealth 13 late 2019 lid-switch
Date: Thu, 2 Jan 2020 22:27:06 +0100 [thread overview]
Message-ID: <7eba4578-42e2-69da-99a3-2fc316a588b8@redhat.com> (raw)
In-Reply-To: <20200102202754.24028-1-jason@jlekstrand.net>
Hi,
On 02-01-2020 21:27, Jason Ekstrand wrote:
> Running evemu-record on the lid switch event shows that the lid reports
> the first close but then never reports an open. This causes systemd to
> continuously re-suspend the laptop every 30s. Resetting the _LID to
> open fixes the issue.
>
> v2: Updated the comment to better describe the behavior of ACPI
>
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Thanks, looks good to me now:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/button.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index 662e07afe9a1..ef5d473e7992 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -122,6 +122,17 @@ static const struct dmi_system_id dmi_lid_quirks[] = {
> },
> .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> },
> + {
> + /*
> + * Razer Blade Stealth 13 late 2019, notification of the LID device
> + * only happens on close, not on open and _LID always returns closed.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Razer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Razer Blade Stealth 13 Late 2019"),
> + },
> + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN,
> + },
> {}
> };
>
>
next prev parent reply other threads:[~2020-01-02 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 17:54 Jason Ekstrand
2019-12-08 14:05 ` Hans de Goede
[not found] ` <CAOFGe95h-eKPiS-7D8_Lg3wcOR-yuQQNkunw21K_rQ64DtCMJw@mail.gmail.com>
2019-12-20 10:33 ` Hans de Goede
2020-01-02 20:27 ` Jason Ekstrand
2020-01-02 21:27 ` Hans de Goede [this message]
2020-01-07 10:53 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-12-06 17:47 Jason Ekstrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eba4578-42e2-69da-99a3-2fc316a588b8@redhat.com \
--to=hdegoede@redhat.com \
--cc=jason@jlekstrand.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®