From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdFIMBK (ORCPT ); Fri, 9 Jun 2017 08:01:10 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:29432 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbdFIMBJ (ORCPT ); Fri, 9 Jun 2017 08:01:09 -0400 Subject: Re: [PATCH] phy: cpcap-usb: add MUSB dependency To: Sebastian Reichel , Arnd Bergmann References: <20170609101655.2730560-1-arnd@arndb.de> <20170609114714.ysbbd4y4zqxt6tzx@earth> CC: Tony Lindgren , Rob Herring , From: Kishon Vijay Abraham I Message-ID: <7ebc90ce-3b0e-528b-3138-127a802637ea@ti.com> Date: Fri, 9 Jun 2017 17:30:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170609114714.ysbbd4y4zqxt6tzx@earth> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote: > Hi, > > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote: >> When MUSB is a loadable module, we get a link error for a built-in >> CPCAP driver: >> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove': >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox' >> >> This adds a Kconfig dependency to prevent this broken configuration, >> enforcing that CPCAP can only be a module when MUSB is also a module. >> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support") >> Signed-off-by: Arnd Bergmann > > Reviewed-by: Sebastian Reichel merged, thanks! -Kishon > > -- Sebastian > >> --- >> drivers/phy/motorola/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig >> index 91a46cffd639..6bb7d6bdf1bf 100644 >> --- a/drivers/phy/motorola/Kconfig >> +++ b/drivers/phy/motorola/Kconfig >> @@ -4,6 +4,7 @@ >> config PHY_CPCAP_USB >> tristate "CPCAP PMIC USB PHY driver" >> depends on USB_SUPPORT && IIO >> + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n >> select GENERIC_PHY >> select USB_PHY >> help >> -- >> 2.9.0 >>