From: "Lin Ma" <linma@zju.edu.cn>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, mingo@kernel.org,
tglx@linutronix.de, pwn9uin@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: atm: Fix incorrect net_device lec check
Date: Wed, 2 Jul 2025 11:44:31 +0800 (GMT+08:00) [thread overview]
Message-ID: <7ebd4e0b.7b84.197c93c74b1.Coremail.linma@zju.edu.cn> (raw)
In-Reply-To: <20250702033600.254-1-linma@zju.edu.cn>
Hello there,
Moreover, there is another similar bug found via variant analysis
```
// net/appletalk/ddp.c
static int handle_ip_over_ddp(struct sk_buff *skb)
{
struct net_device *dev = __dev_get_by_name(&init_net, "ipddp0");
struct net_device_stats *stats;
...
```
The code believes that __dev_get_by_name() must return device created
in ipddp_init() function, ignoring the fact that a malicious user could
hijack the interface name.
This bug is "fixed" in upstream by
commit 85605fb694f0 ("appletalk: remove special handling code for ipddp").
However, the stable version, like v5.15.186, still contains it.
Shall I send another patch? Or should the stable branch employ the existing
commits?
Regards
Lin
next prev parent reply other threads:[~2025-07-02 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 3:36 Lin Ma
2025-07-02 3:44 ` Lin Ma [this message]
2025-07-02 7:55 ` Eric Dumazet
2025-07-02 8:43 ` Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebd4e0b.7b84.197c93c74b1.Coremail.linma@zju.edu.cn \
--to=linma@zju.edu.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pwn9uin@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®