From: Paolo Bonzini <pbonzini@redhat.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Sean Christopherson <seanjc@google.com>
Cc: Lai Jiangshan <jiangshan.ljs@antgroup.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/2] KVM: X86/MMU: Add sp_has_gptes()
Date: Wed, 20 Apr 2022 22:48:23 +0200 [thread overview]
Message-ID: <7ebe81f7-ca97-0c0f-861e-7c7ae4af2f82@redhat.com> (raw)
In-Reply-To: <20220420131204.2850-2-jiangshanlai@gmail.com>
On 4/20/22 15:12, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
>
> Add sp_has_gptes() which equals to !sp->role.direct currently.
>
> Shadow page having gptes needs to be write-protected, accounted and
> responded to kvm_mmu_pte_write().
>
> Use it in these places to replace !sp->role.direct and rename
> for_each_gfn_indirect_valid_sp.
>
> -#define for_each_gfn_indirect_valid_sp(_kvm, _sp, _gfn) \
> +#define for_each_gfn_valid_sp_has_gptes(_kvm, _sp, _gfn) \
Small nit, for_each_gfn_valid_sp_with_gptes might be a little more
grammatical (not much).
> for_each_valid_sp(_kvm, _sp, \
> &(_kvm)->arch.mmu_page_hash[kvm_page_table_hashfn(_gfn)]) \
> - if ((_sp)->gfn != (_gfn) || (_sp)->role.direct) {} else
> + if ((_sp)->gfn != (_gfn) || !sp_has_gptes(_sp)) {} else
>
> static bool kvm_sync_page(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp,
> struct list_head *invalid_list)
> @@ -2112,7 +2120,7 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu,
> sp->gfn = gfn;
> sp->role = role;
> hlist_add_head(&sp->hash_link, sp_list);
> - if (!direct) {
> + if (sp_has_gptes(sp)) {
> account_shadowed(vcpu->kvm, sp);
> if (level == PG_LEVEL_4K && kvm_vcpu_write_protect_gfn(vcpu, gfn))
> kvm_flush_remote_tlbs_with_address(vcpu->kvm, gfn, 1);
> @@ -2321,7 +2329,7 @@ static bool __kvm_mmu_prepare_zap_page(struct kvm *kvm,
> /* Zapping children means active_mmu_pages has become unstable. */
> list_unstable = *nr_zapped;
>
> - if (!sp->role.invalid && !sp->role.direct)
> + if (!sp->role.invalid && sp_has_gptes(sp))
> unaccount_shadowed(kvm, sp);
>
> if (sp->unsync)
> @@ -2501,7 +2509,7 @@ int kvm_mmu_unprotect_page(struct kvm *kvm, gfn_t gfn)
> pgprintk("%s: looking for gfn %llx\n", __func__, gfn);
> r = 0;
> write_lock(&kvm->mmu_lock);
> - for_each_gfn_indirect_valid_sp(kvm, sp, gfn) {
> + for_each_gfn_valid_sp_has_gptes(kvm, sp, gfn) {
> pgprintk("%s: gfn %llx role %x\n", __func__, gfn,
> sp->role.word);
> r = 1;
> @@ -2563,7 +2571,7 @@ int mmu_try_to_unsync_pages(struct kvm *kvm, const struct kvm_memory_slot *slot,
> * that case, KVM must complete emulation of the guest TLB flush before
> * allowing shadow pages to become unsync (writable by the guest).
> */
> - for_each_gfn_indirect_valid_sp(kvm, sp, gfn) {
> + for_each_gfn_valid_sp_has_gptes(kvm, sp, gfn) {
> if (!can_unsync)
> return -EPERM;
>
> @@ -5311,7 +5319,7 @@ static void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa,
>
> ++vcpu->kvm->stat.mmu_pte_write;
>
> - for_each_gfn_indirect_valid_sp(vcpu->kvm, sp, gfn) {
> + for_each_gfn_valid_sp_has_gptes(vcpu->kvm, sp, gfn) {
> if (detect_write_misaligned(sp, gpa, bytes) ||
> detect_write_flooding(sp)) {
> kvm_mmu_prepare_zap_page(vcpu->kvm, sp, &invalid_list);
next prev parent reply other threads:[~2022-04-20 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 13:12 [PATCH 0/2] KVM: X86/MMU: Fix problem for shadowing 5-level NPT for 4-level NPT L1 guest Lai Jiangshan
2022-04-20 13:12 ` [PATCH 1/2] KVM: X86/MMU: Add sp_has_gptes() Lai Jiangshan
2022-04-20 20:48 ` Paolo Bonzini [this message]
2022-04-20 13:12 ` [PATCH 2/2] KVM: X86/MMU: Introduce role.passthrough for shadowing 5-level NPT for 4-level NPT L1 guest Lai Jiangshan
2022-04-20 17:15 ` Paolo Bonzini
2022-04-21 0:23 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebe81f7-ca97-0c0f-861e-7c7ae4af2f82@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=jiangshanlai@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®