From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37893403F3 for ; Wed, 20 May 2026 19:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779306886; cv=none; b=f5wRaibH2tYV9qc+yN0SuzYI5BFtrYGSlER/gRlk92ynmPdCB0gPK/hIkvVfZajtQ+wx6rGOQDIcBmDBRTp7oCiW/sO/JRwPJr7Q/TjAELITiuwmLc4thBDAgVZEKbQSyZ/SbIXe5tC1oH/w0VuBdVH/pEmpBGdxU87S167uprY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779306886; c=relaxed/simple; bh=9ZWtFRH0DPYU9OZpvc16UhZqJMlJFzczsymdwuMzGxY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W2dMnTJqOyVZ8iM+r1LFFfGo4iLDVqQIRNlyfM6PUQZ4bSqoEfD53+TUCT0pO5lU9BHNAmr/LvK0yOqz4LAoyhDLHPu0xuZoB567lcmTdual6QcZzjz28bqlogHqM+vXCzwyNAfEykqZnRHomLT/I1F6caX0UaD14Lc0HMle+Hk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V7gqvzRj; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V7gqvzRj" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2bd2051167eso24105815ad.1 for ; Wed, 20 May 2026 12:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779306883; x=1779911683; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=MvDmyYYDhU9M3W4nTBWC6Lb+TYu2a1Dlqugl0ynZCbs=; b=V7gqvzRjnpD/U1FBJiUhin3xfMWZDkhKCFHpT/XgNYO8nLcoGvUINYhbzflGJjY4bb sP0rRCHknKCyt2akAUK0amJptk+KaDxs/dd3N0RnOYCHrLogVlbIia89bRlSOPAYhqEh KOVYYERnwXuYGFcdY///0cYRlPW+xEmhF2lD3PTMhKFTxfKWTaCHvgQAAZrDL/NKA2A+ V9rbYysPtF4ErNH8c9rLpPf/SqZ+78IA9ry2nzGLdKKhNTuleGhEkToosuhGPoPtBcDy em+qVW5J7XdwFzTCCD3yasEd+XHJQCLyyNeuLkmxmqcC1PrjKGTMT4GF+j+nSyL9cd8S pQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779306883; x=1779911683; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MvDmyYYDhU9M3W4nTBWC6Lb+TYu2a1Dlqugl0ynZCbs=; b=rrv4EaHsQbVXmXo/fk+WVkwZdwRUZ3LIiPb2v+KbJO85j1PuE1yazoNJbyODEJgc6t 3nnEQ3WDxZu6pskbsmnkGWWzyEagobv3hxRbe6yymG4rHmDi1U+TkmqS4xstD8WhIbG+ pMPWhUTgbrb6mjVBsYztVe++gmI2h9G0MI/bTZwNOIh7qipsymMAlbC29J0+5MXvwlyN ycpoV7yfB8dBUoAe76z1Ep5dryV0tDAxc2UxEK1f18pZZ09RImPgA3gUuyth6n+JxRPz Q/l3LRoiuK9YnhgbK1/q/w3yJZ7Ch4OJ53k9SXt48aQlHasvqzD6nsGtvr+D5m7I4AMQ A5Xg== X-Forwarded-Encrypted: i=1; AFNElJ/AeEUKPXbV5XTqDW+IN2nqt8s8g7P9i37SM1/dETqxOiK7a0ryJDKH2m9uIXmJZAEUlyANq22UGy0Z1dQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxrHXLpOBPD7L8AaMt2SAabfNfCs+7lcuE2A2nJgXwqN1LXYRJ7 tUclo6cbJnoUKsyicGMUHLrDMZFeHsReC3hZd4rIKarxs3TMneGOg1sl X-Gm-Gg: Acq92OHIm91UFZaf3C0/sYnOyKGGEhOQ2haFDDb5AlHXj3C+o0SoojypW6BJYJs1icI LuX8jnzp3eRJ8r79Auw4jJmjRDjnYk4iylUiEzyeA/vRwwzPeV7+VaK4koKXp9iKAV+wbaoiRrK 66iNibYFFJhl+czz040vC/AM+Ipuky4E8cJ7Q7IEMumf+iCWcURYfdsenE7/H/dABCz0SGFDPu9 tkv384NEbDsj9UaEHqLNduI4mhs7sweiRJSXbFvUFve/B+YD1HGVsPXRMxZW9FdlyfCInWQ6xDE QDAFcc363l8am1QMZgWawlPq/RBxh0s04MLj7oHwsAX8WqM1UHG0nU/NLcZIFGK5NwAs+/YJ5cA NwfOVF0KLJo7BLIlWQYllI26dOv9af6nglWy4C/XcojaA9hMup4TUXmLOtpRIcm/vQ+imBA2rYb +K/Qm0Kd3BZUyku82j3k2w9m3HBuzAn2Dcr3ZbyiOiaCNOsWU= X-Received: by 2002:a17:903:22c9:b0:2bc:e2ed:fd03 with SMTP id d9443c01a7336-2bd7e9c8834mr267611215ad.39.1779306883142; Wed, 20 May 2026 12:54:43 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fcb10sm227212495ad.60.2026.05.20.12.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 12:54:42 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 20 May 2026 12:54:41 -0700 From: Guenter Roeck To: Reiner =?iso-8859-1?Q?Pr=F6ls?= Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A Message-ID: <7ec1cd4a-c094-42a2-ba60-e6cc7d82e7e2@roeck-us.net> References: <4eee938d-e4ca-427d-a161-aa9ef737af3c@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4eee938d-e4ca-427d-a161-aa9ef737af3c@gmail.com> On Wed, May 20, 2026 at 09:16:37PM +0200, Reiner Pröls wrote: > From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= > Date: Wed, 20 May 2026 20:59:57 +0200 > Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard Subject should be "hwmon: (nct6683) Add support for ASRock Z890 Pro-A" or similar. Actually, your outer subject comes close. > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > Description goes here. Look into the driver log for examples. Also, it looks like you embedded your patch in another patch with a different subject. That probably triggers: WARNING: From:/Signed-off-by: email address mismatch: 'From: "Reiner Pröls" ' != 'Signed-off-by: Reiner Pröls ' Also, when I try to apply the patch, I get "patch is empty". Please fix this up. > Signed-off-by: Reiner Pröls > --- >  drivers/hwmon/nct6683.c | 5 ++++- >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c > index 0581770380cc..1b9092f48c7d 100644 > --- a/drivers/hwmon/nct6683.c > +++ b/drivers/hwmon/nct6683.c > @@ -177,12 +177,13 @@ superio_exit(int ioreg) >  #define NCT6683_CUSTOMER_ID_MSI3    0x207 >  #define NCT6683_CUSTOMER_ID_MSI4    0x20d >  #define NCT6683_CUSTOMER_ID_AMD        0x162b > -#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c > +#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c >  #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b >  #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631 >  #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e >  #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621 >  #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633 > +#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A No C++ comments in this file, please. > >  #define NCT6683_REG_BUILD_YEAR        0x604 >  #define NCT6683_REG_BUILD_MONTH        0x605 > @@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev) >          break; >      case NCT6683_CUSTOMER_ID_ASROCK6: >          break; > +    case NCT6683_CUSTOMER_ID_ASROCK7: > +        break; Was this cut-and-paste ? There are no tabs, just spaces, meaning the patch would not apply. That would also explain the duplicated headers. Guenter >      default: >          if (!force) >              return -ENODEV; > -- > 2.43.0 > >