From: Joe Perches <joe@perches.com>
To: HerryYang@zhaoxin.com, CooperYan@zhaoxin.com,
linux-kernel@vger.kernel.org, hpa@zytor.com, lenb@kernel.org,
gregkh@linuxfoundation.org, QiyuanWang@zhaoxin.com,
mingo@kernel.org, DavidWang@zhaoxin.com, tglx@linutronix.de,
rjw@rjwysocki.net, TonyWWang-oc@zhaoxin.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/cpu] x86/cpu: Create Zhaoxin processors architecture support file
Date: Sat, 22 Jun 2019 11:01:17 -0700 [thread overview]
Message-ID: <7ec724a310a710e6415320ff530daba0e1d30505.camel@perches.com> (raw)
In-Reply-To: <tip-761fdd5e3327db6c646a09bab5ad48cd42680cd2@git.kernel.org>
On Sat, 2019-06-22 at 03:16 -0700, tip-bot for Tony W Wang-oc wrote:
> Commit-ID: 761fdd5e3327db6c646a09bab5ad48cd42680cd2
> Gitweb: https://git.kernel.org/tip/761fdd5e3327db6c646a09bab5ad48cd42680cd2
> Author: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> AuthorDate: Tue, 18 Jun 2019 08:37:05 +0000
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Sat, 22 Jun 2019 11:45:57 +0200
>
> x86/cpu: Create Zhaoxin processors architecture support file
>
[]
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
[]
> +static void init_zhaoxin_cap(struct cpuinfo_x86 *c)
> +{
> + u32 lo, hi;
> +
> + /* Test for Extended Feature Flags presence */
> + if (cpuid_eax(0xC0000000) >= 0xC0000001) {
> + u32 tmp = cpuid_edx(0xC0000001);
> +
> + /* Enable ACE unit, if present and disabled */
> + if ((tmp & (ACE_PRESENT | ACE_ENABLED)) == ACE_PRESENT) {
trivia:
Perhaps this is more intelligible for humans to read
and it deduplicates the comment as:
if ((tmp & ACE_PRESENT) && !(tmp & ACE_ENABLED))
The compiler produces the same object code.
next prev parent reply other threads:[~2019-06-22 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 8:37 [PATCH v2 1/3] " Tony W Wang-oc
2019-06-20 16:29 ` Borislav Petkov
2019-06-22 10:16 ` [tip:x86/cpu] " tip-bot for Tony W Wang-oc
2019-06-22 18:01 ` Joe Perches [this message]
2019-06-25 6:19 ` 答复: " Tony W Wang-oc
2019-06-25 6:31 ` Thomas Gleixner
2019-06-25 8:15 ` 答复: " Tony W Wang-oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec724a310a710e6415320ff530daba0e1d30505.camel@perches.com \
--to=joe@perches.com \
--cc=CooperYan@zhaoxin.com \
--cc=DavidWang@zhaoxin.com \
--cc=HerryYang@zhaoxin.com \
--cc=QiyuanWang@zhaoxin.com \
--cc=TonyWWang-oc@zhaoxin.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®