From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Dingxian Wen <shawn.wen@rock-chips.com>,
linux-media@vger.kernel.org, kernel@collabora.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()
Date: Fri, 7 Mar 2025 12:30:16 +0300 [thread overview]
Message-ID: <7ec94789-305c-4de4-b477-c0eb839170e5@stanley.mountain> (raw)
The num_clks is set this way:
hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
if (hdmirx_dev->num_clks < 1)
return -ENODEV;
The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.
Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 4ffc86ad6c35..e0d3fed87a92 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
bool hpd_trigger_level_high;
bool tmds_clk_ratio;
bool plugged;
- u32 num_clks;
+ int num_clks;
u32 edid_blocks_written;
u32 cur_fmt_fourcc;
u32 color_depth;
--
2.47.2
next reply other threads:[~2025-03-07 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 9:30 Dan Carpenter [this message]
2025-03-07 9:36 ` Dmitry Osipenko
2025-03-07 9:45 ` Dan Carpenter
2025-03-07 9:47 ` Dmitry Osipenko
2025-03-07 9:58 ` Hans Verkuil
2025-03-07 10:00 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec94789-305c-4de4-b477-c0eb839170e5@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dmitry.osipenko@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®