From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D2417ADF8 for ; Wed, 16 Jul 2025 03:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752635429; cv=none; b=NT8WK+FbSgB52HaO5mNpAIR1mMMISXn6WYl0PvlaB5jvvwi/4XA7x1swLONdOc9P8+4BaXE4sdR4VSYZrLxGWHwuRDyQ0D8v6Q3X3mGgE8LNafmTAIfZ0QIlOW/jllBBRwQ2fpI/jGJFag0JbjU7A5USzXWcbPYfXUfBCv3y2JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752635429; c=relaxed/simple; bh=+bE5/H9chYJq1Hq5l46H2XlpTKa0n+OuaZqkgbSrK4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eKCgNTZisbvG9UIkavjnE5AFnNoxtx7nP0+7pvcTzygaUIEpLHodLv7lX3S1P/f+dLRV6gSBZ5fvqIDObUtEbDDiyB1BVnBJoJN1VBS9vnAIWsGDvoFkfCdaeL6hLxThfbvEmozL/OJSAqaWY7WNQ46w1M+ybSYc0NdhamEzedU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g7YYe9l0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g7YYe9l0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56FGDMGn029564 for ; Wed, 16 Jul 2025 03:10:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R1NecSqh/K6FXbaYkgId4IAbjQh5zLHrJiU/Yh9hchg=; b=g7YYe9l020tJCFHM Kl+x+DKnpjysRbOWcWVs2tVAuyktWwyyuP5gVJkaqeTZ7Ln1Mr/Hrq4meXgmnTCA kiYVJmaP9/guUMfyo82hHkOdmn/iDlKnOEgnzMRLA918j93ZubHEN+MVLLmjgF+O lei3xGovsyCaQEFCiPcWJC/+s7my2SvXybNGqGUaUPnwNcowho8viXhhy6buNDIk 9WdH146m/Gj5USCWPHAWDkyeDFb73JMd7ZYauDXws4gAqGEyKq5zt/r8jq7RZ2gW Ds4vGgiuFyVgYrfjLH6AINGgyLV9jLuSqMlSEPYZ0W8KCMRsdgJuD8tfqxGoXBoP Lg7Wsw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ufxb2c4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 16 Jul 2025 03:10:25 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b31bc3128fcso7952922a12.0 for ; Tue, 15 Jul 2025 20:10:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752635424; x=1753240224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R1NecSqh/K6FXbaYkgId4IAbjQh5zLHrJiU/Yh9hchg=; b=hMzJ5qG6Ygn0aGjEVEmc7BhMjntLPHZdrZa4jYQczElHS0+4qTtBJS1vJXXd7l0ykn QMFHdAu83pbaszK9VHxBrvYL7Dyku2j7k0iZXYyizHfPBfWSr7q3e+2BPYQEiY/E+sm3 BFIfN1lk/Hn7PxZJnye58ScmWZCk+k92+lwy3tRQdq99tx3blRsSG4kLpooBVw7wgHHs pviB3m1nq7y7zexVVxuUQf2VSRjibdxP6kotjWX7Y90TSCttFJ2wqz/XSgmK21rLhqbN gYn0Hm38mQ1nYQZwG6ADKGkfpKnc2gVbfcSDz6FQ1WdXEtdhQyG/NcK3d6kTN4qf1EVS GIig== X-Forwarded-Encrypted: i=1; AJvYcCX+Hn9FZdN9LmPD4LNpqILzoKXnlqOCrRROcFGc23scBlkUFs1Pr0UCOBkuEfEnsDDoiYiqLPmK5ysOzHk=@vger.kernel.org X-Gm-Message-State: AOJu0YyPVyFtrI1t51vxKAvntmXyaXrwigPt2r2877s9Mb5xX4tEKfT6 OUnhn5tBaXDESduTbmsP0hnatmUdyB5i7JIyGsDm8FTJBeBfUvavZhxqQFGn8beEf4O1XLGJXr2 Yn6J/eEmhckVkd1eA4Kx6oin0CMXonSG4FPsiPvhO6y3zDXHCx/9lYcnzrPxvoLubzWA= X-Gm-Gg: ASbGncvBz0amojQ7BJgu2oR19Yt5OKgV0r4dG9lE4q7rLhV2z82B06ZIp81MzsAfrf9 dmi0Spu2N1dT95ffRuAnajNIF0+z+cP23ckODzVBxAWPPNE2kGWIh3XHsGJhIpAHVIhnsa+iIFc a+mkmNvaaxfYIbBrbYqtrFGApD3SylsNi10+cCRhEyvnGLBnpaPGCnUgl9GkwAx5keMhmiPO/Bt MYRIMLVQ8eHkbcqjMHFr302dFuvlCyTiUNCZ+f/9K1+5pwVWAMvWzpam2MOJSK/Q8MprKyh55V3 d121veyIQqR+7S/5QdnYzlG7xwMA58jc5FsHUJj1ua/FJwWrLyB0WnBw3KrdiQMjHEAFie7Alhd nReHL1gesWbbkWsF8UdFjLLI8HYYPT5sN X-Received: by 2002:a05:6a21:1508:b0:220:94b1:f1b8 with SMTP id adf61e73a8af0-2380db8e8d7mr1249302637.0.1752635424535; Tue, 15 Jul 2025 20:10:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiGRFaDVgMVw/6S2T7ToRpEE2QAahqPlEgNa4QLbCX9jXVhoF1n7FVrczoZKBOg8MHlEG5KA== X-Received: by 2002:a05:6a21:1508:b0:220:94b1:f1b8 with SMTP id adf61e73a8af0-2380db8e8d7mr1249278637.0.1752635424071; Tue, 15 Jul 2025 20:10:24 -0700 (PDT) Received: from [10.133.33.219] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74eb9f4c989sm13514936b3a.130.2025.07.15.20.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 20:10:23 -0700 (PDT) Message-ID: <7ecc1cfc-5033-4d74-9303-9ac58527113c@oss.qualcomm.com> Date: Wed, 16 Jul 2025 11:10:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wifi: ath11k: HAL SRNG: don't deinitialize and re-initialize again To: Muhammad Usama Anjum , Jeff Johnson , kbuild test robot , Ganesh Sesetti , Maharaja Kennadyrajan , Vasanthakumar Thiagarajan , Manikanta Pubbisetty Cc: kernel@collabora.com, stable@vger.kernel.org, Sriram R , Rajkumar Manoharan , Pradeep Kumar Chitrapu , Bhagavathi Perumal S , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250715132351.2641289-1-usama.anjum@collabora.com> Content-Language: en-US From: Baochen Qiang In-Reply-To: <20250715132351.2641289-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: MDcitSmR5P6O7RN4FwZGIR02_71fBNo- X-Proofpoint-ORIG-GUID: MDcitSmR5P6O7RN4FwZGIR02_71fBNo- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE2MDAyNyBTYWx0ZWRfX1ATn7m5k6NiZ R+tlOiElfHQuEJ8TiDS2gp4NoDMnabApFZykWeTazPDJyddNkKZEZwsZZsjSzvB+7SNMsPUkOMv QVFqoSv4ev7IyjqtFRbMPEw5EwRNBR7DzGBdJRMDE06MU5B/zuVmYISEngSqK3smLVwDwMTnoF4 XHFa8Yl42NOrpO356/HoeUE2XhSgUUdHtcRgXVp8StPyrN7pLRRlr44yh5SDBM5/yBk0lPDuvEg KD5rjuBZcWjO85eGD87sHWd4mfI3BD9ttT0e9Ikz5sUSNTOzitiNJMskiJVxD+WyaR4NIMbTeZA z5mt8ClGzhqpOSeU56Kr5XGTDkt0jUSUsRpmK+929jGbU8Z32UAZVHdUcdomG+25z1ZXOop7b+d jp/Fl8I4GgOAmowTn+mQMsjGuFDxipODB2IGFoxuCoeYBQFghUEBiYw78T+kMpzhhtTSTffh X-Authority-Analysis: v=2.4 cv=Xc2JzJ55 c=1 sm=1 tr=0 ts=68771821 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=QX4gbG5DAAAA:8 a=FO1u493g7a1ack9Z5SAA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=AbAUZ8qAyYyZVLSsDulk:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-16_01,2025-07-15_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507160027 On 7/15/2025 9:23 PM, Muhammad Usama Anjum wrote: > Don't deinitialize and reinitialize the HAL helpers. The dma memory is > deallocated and there is high possibility that we'll not be able to get > the same memory allocated from dma when there is high memory pressure. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03926.13-QCAHSPSWPL_V2_SILICONZ_CE-2.52297.6 > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Cc: stable@vger.kernel.org > Cc: Baochen Qiang > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Cc stable and fix tested on tag > - Clear essential fields as they may have stale data > --- > drivers/net/wireless/ath/ath11k/core.c | 6 +----- > drivers/net/wireless/ath/ath11k/hal.c | 12 ++++++++++++ > drivers/net/wireless/ath/ath11k/hal.h | 1 + > 3 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c > index 4488e4cdc5e9e..34b27711ed00f 100644 > --- a/drivers/net/wireless/ath/ath11k/core.c > +++ b/drivers/net/wireless/ath/ath11k/core.c > @@ -2213,14 +2213,10 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *ab) > mutex_unlock(&ab->core_lock); > > ath11k_dp_free(ab); > - ath11k_hal_srng_deinit(ab); > + ath11k_hal_srng_clear(ab); > > ab->free_vdev_map = (1LL << (ab->num_radios * TARGET_NUM_VDEVS(ab))) - 1; > > - ret = ath11k_hal_srng_init(ab); > - if (ret) > - return ret; > - > clear_bit(ATH11K_FLAG_CRASH_FLUSH, &ab->dev_flags); > > ret = ath11k_core_qmi_firmware_ready(ab); > diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c > index b32de563d453a..dafa9bdbb3d32 100644 > --- a/drivers/net/wireless/ath/ath11k/hal.c > +++ b/drivers/net/wireless/ath/ath11k/hal.c > @@ -1359,6 +1359,18 @@ void ath11k_hal_srng_deinit(struct ath11k_base *ab) > } > EXPORT_SYMBOL(ath11k_hal_srng_deinit); > > +void ath11k_hal_srng_clear(struct ath11k_base *ab) > +{ > + memset(ab->hal.srng_list, 0, > + sizeof(ab->hal.srng_list)); > + memset(ab->hal.shadow_reg_addr, 0, > + sizeof(ab->hal.shadow_reg_addr)); nit: I would add comment here that no need to memset rdp and wrp memory since each individual segment would get cleared when ath11k_hal_srng_src_hw_init() *srng->u.src_ring.tp_addr = 0; and ath11k_hal_srng_dst_hw_init() *srng->u.dst_ring.hp_addr = 0; > + ab->hal.avail_blk_resource = 0; > + ab->hal.current_blk_index = 0; > + ab->hal.num_shadow_reg_configured = 0; > +} > +EXPORT_SYMBOL(ath11k_hal_srng_clear); > + > void ath11k_hal_dump_srng_stats(struct ath11k_base *ab) > { > struct hal_srng *srng; > diff --git a/drivers/net/wireless/ath/ath11k/hal.h b/drivers/net/wireless/ath/ath11k/hal.h > index 601542410c752..839095af9267e 100644 > --- a/drivers/net/wireless/ath/ath11k/hal.h > +++ b/drivers/net/wireless/ath/ath11k/hal.h > @@ -965,6 +965,7 @@ int ath11k_hal_srng_setup(struct ath11k_base *ab, enum hal_ring_type type, > struct hal_srng_params *params); > int ath11k_hal_srng_init(struct ath11k_base *ath11k); > void ath11k_hal_srng_deinit(struct ath11k_base *ath11k); > +void ath11k_hal_srng_clear(struct ath11k_base *ab); > void ath11k_hal_dump_srng_stats(struct ath11k_base *ab); > void ath11k_hal_srng_get_shadow_config(struct ath11k_base *ab, > u32 **cfg, u32 *len); other than the nit: Reviewed-by: Baochen Qiang