From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5E62701CB for ; Fri, 13 Mar 2026 10:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397525; cv=none; b=Tb6dvSHi3yvI0wLZ1+qhLXL54dtQz8xbkt0sVFaAIoifge0ly6kvToD36uK46Lp8mfvT33ySyLOSEx/LLmqWEP1h1aOnbQ+aN4yceDIZJI8i/MCTm1jGg32s//jEwkU5zFaKZNwkB3DK71wsEEuQVFEQ6vmz0O/UqFEvYEOlGhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397525; c=relaxed/simple; bh=tuomQvuswwi9Xj7UB8ecI/FotEsBZbZZi7eGq/rDAnM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u3lmUcGlStf+T+UITte71ILpLTwPwlUxRIn4fZG8y49NdTKQ52+1Q9RIK3921M/xEgZlzhYe8HZEhEKceJ8Ac9dmuEABj/9TgTPACVWXWZP0ZJn9fAM153w8efQv2Om/uGhe6j7VjYuriXTaJ0OlbLauzTPT1D2ksdVQuGWDp/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mm30YTj3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EUtm9dT0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mm30YTj3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EUtm9dT0" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D8vQ5n482058 for ; Fri, 13 Mar 2026 10:25:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z6JX/cxPB5KnT9jggs10cXfq45mIFUC77SLavUgRftI=; b=mm30YTj3GccoLPq7 rkh02/zUDF++7oBxNLolIwe5iF5L/0lczgO6PFbuFj3v1EMugRoWi/IcukU8ItOO ggdLOUgW1+iUQGttJSbuVOBQ/jXGubnX+RFz3eDR7Mkb9LPJsZ03YgRlEH0zv+O6 Z9zCy+0nD7x3hLjpx3vt6zd//udoAO6zi9C1qUpAYllAZIQZ56HvYtJpUztbqb/s ysMQes5FpTYfmiWUMLCPInr8o5jldf06bE11TDWpZYl3YSADJSeoyr7kROsD0VIA d+BL95FHwijgbT3VSRPdyC5pTK8Hsu0Qr6NDa0CqrQPtT2LRiEuoHvQHsqbtaVNu N4aulg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvfh7raph-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 10:25:23 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb39de5c54so110730585a.0 for ; Fri, 13 Mar 2026 03:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773397522; x=1774002322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z6JX/cxPB5KnT9jggs10cXfq45mIFUC77SLavUgRftI=; b=EUtm9dT0ujfhmkbcJRcYWDtFFJTikD/Fhv1AKqfwczi4hdtRV0tSM4tYSPVKIJqNuY pjzzoSEX3/XC4HMybbe/uskVZP0UM8dNbAumH/JXty+4GRVhtN5DFk7kS3cZebe/9HFs E2CSFxmvV1KpqmFkjw4ZZug0d8/lSGo39q//fxovypGocsHKAGlkEVjtnai+kVzKnxuh eRn288ug+LnzB0lLO/DArw/fCYktS1MYw5KjaoKgXs8Bu1ggzFK/pkccz36qhZoGKsd6 oZW4noOJlCdey4NfVA5de77jvI2lw+Ru8kDri5jmS1yo8CSJt75VCTO0bVGOYakbwvrD AwoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773397522; x=1774002322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z6JX/cxPB5KnT9jggs10cXfq45mIFUC77SLavUgRftI=; b=rVHVDx1xceLUB3Ge3OGxPlPLio8Liv2fqKfGzFbVE+JmTAjS0Ik7tAO9+yezEn4qfe cf0ZZbveRqKzWc1BZgElNmQ1JKpYzmfdpdYRMe43b/Rv3nE30O7+v3ch3L9YxTwSnJAz vjw4GLCBrFQLhPcHczlz0CtIFehPb3wBweQQOMzbpBmQXRlTxl8Uoqw3MX886ymNeHd9 7YVhTdZiDxW4X4WvKRvJFiZviqNkkb3O+u9Tcoss6ItvoJujGKNpBl4qxet+xtnyh3bC 8aTX5ZragzJVY0WWZBA/JUNwIXYB3dMepV8dVQbe5BXy72yEXqMI6Eb49c/jTmMnQG/Y vZSA== X-Forwarded-Encrypted: i=1; AJvYcCUjLVqIqAIefIB9UFFg4a+9lKCfliKP920HEPJ9zqqzQHtT+ApUDvLRKYHUYz/e5mDilKlXjuZMOZAvIkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk9LAkalm3JpVXZxWlEaPjtr9ZQVgp3GXZFmZEGd707xQWcWd4 vLeoOJ0vFrtvGMZKTgnJWgZtjdXcWp/lET9h1eMsjLhiHsujzUu4evPI441qceBYVOFDj583CPK VivnJSA8k/9Q9A9wUHXZQEz8bQdtZI2KVdNh3OFEf/zhRevnOAlmpLzhKSJIR4+Fhj2g= X-Gm-Gg: ATEYQzwr7zOzqjKBoGPEv5/QkV2Y4V+urenN5/4N4oWWtLmznONo00VQ8acY/9IG/dV WdFZcLC2lzCiR7fTTPZeJmyVdhW4rOhTcl0Lxzbsl3R00itwGVUxVCGr32nmJ5cRpeOTH+0yHLv pU7vdtUjov5Fq0I8xWY67AY8vOJC+fkjOChJ/DCH9A7dcYvvQtqFU7YMtHXma+bNlr2ohuHovFs Xs2oVgPHJO74JMqk2ZKvpqYWPy5anB8jtOWi/oQamrNQdrY+pfdcaiB4cp+BkJXT7sk516p1Ebz d8TNbYb1CeZ/2o5mBSmYURr3PFhV514HqeZDXDkwO73herms1o9C4IPSvSR4PJA5pnqOtY4Z+dL S6WjlAstjovi0cwNv2cVaMRtCQiux5r+e1gjbFj4oXCe6c/OgFEltwgrsq4AX0C3he4JiWqaVZo 7T5gc= X-Received: by 2002:a05:620a:4113:b0:8cd:9828:a7b4 with SMTP id af79cd13be357-8cdb5baac4amr264667785a.9.1773397522548; Fri, 13 Mar 2026 03:25:22 -0700 (PDT) X-Received: by 2002:a05:620a:4113:b0:8cd:9828:a7b4 with SMTP id af79cd13be357-8cdb5baac4amr264665285a.9.1773397522025; Fri, 13 Mar 2026 03:25:22 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976d0918a7sm36067266b.63.2026.03.13.03.25.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:25:20 -0700 (PDT) Message-ID: <7ed3af47-daaf-43b6-8d2f-dc6b528d2c00@oss.qualcomm.com> Date: Fri, 13 Mar 2026 11:25:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-19-b7e8f800176a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312-ubwc-rework-v3-19-b7e8f800176a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LxKE1vtI9GiMeoxnXBTMQGD2fZPO_1pD X-Proofpoint-GUID: LxKE1vtI9GiMeoxnXBTMQGD2fZPO_1pD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA4MSBTYWx0ZWRfX6DJwlrQwPS7E OOmYMnJ8u5iaWzITJikPqGLgsGeZvB2Rs5+L1OxV551i192dp3NMfgOFFVFishQtMDXQY98pbBl RJyhd9uFSBqNReuubnYAsfVU16KYY9//Gs5cWmWHKOOlBd53U1r2sEJO955sgfWMHZbVc413Xc4 N+aXBQP5tUSaK/PATtcTw3UITP1oFvRS/FGYh5oV3TpVbTzzKx8Bxe02btYR7/xWpPH9ribD1Cx ZRpNM5pO/6io8YDxmTJNrpwBmvvw466L5yg7Gpr6+OBRBAHPgv0ewy7BCdJO+H0Vjj/Ak2R7qe6 B6ockT9KceU++waKa7yunbzdUpPkwm4pqJ+oV6ltlWcXhNAQVQ6se2PDXr4Q3gvSlO9BbIYClzO Lt7naqbUIrt47TsbOB20p7ALmXtMB+2ZzdiZi44ykGcQaJxfyzpFjRwfS3agZSxHAR+aS5nyRIE 7uiw/wTUMKNEm7hT+Gw== X-Authority-Analysis: v=2.4 cv=BpiQAIX5 c=1 sm=1 tr=0 ts=69b3e613 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=C-aM3KecGx6sHzoCZVkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130081 On 3/12/26 2:29 PM, Dmitry Baryshkov wrote: > Unlike other drivers, the DPU driver checks for exact UBWC version, > making it hard to add minor versions if necessary. Invert the order of > UBWC checks, letting the DPU driver handle new minors transparently. > > Signed-off-by: Dmitry Baryshkov > --- [...] Reviewed-by: Konrad Dybcio Konrad > } else { > DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_version); note this is existing behavior, but do we want to write to these registers on platforms without UBWC, instead of returning early? Konrad